Repository navigation
fix(network): stop scan and unchanged-state lines flooding the INFO log - #369
Open
gmmcosta15 wants to merge 2 commits into
Open
gmmcosta15 wants to merge 2 commits into
gmmcosta15 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The network worker logged every periodic scan and every 5-minute state snapshot at INFO, so field logs filled with lines that carried no news. The scan count line drops to DEBUG, and the state line stays at INFO only when something other than the signal strength changed.
Changes
scan: N visible of M AP(s)logs at DEBUG: the counts drift on every scanstate: conn=... sig=...logs at INFO only when connectivity, SSID, IP, Wi-Fi, ethernet or hotspot changed; an unchanged snapshot (signal-only drift) logs at DEBUG