Skip to content

fix(network): stop scan and unchanged-state lines flooding the INFO log #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gmmcosta15 wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix(network): stop scan and unchanged-state lines flooding the INFO log #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa0d8cb
fix(network): stop scan and unchanged-state lines flooding the INFO log
gmmcosta15 Oct 23, 2026
c727787
Merge branch 'dev' into fix/network-scan-log-spam
gmmcosta15 Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions BlocksScreen/lib/network/worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,8 @@ def __init__(self) -> None:
self._stale_logged_gen = -1
# Wi-Fi FAILED count, latched by the StateChanged listener.
self._wifi_failures = 0
# Last logged state minus signal: an unchanged snapshot logs at DEBUG only.
self._last_state_key: tuple | None = None

self._asyncio_loop: asyncio.AbstractEventLoop = asyncio.new_event_loop()
self._asyncio_thread = threading.Thread(
Expand Down Expand Up @@ -1021,14 +1023,20 @@ async def _build_current_state(self) -> NetworkState:
carrier, vlans = await asyncio.gather(
self._has_ethernet_carrier(), self._get_active_vlans()
)
logger.info(
"state: conn=%s ssid='%s' ip=%s wifi=%s eth=%s hotspot=%s sig=%d",
state_key = (
connectivity.name,
current_ssid,
current_ip or "-",
wifi_enabled,
eth_connected,
hotspot_enabled,
)
changed = state_key != self._last_state_key
self._last_state_key = state_key
logger.log(
logging.INFO if changed else logging.DEBUG,
"state: conn=%s ssid='%s' ip=%s wifi=%s eth=%s hotspot=%s sig=%d",
*state_key,
signal,
)
return NetworkState(
Expand Down Expand Up @@ -1294,7 +1302,8 @@ async def _scan_networks_once(self) -> None:
seen_ssids.add(info.ssid)

networks.sort(key=lambda n: (-n.network_status, -n.signal_strength))
logger.info("scan: %d visible of %d AP(s)", len(networks), len(ap_paths))
# Counts drift on every periodic scan: INFO here flooded the field logs.
logger.debug("scan: %d visible of %d AP(s)", len(networks), len(ap_paths))
self.networks_scanned.emit(networks)

async def _request_scan_if_allowed(self) -> None:
Expand Down
22 changes: 22 additions & 0 deletions tests/network/test_worker_unit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ def _make_worker(qapp, *, running=True, with_wifi=True, with_wired=False):
w._rediscover_gen = 0
w._stale_logged_gen = -1
w._wifi_failures = 0
w._last_state_key = None
w._system_bus = MagicMock(name="mock_system_bus")
w._primary_wifi_path = (
"/org/freedesktop/NetworkManager/Devices/2" if with_wifi else ""
Expand Down Expand Up @@ -120,6 +121,7 @@ def _bare_worker(qapp):
w._rediscover_gen = 0
w._stale_logged_gen = -1
w._wifi_failures = 0
w._last_state_key = None
w._system_bus = None
w._primary_wifi_path = ""
w._primary_wifi_iface = ""
Expand Down Expand Up @@ -157,6 +159,7 @@ def _make(qapp, *, running=True, wifi=True, wired=True):
w._rediscover_gen = 0
w._stale_logged_gen = -1
w._wifi_failures = 0
w._last_state_key = None
w._system_bus = MagicMock(name="mock_bus")
w._primary_wifi_path = "/org/freedesktop/NetworkManager/Devices/2" if wifi else ""
w._primary_wifi_iface = "wlan0" if wifi else ""
Expand Down Expand Up @@ -947,6 +950,25 @@ async def test_connected_state(self, qapp):
assert state.wifi_enabled is True
assert state.current_ssid == ""

@pytest.mark.asyncio
async def test_unchanged_state_logs_at_debug(self, qapp, caplog):
w = _make_worker(qapp)
w._nm = _ProxyFactory(AsyncProxyMock(connectivity=4, wireless_enabled=True))
w._get_current_ssid = AsyncMock(return_value="BLOCKS")
w._get_current_ip = AsyncMock(return_value="192.168.1.151")
w._is_ethernet_connected = AsyncMock(return_value=False)
w._has_ethernet_carrier = AsyncMock(return_value=False)
w._get_active_vlans = AsyncMock(return_value=[])
signals = iter([(67, "wpa-psk"), (68, "wpa-psk"), (68, "wpa-psk")])
w._wifi_signal_and_security = AsyncMock(side_effect=lambda _: next(signals))
with caplog.at_level(logging.DEBUG, logger=_worker_mod.logger.name):
await w._build_current_state()
await w._build_current_state() # only the signal moved
w._get_current_ip = AsyncMock(return_value="192.168.1.152")
await w._build_current_state()
levels = [r.levelno for r in caplog.records if r.msg.startswith("state:")]
assert levels == [logging.INFO, logging.DEBUG, logging.INFO]

@pytest.mark.asyncio
async def test_connected_with_ssid_gets_signal_and_security(self, qapp):
w = _make_worker(qapp)
Expand Down