Repository navigation
Add a 50 fps camera frame rate - #317
Merged
Merged
Conversation
FRAMERATE_FPS_50 lets an app ask the X3 Ultra for 50 fps, which BluEye-Robotics/gst_rtsp_record#345 runs as a true 50 fps: like 60, it opens the camera's 60 fps mode. At 4K, which has no such mode, 50 falls back to 25 as 60 falls back to 30, and the enum comment now says so. FRAMERATE_FPS_25 is no longer marked as Pioneer/Pro/X1/X3 only. The X3 Ultra accepts 25 fps as well, and runs it at a true 25 fps with the same change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alexagv
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
FRAMERATE_FPS_50 = 4toFramerate, so that the app can ask the X3 Ultra for 50 fps (BluEye-Robotics/BlueyeApp#1999).BluEye-Robotics/gst_rtsp_record#345 runs the Ultra at a true 25 or 50 fps instead of capturing 30 or 60 and dropping frames. It handles 50 fps on the ROS side already, but a protocol client has no value to ask for it with. Like 60, 50 opens the camera's 60 fps mode, so it is only available at QHD, 1080p and 720p, and at 4K it falls back to 25 as 60 falls back to 30. The enum comment now names both fallbacks.
FRAMERATE_FPS_25drops "(Only supported on Pioneer/Pro/X1/X3)": the Ultra accepts 25 fps as well, and runs it at a true 25 fps with gst_rtsp_record#345.The drone needs a mapping for the new value before it acts on it.
from_frameratein p2_drone'ssrc/node_comm/mapping_camera.cppturns a value it does not know into 30 fps, andto_frameratereports 50 as 30. Per the enum comment, 50 should give 25 on the drones that cannot run it.🤖 Generated with Claude Code