Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions app/registry.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,11 @@ def _field(
_field("simulation.start_time", "Start time", kind="number", group="Simulation", unit="s"),
_field("simulation.stop_time", "Stop time", kind="number", group="Simulation", unit="s"),
_field("simulation.stepSize", "Step size", kind="number", group="Simulation", unit="s"),
_field("simulation.solver", "Solver", kind="select", group="Simulation", choices=SOLVER_CHOICES),
_field("simulation.tolerance", "Tolerance", kind="number", group="Simulation"),
_field("simulation.case_timeout_s", "Case timeout", kind="number", group="Simulation", unit="s"),
_field("simulation.no_grid", "No grid", kind="boolean", group="Simulation"),
_field("simulation.no_event_emit", "No event emit", kind="boolean", group="Simulation"),
_field("simulation.solver", "Solver", kind="select", group="Numerics", choices=SOLVER_CHOICES),
_field("simulation.tolerance", "Tolerance", kind="number", group="Numerics"),
_field("simulation.case_timeout_s", "Case timeout", kind="number", group="Numerics", unit="s"),
_field("simulation.no_grid", "No grid", kind="boolean", group="Numerics"),
_field("simulation.no_event_emit", "No event emit", kind="boolean", group="Numerics"),
_field("execution.parallel", "Parallel", kind="boolean", group="Execution"),
_field("execution.max_workers", "Max workers", kind="integer", group="Execution"),
_field("execution.cleanup", "Cleanup raw artifacts", kind="boolean", group="Execution"),
Expand Down
9 changes: 8 additions & 1 deletion app/static/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -7067,7 +7067,14 @@ function renderSimConfigForm() {
}
const busy = (state.status?.jobs || []).some(job => ["queued", "running"].includes(job.status));
const fields = (state.simConfigPayload.fields || []).filter(field => !(selectedSimulation()?.ggv_source_id && (field.group === "Envelope" || field.path?.[0] === "model_dof")));
form.innerHTML = `<fieldset class="simulation-input-fields"${busy ? " disabled" : ""}>${fieldGroupSections(fields, "sim-config")}</fieldset>`;
const advancedGroups = new Set(["Numerics", "Execution", "Closed loop", "Fit"]);
const physical = fields.filter(field => !advancedGroups.has(field.group));
physical.sort((a, b) => (["Simulation", "Report"].indexOf(a.group) + 1) - (["Simulation", "Report"].indexOf(b.group) + 1));
const advanced = fields.filter(field => advancedGroups.has(field.group));
form.innerHTML = `<fieldset class="simulation-input-fields"${busy ? " disabled" : ""}>
${fieldGroupSections(physical, "sim-config")}
${advanced.length ? `<details class="component-details"><summary>Advanced</summary>${fieldGroupSections(advanced, "sim-config")}</details>` : ""}
</fieldset>`;
if (busy) form.querySelectorAll("button, input, select, textarea").forEach(control => {
control.title = "Simulation settings are locked while a run is active.";
});
Expand Down
10 changes: 5 additions & 5 deletions app/static/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -361,17 +361,17 @@ <h4>Controls</h4>
<section id="studies-view" class="screen">
<div id="signal-explorer" class="result-explorer-shell" hidden>
<aside class="workflow-list">
<h2><input id="signal-explorer-name" aria-label="Signal Explorer name" maxlength="120"></h2>
<label>X axis<select id="result-x-axis"></select></label>
<label>Color by<select id="result-color-signal"></select></label>
<h2 class="form-field"><input id="signal-explorer-name" aria-label="Signal Explorer name" maxlength="120"></h2>
<label class="form-field"><span>X axis</span><select id="result-x-axis"></select></label>
<label class="form-field"><span>Color by</span><select id="result-color-signal"></select></label>
<details id="result-comparison" class="result-comparison">
<summary>Comparison</summary>
<label>Baseline<select id="result-baseline-source"></select></label>
<label class="form-field"><span>Baseline</span><select id="result-baseline-source"></select></label>
<label class="result-compare-toggle"><input type="checkbox" id="result-compare-baseline">Show baseline</label>
<p id="result-comparison-status" class="muted" role="status"></p>
<details id="result-input-changes"><summary title="Compares archived vehicle and analysis settings. Referenced file contents and solver versions are not compared.">Saved settings</summary><div id="result-input-changes-list"></div></details>
</details>
<label>Y signals<input id="result-signal-search" type="search" placeholder="Find a signal"></label>
<label class="form-field"><span>Y signals</span><input id="result-signal-search" type="search" placeholder="Find a signal"></label>
<div id="result-signal-list" class="result-signal-list"></div>
</aside>
<section class="result-plot-shell">
Expand Down
11 changes: 11 additions & 0 deletions tests/app_editor_clarity.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,17 @@ vm.runInContext(`
renderSimConfigForm();
assert.equal(form.innerHTML,'edited inputs','background refresh must preserve unsaved fields');
state.dirtySimConfig=false;
state.status={jobs:[]};
state.simConfigPayload.fields=[
{path:['simulation','solver'],key:'solver',label:'Solver',group:'Numerics',kind:'string',value:'dassl'},
{path:['simulation','stop_time'],key:'stop',label:'Stop time',group:'Simulation',kind:'number',value:10},
{path:['sweep','velocity'],key:'velocity',label:'Velocity',group:'Sweep',kind:'number',value:12},
];
renderSimConfigForm();
assert.ok(form.innerHTML.indexOf('sweep.velocity') < form.innerHTML.indexOf('simulation.stop_time'));
assert.ok(form.innerHTML.indexOf('<summary>Advanced</summary>') < form.innerHTML.indexOf('simulation.solver'));
assert.ok(!form.innerHTML.includes(' open'));
state.simConfigPayload=null;
document=originalDocument;
}
`,ctx);
Expand Down
Loading