Repository navigation
Simplify simulation settings and style signal controls - #134
Open
rhorvath02 wants to merge 1 commit into
Open
rhorvath02 wants to merge 1 commit into
rhorvath02 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Simulation setup shows physical inputs first. Solver and execution controls are grouped under one collapsed Advanced section. Signal Explorer uses the existing form styles for its name, selectors, and search field.
Stacked on #133.
How to check
Editor behavior checks cover input ordering, collapsed advanced controls, and preservation of unsaved edits. Lint and type checking pass. Chrome inspection at 1100×700 confirms the controls are styled and the solver is initially hidden, with no JavaScript errors.
CI
GitHub lint, type checking, full tests, and PR-description checks pass. Container-toolchain CI is blocked by the OpenModelica download timeout.