[DoodleBears]

Issue #4244 · Depends on #4250

Why the change

Let Humans write approval guidance as separate Always ask, Always allow and supplemental sections, create templates from an explicit source, and choose when saving also applies the template to a Bot.

Special things to note

• Merge risk: one-way for newly saved structured content on rollback; large blast radius across shared templates and future Reviewer requests. Existing Markdown stays readable, but older versions display the V1 envelope as raw text; preserve or export original content before rolling back. Review the bounded codec, Human management checks, shared-template editing and saved Review snapshots.
• These are natural-language Reviewer instructions; deterministic card rules remain separate. Save alone does not select a template, copies are independent, and edits affect future Reviews.
• This draft is stacked on [Permissions E3] Select one effective Bot approval template and route unresolved reviews to Human #4250. Web/CLI verification and the opening-budget pair passed; Android/iOS and final Human acceptance remain pending. Retarget to main after [Permissions E3] Select one effective Bot approval template and route unresolved reviews to Human #4250 merges.

Change outline

Closes #4244

Explicit Blank or selected source
  → independent draft
  → Always ask[] / Always allow[] / supplemental text
  → Save only | Save and apply to this Bot
  → existing bounded template owner
  → Reviewer receives ask → allow → supplemental with saved content/version

The editor reuses the Bot settings grouped card list: only the outer corners are rounded, row seams are straight, and each input keeps a visible keyboard focus outline. CLI create/edit supports explicit blank/copy/parts input and the same optional application path.

Editor	Before: e40ae19	After: 43cfc1b
Light
Dark
Library light
Library dark

These paired English captures use the same legacy data, 1281×900 viewport and DPR 1.14; the unchanged base captures are explicitly reused. Current Chinese filled-row evidence shows the requested grouping:

Supplemental guidance after natural scrolling

Validation: root/mobile types and focused behavior/token tests passed; fresh Spec review had no findings and the Standards focus finding was repaired. Frozen-head build/served Client hashes, real CLI/Web blank/copy/save/apply/readback, actual Tab focus, middle-row edit/remove/add isolation, and a real Reviewer Session reaching ask-human passed. Existing Review content/version remains isolated from later edits.

DOM-ready opening, one matched pair	Base e40ae19	Head 43cfc1b	Budget
Template library	84.8 ms	83.3 ms	1500 ms
Legacy editor with exact full text	17.3 ms	19.9 ms	1500 ms
Added three ask + three allow editor	—	20.6 ms	1500 ms

Protocol V2 uses CLI show for complete text and identical corpus hashes, trusted clicks, CSS visibility and exact values; Chrome 153.0.8010.36, fresh isolated headless profiles, English/light, 1281×900/DPR 1.14. Earlier preview timeout and V1 fixture-validator failures are retained separately. This is DOM readiness, with no presented-FPS, native or speedup claim. CI remains pending.

Summary by CodeRabbit

• New Features

  • Approval templates can now be created from scratch or copied from an existing template, then edited with separate “Always ask,” “Always allow,” and free-text guidance.
  • Save changes without applying them, apply a saved template to a Bot, or do both. Editing a shared template shows which Bots use it; changes affect future Reviews, while in-progress Reviews keep their captured template.
  • The CLI now supports creating blank templates, editing structured guidance, and optionally applying a template to a Bot.

• Documentation

  • Updated English and Chinese guides with template editing, copying, selection, and compatibility details.

[coderabbitai]

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

Review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 0a6b344d-56a8-4f69-bbee-997cc7cd48fb

Commits

Reviewing files that changed from the base of the PR and between e40ae19 and 43cfc1b.

Files selected for processing: 16

• .agents/skills/verify-deepseekbot/features/approval-templates.md
• changes/4244-template-guidance-editor.md
• docs/adr/0342-bot-approval-selects-one-template-and-keeps-deterministic-authorization-separate.md
• docs/architecture/bot-approval-policy.md
• docs/architecture/bot-approval-policy.zh.md
• docs/bot-cli.md
• docs/bot-cli.zh.md
• packages/client/src/client/approval-template-library.tsx
• packages/client/src/client/locale.ts
• packages/client/test/approval-template-library.test.ts
• packages/core/src/bots/cli-approval-templates.ts
• packages/core/src/workspaces/approval-reviewer.ts
• packages/core/src/workspaces/approval-template-guidance.ts
• packages/core/src/workspaces/approval-templates.ts
• packages/core/test/approval-reviewer.test.ts
• packages/core/test/approval-template-library.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[DoodleBears]

Current-head Chinese review explainer: download standalone HTML.

Bound to PR #4261, head 43cfc1b7d9a176bcb98b1b6e8fe806fc526990b2, base e40ae19c327150851a04e1849b0e2d5d99dc6eec. Public hash, size, media type and attachment readback verified. The page covers authoring, explicit apply, Reviewer guidance, rollback and the protocol-V2 opening pair.

The generated page has zero draft warnings. Inline visual preview is blocked by the generator’s 70vh rule; this is recorded as an incomplete visual check. Web screenshots render in the PR; Android/iOS and final Human acceptance remain pending. The explainer is a review aid, not runtime proof.

[DoodleBears]

@coderabbitai review

[coderabbitai]

Action performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.