Conversation
sjavis
force-pushed
the
batching
branch
2 times, most recently
from
August 26, 2026 22:34
d18d88e to
c1b806e
Compare
sjavis
force-pushed
the
batching
branch
2 times, most recently
from
August 27, 2026 09:15
3990166 to
bce272a
Compare
sjavis
marked this pull request as ready for review
August 27, 2026 10:55
sjavis
commented
Aug 27, 2026
sjavis
force-pushed
the
batching
branch
2 times, most recently
from
August 28, 2026 14:54
76ee451 to
920796e
Compare
surbhigoel77
reviewed
Sep 1, 2026
|
|
||
| # Optionally delete the batch directory | ||
| if delete_batch_dirs: | ||
| batch_dir.rmdir() |
Member
There was a problem hiding this comment.
If the directory is non-empty, it will raise error and will not delete it.
surbhigoel77
reviewed
Sep 1, 2026
surbhigoel77
reviewed
Sep 1, 2026
| # Replace any %BATCH% and %ITER% tags in string arguments | ||
| i_iter, batch_dir = batch | ||
| for k, v in kwargs.items(): | ||
| if v == "%ITER%": |
Member
There was a problem hiding this comment.
Is the comparison between a cf-Field and string legit here?
Collaborator
Author
There was a problem hiding this comment.
As it turns out, no. In that case the equality seems to return the field for some reason which is truthy. I've moved it inside the check for string types in 4b73781.
Accept a list preprocessing functions. Use a registry of fields to keep in memory during preprocessing.
Collaborator
Author
|
This should be ready. Only the last two commits are new. The rest have just been rebased onto main / v1.0.0-rc branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a basic
batchingfunction. It creates a directory for each batch, retrieves / preprocesses data, then runs the tracker.The function takes these arguments:
%BATCH%, e.g."%BATCH%/input.nc".It includes options for where to save the outputs, whether to combine the output files (will be implemented in a later PR), and whether to delete the batch directories at the end.
Closes #191