test: move tests into their packages and run them per package - #133
Draft
userAugustos wants to merge 23 commits into
Draft
userAugustos wants to merge 23 commits into
userAugustos wants to merge 23 commits into
Conversation
CLI tests live in packages/cli/tests and core tests in packages/core/tests. Each package declares pytest, so turbo runs one test task per package and a filter runs a single package. The root tests directory keeps the end-to-end harness with its own task.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3 tasks
Keep the core tests out of the image build context.
…kages # Conflicts: # README.md
…kages The three test files new on main land in the package they exercise: test_canyonos_build.py and test_canyonos_env.py under packages/cli, test_local_controller_readiness.py under packages/core. The root suite keeps only the end-to-end harness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #126. Stacked on #130: the base of this PR is the #130 branch, so the diff shows only this change.
Summary
packages/cli/tests. Twenty-six core tests move topackages/core/tests. The roottests/keeps the end-to-end harness:run_tests.sh,README.md,test_integration.py,test_performance.py.testtask per package. pytest leaves the root dev group, and the root task becomes an explicit command overtests/only.bun run testruns the three tasks.bun run test --filter=canyonosor--filter=canyonos-coreruns one package. A package task caches and only reruns when that package or its own dependency closure changes.test_otel_exporter_fanout.pythat the move forced.run_tests.shalso runs the package suites.Test
uv syncfrom a clean checkout installs pytest and both packages.bun run test:canyonos65 passed,canyonos-python10 passed,canyonos-core167 collected with the 11 known errors.bun run test --filter=canyonosruns only the CLI tests and hits the cache on a second run.bun run checkpasses.Review Focus
turbo.json: the roottesttask runspytest testswithinputs: ["tests/**"], so a change underpackages/does not rerun it.canyonosvscanyonos_core).tests/run_tests.shline that runs the unit suites before the live deployment.Known and accepted
canyonos-core#testis red with the 11 known collection errors, sobun run teststill exits non-zero. Follow-up: test: make core tests collect outside the Docker image #127.sys.pathline that points at agrpc_stubsdirectory that no longer exists. It was dead before the move. Test cleanup is not in scope for this stack.