test: compile the controller protos for the core test session - #134
Draft
userAugustos wants to merge 22 commits into
Draft
userAugustos wants to merge 22 commits into
userAugustos wants to merge 22 commits into
Conversation
The core runtime bare-imports the generated gRPC stubs, which only the container images provide. A conftest now compiles the protos into a gitignored build dir at session start, so the core suite collects and runs from a checkout. The fake stub modules in the exporter test are no longer needed.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #127. Stacked on #133: the base of this PR is the #133 branch, so the diff shows only this change.
Summary
conftest.pyinpackages/core/testsnow compiles every proto undercanyonos_core/controller/protointopackages/core/build/pbat session start and puts that directory onsys.path. The directory is ignored by the rootbuild/rule.gpu_metricserrors came from theexcept ImportErrorbranch inlocal_controller.py, which runs when the frontend import fails on the missing stubs. With the stubs present, that branch never runs.typesimport. The real stubs make them redundant.grpcio-toolsis already a runtime dependency ofcanyonos-core.Test
bun run test:canyonos-core226 passed,canyonos65 passed,canyonos-python10 passed. Second run hits the cache for all three.pytestfrompackages/corewithout turbo also passes.bun run checkpasses.Review Focus
packages/core/tests/conftest.py: the protoc invocation mirrorscli.pyand the Dockerfile (python -m grpc_tools.protoc, all protos in the directory).Known and accepted
sys.pathline pointing at agrpc_stubsdirectory that never existed in this layout. Dead before this PR, harmless, not test cleanup for this stack.