Skip to content

ci: run the test suite with a cached turbo on every pull request - #135

Draft
userAugustos wants to merge 21 commits into
test/core-proto-stubsfrom
ci/turbo-tests
Draft

userAugustos wants to merge 21 commits into
test/core-proto-stubsfrom
ci/turbo-tests

Conversation

@userAugustos

@userAugustos userAugustos commented Sep 17, 2026

Copy link
Copy Markdown

Closes #128. Stacked on #134: the base of this PR is the #134 branch, so the diff shows only this change.

Summary

  • CI runs bun run test after bun run check, in the same job. A failing test fails the workflow.
  • The turbo cache directory persists between runs through actions/cache, keyed on the commit with a prefix restore key. A task whose inputs did not change replays from the cache instead of running again.
  • The workflow triggers on every pull request, whatever the base branch, and on pushes to main. Stacked PRs now run CI without a manual dispatch. A concurrency group cancels superseded runs, as in the core image workflow.

Test

  • CI is green on this PR with all three test tasks.
  • A second run on the same commit shows the turbo tasks as cached.
  • A push to main runs the workflow.

Review Focus

  • The cache key shape and the choice of caching over --affected: --affected needs a full-depth checkout and does not select any task for a commit that only changes uv.lock, while the cache hash includes the resolved dependency closure.
  • Python task hashes include the uv version, the Python version, and the runner's OS identity, so a runner image update makes the cache miss once. That is a safe miss.

Known and accepted

  • No remote cache. The local cache lives in the GitHub Actions cache and follows its eviction rules.
  • bun run test stops at the first failing task. Reporting every package before failing is one flag away if reviewers prefer it.

CI now runs bun run test after the checks, keeps the turbo cache between
runs with actions/cache, and triggers on every pull request and on
pushes to main.
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant