Skip to content

Fix iPad page-tree resize selection - #44

Merged
Chefski merged 5 commits into
devfrom
codex/fix-ipad-page-navigation
Sep 1, 2026
Merged

Fix iPad page-tree resize selection#44
Chefski merged 5 commits into
devfrom
codex/fix-ipad-page-navigation

Conversation

@Chefski

@Chefski Chefski commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Preserves the selected page when a compact iPad page-tree reader transitions to the regular-width detail column.

Verification:

  • focused page-presentation unit tests
  • focused iPad page-opening UI test
  • focused iPad Settings navigation UI test
  • strict SwiftLint
  • git diff --check

@greptile-apps

greptile-apps Bot commented Sep 1, 2026

Copy link
Copy Markdown

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The new guard aligns selection cleanup with the presentation lifecycle: stack readers clear their matching selection, while detail-column transitions preserve the selected page required after resizing.

Important Files Changed

Filename Overview
docmostly/Features/PageReader/PageReaderDestinationView.swift Adds a presentation-aware disappearance guard so compact-to-regular transitions retain the page needed by the detail column.

Reviews (1): Last reviewed commit: "fix: preserve page tree selection on res..." | Re-trigger Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@Chefski
Chefski merged commit a43c6d1 into dev Sep 1, 2026
11 of 12 checks passed
@Chefski
Chefski deleted the codex/fix-ipad-page-navigation branch September 1, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant