Skip to content

Fix iPad page-tree resize selection #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chefski merged 5 commits into from
Sep 1, 2026
Merged

Fix iPad page-tree resize selection #44

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
68fed21
fix: open iPad pages in the detail column
Chefski Sep 1, 2026
fc0f0a3
fix: preserve content column navigation
Chefski Sep 1, 2026
dc7a9b6
fix: reconcile iPad navigation transitions
Chefski Sep 1, 2026
73cc82a
Merge remote-tracking branch 'origin/dev' into codex/fix-ipad-page-na…
Chefski Sep 1, 2026
141fda7
fix: preserve page tree selection on resize
Chefski Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docmostly/Features/PageReader/PageReaderDestinationView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import SwiftUI

struct PageReaderDestinationView: View {
@Environment(AppState.self) private var appState
@Environment(\.pageOpenPresentation) private var pageOpenPresentation

let pageID: String

Expand All @@ -11,6 +12,7 @@ struct PageReaderDestinationView: View {
appState.selectPage(id: pageID)
}
.onDisappear {
guard pageOpenPresentation.shouldClearSelectedPageOnReaderDisappear else { return }
appState.clearSelectedPage(ifMatching: pageID)
}
}
Expand Down
Loading