Repository navigation
Avoid transaction tracing locks when tracing is disabled - #228
Merged
Merged
Conversation
iskakaushik
force-pushed
the
perf-queue-and-pump
branch
from
October 20, 2026 03:19
156e269 to
9ce72ce
Compare
iskakaushik
force-pushed
the
skip-unwanted-copy
branch
from
October 20, 2026 03:19
034fe7b to
4c6ba8d
Compare
iskakaushik
force-pushed
the
perf-queue-and-pump
branch
from
October 20, 2026 03:21
9ce72ce to
44a0984
Compare
serprex
reviewed
Oct 20, 2026
iskakaushik
force-pushed
the
perf-queue-and-pump
branch
from
October 20, 2026 12:41
44a0984 to
c7fc77f
Compare
serprex
force-pushed
the
skip-unwanted-copy
branch
from
October 22, 2026 16:44
4c6ba8d to
b3fd51f
Compare
serprex
force-pushed
the
perf-queue-and-pump
branch
from
October 22, 2026 16:44
c7fc77f to
6139eff
Compare
serprex
changed the title
This was referenced Oct 22, 2026
Transaction buffering still locks a span registry when tracing is disabled, even though no transaction spans can be registered. This adds unnecessary work to transaction lookup and abort handling. Create and share a registry only when OTLP is configured. Leave it absent otherwise so buffering skips registry lookups and cleanup. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
serprex
changed the title
serprex
force-pushed
the
perf-queue-and-pump
branch
from
October 22, 2026 18:09
6139eff to
b988159
Compare
serprex
approved these changes
Oct 22, 2026
harshil-goel
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transaction buffering still acquires span registry locks with tracing disabled, even though no transaction spans can be registered. These locks add unnecessary work to transaction lookup and abort handling.
Create and share a registry only when OTLP is configured. Otherwise, leave it absent so buffering skips registry lookups and cleanup. With OTLP enabled, pump, decoder, and buffer continue sharing transaction spans.
Split original #228 into independent PRs against
main; retain this PR for registry lock optimization. Other changes extracted from original #228: