Repository navigation
Place ack seqs through their allocator - #265
Merged
Merged
Conversation
serprex
force-pushed
the
split/ack-allocator
branch
from
October 22, 2026 20:33
88e858c to
3f811d2
Compare
Every OpenSeq cloned the collector's UnboundedSender to send its own Placed event. The reorder allocator holds events and sends them in bulk, so the clone and drop were pure refcount traffic on a channel counter shared with the collector, about 6% of the serial queue worker's cycles on the lifecycle benchmark. SeqAlloc::place now sends or holds the event, and OpenSeq carries only its seq. Tests that close the tail drop their allocator first, since the collector exits once its last sender is gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
serprex
force-pushed
the
split/ack-allocator
branch
from
October 22, 2026 20:38
3f811d2 to
d1b7c2f
Compare
harshil-goel
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every OpenSeq clones and drops collector channel sender to publish placement. Route placement through SeqAlloc, which already owns sender and batches events. Preserve sequence ordering and collector shutdown.
Extracted from original #228 and based directly on
main. Contains no changes from #226 or other extracted PRs.Validation:
cargo fmt --all -- --check,cargo clippy --workspace --all-targets --locked -- -D warnings, andcargo test --locked --lib emit::pipeline::(77 passed). Rebuild crate for each isolated diff.Measured impact (2026-10-22)
Compared
88e858c987e9b79f6f9ed40942296516ebec0db0against shared parent151fd47cbd75ec7b9bc63ffe7040f049e702ecd0, with each PR built separately.Workload: 524,288 production
SeqAlloc::open/placepairs with zero rows, real ack collector, yield every 4,096 seqs. Wait for contiguous collector frontier before stopping timer and check fatal state. Both revisions useSeqAlloc::place, isolating removed sender clones. Covers allocator/collector CPU, without row encoding, ClickHouse insertion, or bootstrap throughput.AMD Ryzen 7 7840U; rustc 1.99.1; locked dependencies; optimized release builds; mimalloc 0.1.52. Seven trials per revision, alternating base/PR order, pinned to CPUs 2,4,6 (three physical cores). Values show median [min, max]; negative time changes mean less work or waiting. Local component measurements, without PostgreSQL or ClickHouse services.