Repository navigation
Conversation
redeboer
commented
Nov 7, 2026
Member
Author
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'TensorWaves benchmark results'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 7ae7351 | Previous: d87354f | Ratio |
|---|---|---|---|
benchmarks/expression.py::test_fit[1000-ScipyMinimizer-numpy] |
7.278418512982209 iter/sec (stddev: 0.000798621735155104) |
16.113062913278878 iter/sec (stddev: 0.0002623519931624775) |
2.21 |
benchmarks/expression.py::test_fit[1000-ScipyMinimizer-numba] |
7.135644490745856 iter/sec (stddev: 0.0015734880573458573) |
16.217841898876852 iter/sec (stddev: 0.0003193217998612972) |
2.27 |
benchmarks/expression.py::test_fit[1000-ScipyMinimizer-tf] |
0.6077344978805652 iter/sec (stddev: 0.022967021085928248) |
1.4043607630131383 iter/sec (stddev: 0.0016402295685287915) |
2.31 |
benchmarks/unbinned_nll.py::test_unbinned_nll_normalization_formula[original-numpy] |
29.16207799344516 iter/sec (stddev: 0.0017729495617012552) |
80.89992620132578 iter/sec (stddev: 0.0014910944339774205) |
2.77 |
benchmarks/unbinned_nll.py::test_unbinned_nll_normalization_formula[original-tensorflow] |
57.43488428452988 iter/sec (stddev: 0.0018626743835165162) |
129.63414209598676 iter/sec (stddev: 0.0002041886279346019) |
2.26 |
benchmarks/unbinned_nll.py::test_unbinned_nll_normalization_formula[optimized-numpy] |
36.84259935711421 iter/sec (stddev: 0.0021106539680015453) |
126.61085086393801 iter/sec (stddev: 0.0007772448410810061) |
3.44 |
benchmarks/unbinned_nll.py::test_unbinned_nll_normalization_formula[optimized-tensorflow] |
59.93395257823824 iter/sec (stddev: 0.0015899874211372483) |
160.31611202220606 iter/sec (stddev: 0.0002920427106502862) |
2.67 |
benchmarks/unbinned_nll.py::test_unbinned_nll_estimator[numpy] |
119.37586458864193 iter/sec (stddev: 0.0022454294748264192) |
333.18786869068646 iter/sec (stddev: 0.0008835784608970419) |
2.79 |
benchmarks/unbinned_nll.py::test_unbinned_nll_estimator[numba] |
97.95784093013958 iter/sec (stddev: 0.0013096238324108408) |
534.0952050682405 iter/sec (stddev: 0.0009391258569386208) |
5.45 |
This comment was automatically generated by workflow using github-action-benchmark.
redeboer
force-pushed
the
phasespace-numpy-backend
branch
from
November 17, 2026 21:18
048622d to
47dba74
Compare
redeboer
marked this pull request as ready for review
November 17, 2026 21:18
redeboer
force-pushed
the
phasespace-numpy-backend
branch
4 times, most recently
from
November 18, 2026 09:56
6392678 to
b729c09
Compare
redeboer
changed the base branch from
support-phasespace-2
to
dependabot/lock-2fb387fa0b
November 18, 2026 10:33
redeboer
force-pushed
the
phasespace-numpy-backend
branch
from
November 18, 2026 10:49
b729c09 to
623dc67
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⚙️ Enhancements
tfextra installs nothing there and the NumPy, JAX, and Numba backends remain available.TFPhaseSpaceGeneratorPhaseSpaceGeneratorTFWeightedPhaseSpaceGeneratorWeightedPhaseSpaceGeneratorphspandpwaextras installing TensorFlowtfextra explicitly when TensorFlow is needed, for example forTFSummaryorbackend="tensorflow"❗ Behavioral changes
backend="tensorflow"withTFUniformRealNumberGeneratorto retain the previous values.🖱️ Developer experience
tensorflowpytest marker. Tests parametrized over a TensorFlow backend or RNG are marked automatically, and marked tests are skipped when TensorFlow is not installed, so the test suite runs on Python 3.14 and 3.15.📝 Documentation
Squash commit messages