Codex follow-ups on #26 (1.5.10): legacy archive validation, contained purge, WSL withdrawal prunes manifest and consent, archive path checked first - #27
Merged
Conversation
…d purge, WSL withdrawal prunes manifest and consent, archive path checked first - ledger_archive: an unmarked directory is accepted as a legacy archive only when its index has our schema and every other entry is a plain host directory; purge validates the host name and containment for both candidate files and keeps unsafe rows as unremovable. - ledger: withdrawing the legacy WSL default (config version 2) also removes WSL hosts from the manifest and sets any scheduled-run consent aside (renamed .withdrawn), persisting the migration on load; the archive path is validated right after the answers/overrides, before detection, credential reads or any write. - tests extended (foreign index refused, legacy accepted, escaping row kept, manifest pruned, consent withdrawn, archive path checked before accounts.json is touched). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WUhGzUwi8pXjngqs22ghZ3
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d48a157560
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
3 tasks
CompleteDotTech
added a commit
that referenced
this pull request
Sep 10, 2026
Codex follow-ups on #27 (1.5.11): reconcile version-2 homes, keep consent when nothing was pruned, full legacy schema check, encoded SQLite URIs
BunsDev
pushed a commit
to BunsDev/ai-usage-ledger-skill
that referenced
this pull request
Sep 11, 2026
… homes, keep consent when nothing was pruned, full legacy schema check, encoded SQLite URIs - ledger: CONFIG_VERSION 3; on load, when WSL discovery is off the manifest is pruned of WSL hosts whatever version wrote the home, and a scheduled consent is set aside only when that pruning actually changed the scanned scope. - ledger_archive: a legacy archive is accepted only with the complete files and runs schemas; the index path is percent-encoded before it becomes a SQLite URI (also in ledger_query). - tests: version-2 home reconciled, consent kept when no WSL host existed, partial schema refused. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WUhGzUwi8pXjngqs22ghZ3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Codex reviewed #26 after it merged; all four points fixed.
index.sqlitewas grandfathered as a legacy archivedetect.wsl=falseleft WSL hosts in a scheduled manifest.withdrawn) so scheduled runs refuse until re-consented, and persists on loadTest plan
check_followups_1_5_9extended: foreign index refused, real legacy archive accepted, escaping row kept with the outside file untouched, manifest pruned and consent withdrawn on migration, invalid archive path stopsinitbeforeaccounts.jsonchangespython scripts/validate_quality.py --skip-mermaidpasses🤖 Generated with Claude Code
https://claude.ai/code/session_01WUhGzUwi8pXjngqs22ghZ3