feat(people): add PostgreSQL Position history read adapter - #153
Draft
seonghobae wants to merge 10 commits into
Draft
seonghobae wants to merge 10 commits into
seonghobae wants to merge 10 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 30, 2026
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buyer outcome
PR #152 owns purpose-bound Position-history authorization/disclosure. This stacked child supplies the canonical PostgreSQL adapter for normalized
position_recordandposition_record_versiontruth without widening into Person, Employment, Assignment, compensation, candidate, performance, credential, or employment-decision data.Current authority
Direct parent: #152
a54eedd10b6bf3eb55194d8a78ff882210519666Current exact head:
fc40199352a578340e0fde92ca398c034723a68aLifecycle: Draft; ADR 0153 remains Proposed. The pre-#161 feature-local workflow remains removed; consolidated Foundation is the acceptance owner.
The existing PostgreSQL repair remains intact: tuple-backed immutable connection capability, request UUID scalar snapshots before connection acquisition, exact
connection.autocommit is Falsebefore cursor creation, detached UUID views for tenant/query parameters, and returned-row comparisons against the original request authority. The transaction remains narrow: connection acquisition → non-autocommit proof → read-only transaction + transaction-local tenant context → bounded SELECT/fetch → connection-context exit. Purpose authorization stays in #152 outside this transaction.#152's exact predecessor Foundation run exposed the real #338 coverage RED: all People API tests passed but Position-history owned coverage was 99.81%. Parent repair
a54eedd...adds only focused fail-closed guard coverage and does not change production behavior. This child ordinary-forward adopted that parent-owned test at mergefc40199352a578340e0fde92ca398c034723a68a; its seven-file PostgreSQL feature delta remains unchanged.Because this PR is stacked on #152, parent acceptance evidence does not transfer and absence of a protected-base Foundation run is not GREEN. After #152 reaches protected
develop, #153 must ordinary-forward onto protected truth, retarget todevelop, and reacquire exact-head Foundation/Security/SAST/CodeQL, real-PostgreSQL acceptance, and qualifying independent review.#154 is current at
c09d2e589be3df218988e49d1803de03adcba037on this head. Keep Draft. No force-push, destructive rebase, self/model approval, routine bypass, mutable-owner source copy, no-op retrigger, predecessor-evidence transfer, feature-local workflow resurrection, gate weakening, or simple Close.