Skip to content

feat(people): add PostgreSQL Position history read adapter - #153

Draft
seonghobae wants to merge 10 commits into
feat/position-history-readfrom
feat/people-position-history-postgres-adapter
Draft

seonghobae wants to merge 10 commits into
feat/position-history-readfrom
feat/people-position-history-postgres-adapter

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Buyer outcome

PR #152 owns purpose-bound Position-history authorization/disclosure. This stacked child supplies the canonical PostgreSQL adapter for normalized position_record and position_record_version truth without widening into Person, Employment, Assignment, compensation, candidate, performance, credential, or employment-decision data.

Current authority

Direct parent: #152 a54eedd10b6bf3eb55194d8a78ff882210519666
Current exact head: fc40199352a578340e0fde92ca398c034723a68a
Lifecycle: Draft; ADR 0153 remains Proposed. The pre-#161 feature-local workflow remains removed; consolidated Foundation is the acceptance owner.

The existing PostgreSQL repair remains intact: tuple-backed immutable connection capability, request UUID scalar snapshots before connection acquisition, exact connection.autocommit is False before cursor creation, detached UUID views for tenant/query parameters, and returned-row comparisons against the original request authority. The transaction remains narrow: connection acquisition → non-autocommit proof → read-only transaction + transaction-local tenant context → bounded SELECT/fetch → connection-context exit. Purpose authorization stays in #152 outside this transaction.

#152's exact predecessor Foundation run exposed the real #338 coverage RED: all People API tests passed but Position-history owned coverage was 99.81%. Parent repair a54eedd... adds only focused fail-closed guard coverage and does not change production behavior. This child ordinary-forward adopted that parent-owned test at merge fc40199352a578340e0fde92ca398c034723a68a; its seven-file PostgreSQL feature delta remains unchanged.

Because this PR is stacked on #152, parent acceptance evidence does not transfer and absence of a protected-base Foundation run is not GREEN. After #152 reaches protected develop, #153 must ordinary-forward onto protected truth, retarget to develop, and reacquire exact-head Foundation/Security/SAST/CodeQL, real-PostgreSQL acceptance, and qualifying independent review.

#154 is current at c09d2e589be3df218988e49d1803de03adcba037 on this head. Keep Draft. No force-push, destructive rebase, self/model approval, routine bypass, mutable-owner source copy, no-op retrigger, predecessor-evidence transfer, feature-local workflow resurrection, gate weakening, or simple Close.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority: high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant