test(perf): add Employment separation buyer-path workload - #317
seonghobae wants to merge 300 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review Please review the exact current head for performance-evidence false-GREEN risk: right-cleared/non-synthetic fixture enforcement, cross-profile Employment isolation, contention semantics, bearer handling, p95 threshold scoping, result provenance, and any k6 runtime incompatibility. This PR must not claim measured acceptance. |
🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo '=== HEAD / PR FILES ==='
git rev-parse HEAD
git diff --name-status HEAD^ HEAD
git diff --check HEAD^ HEAD
echo '=== REPOSITORY MAP ==='
fd -HI -t f | rg -i '(k6|perf|performance|employment|fixture|workload|package\.json|readme|requirements)'
echo '=== JAVASCRIPT/TYPECRIPT OUTLINES ==='
while IFS= read -r file; do
echo "--- $file"
ast-grep outline "$file" --items all 2>/dev/null || true
done < <(fd -HI -t f -e js -e mjs -e cjs -e ts | rg -i '(k6|perf|performance|employment|fixture|workload)')
echo '=== DIFF ==='
git diff --find-renames --find-copies --unified=80 HEAD^ HEADLength of output: 3432 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo '=== OUTLINE: WORKLOAD ==='
ast-grep outline tests/performance/employment_separation_buyer_path.js --items all || true
echo '=== OUTLINE: FIXTURE CONTRACT ==='
ast-grep outline tests/performance/employment_separation_fixture_contract.mjs --items all || true
echo '=== OUTLINE: FIXTURE CONTRACT TEST ==='
ast-grep outline tests/performance/employment_separation_fixture_contract.test.mjs --items all || true
echo '=== WORKLOAD ==='
cat -n tests/performance/employment_separation_buyer_path.js
echo '=== FIXTURE CONTRACT ==='
cat -n tests/performance/employment_separation_fixture_contract.mjs
echo '=== FIXTURE CONTRACT TEST ==='
cat -n tests/performance/employment_separation_fixture_contract.test.mjs
echo '=== RELATED PERFORMANCE POLICY ==='
cat -n docs/adr/0009-performance-criterion-observation-scope.md
echo '=== ALL SHARED-CONTRACT IMPORTS AND CALL SITES ==='
rg -n -C 4 --glob '*.mjs' --glob '*.js' \
'(from .*\bemployment_separation_fixture_contract\b|require\(.+employment_separation_fixture_contract|validateFixture|fixtureIdentity|candidateSha|resourceEvidence)' \
tests services packagesLength of output: 37674 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo '=== PACKAGE METADATA ==='
cat -n package.json
echo '=== PERFORMANCE DOCUMENTATION AND EXECUTION REFERENCES ==='
rg -n -C 5 -i \
'(employment[-_ ]separation.*(performance|buyer|k6)|ORGMETRA_PERFORMANCE_|k6 run|performance-result|candidate_sha|right_cleared)' \
README.md docs tests package.json .github 2>/dev/null || true
echo '=== SERVICE ROUTE CONTRACT ==='
rg -n -C 8 --glob '*.py' --glob '*.md' --glob '*.json' \
'(/v1/employment-separations|employment-separations|separation_conflict|X-Actor-Reference|X-Purpose-Code|X-Tenant-Reference)' \
services/people-api packages tests | head -n 500
echo '=== K6 VERSION PINNING OR CONTAINER CONFIGURATION ==='
fd -HI -t f | rg -i '(dockerfile|compose|k6|tool-versions|mise|asdf|package-lock|pnpm-lock|yarn\.lock|github/workflows)'
rg -n -C 3 -i '(grafana/k6|k6(\s|:|@)|xk6)' .github README.md package.json Dockerfile docker-compose.yml 2>/dev/null || true
echo '=== CURRENT HEAD ID REFERENCES ==='
rg -n -C 3 '(2046bc4bea97cf8e0a11694fe3b707c23d5273df|ORGMETRA_PERFORMANCE_TARGET_SHA|candidate_sha)' .Length of output: 54948
The fixture contract otherwise enforces the requested controls: right-cleared and non-synthetic flags, full-SHA format and fixture/runtime SHA equality, non-empty evidence references, cross-profile Employment isolation, contention command equivalence except for idempotency key, runtime bearer credentials, and a first-commit-only p95 trend. The workload does not contain a measured acceptance claim.
|
|
Finding verification on current stack: the initial performance fixture validator accepted short idempotency keys, while the live People contract requires 16–200 visible ASCII characters. A real run with those fixtures would have returned request-validation 400s and produced a false performance RED. Repaired ordinary-forward in |
|
@coderabbitai review Please review exact head |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
target='6dc5e2806b566ca8952eaf2d5bd65de6fa41d836'
base='d9cc516d54b4642f59fe126c331a19945fdf75f1'
echo '=== VERIFY EXACT HEAD ==='
git rev-parse HEAD
git cat-file -t "$target"
git merge-base --is-ancestor "$base" "$target" && echo "base_is_ancestor=yes"
git diff --check "$base" "$target"
echo '=== CHANGED FILES ==='
git diff --name-status "$base" "$target"
echo '=== JAVASCRIPT OUTLINES ==='
git diff --name-only "$base" "$target" | while IFS= read -r f; do
case "$f" in
*.js|*.mjs|*.cjs)
echo "--- $f"
ast-grep outline "$f" --items all || true
;;
esac
done
echo '=== PERFORMANCE HARNESS FILES AT TARGET ==='
fd -HI -t f . tests 2>/dev/null | rg 'tests/performance/(employment_separation|.*performance)' || true
echo '=== TARGET DIFF ==='
git diff --find-renames --unified=100 "$base" "$target" -- tests/performance docs package.json
echo '=== RELATED PRODUCTION BOUNDARY LOCATIONS ==='
rg -n -C 5 --glob '*.py' \
'(Idempotency-Key|X-Actor-Reference|X-Purpose-Code|X-Tenant-Reference|Bearer |employment-separations|separation_reason|evidence_version|confirmation_reference)' \
services packages tests | head -n 1000
echo '=== EXECUTION / VERSION REFERENCES ==='
rg -n -C 4 --glob '*.md' --glob '*.json' --glob '*.yml' --glob '*.yaml' --glob '*.js' --glob '*.mjs' \
'(k6 run|grafana/k6|shared-iterations|maxDuration|handleSummary|thresholds|ORGMETRA_PERFORMANCE|candidate_sha|resource_evidence)' \
README.md docs tests package.json .github 2>/dev/null || trueLength of output: 146825 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo '=== PEOPLE SEPARATION SOURCE MAP ==='
rg -n -l --glob '*.py' '(employment.separation|employment-separation|separation_conflict|separation_effective_on)' services/people-api | while IFS= read -r f; do
echo "--- $f"
ast-grep outline "$f" --items all 2>/dev/null || true
done
echo '=== PEOPLE SEPARATION HTTP AND COMMAND IMPLEMENTATIONS ==='
rg -n -C 12 --glob '*.py' \
'(def .*separation|class .*Separation|/v1/employment-separations|separation_conflict|Idempotency-Key|idempotency.*(16|200)|evidence_version_code|confirmation_reference)' \
services/people-api/src services/people-api/tests | head -n 1600
echo '=== PERFORMANCE CONTRACT TEST COMPLETE ==='
cat -n tests/performance/employment_separation_fixture_contract.test.mjs
echo '=== K6-SPECIFIC API PATTERNS IN REPOSITORY ==='
rg -n -C 5 --glob '*.js' --glob '*.mjs' \
'(handleSummary|execution|iterationInTest|http\.batch|shared-iterations)' . 2>/dev/null
echo '=== COMMIT HISTORY FOR HARNESS ==='
git log --format='%H%n%s%n%b%n---' --reverse d9cc516d54b4642f59fe126c331a19945fdf75f1..6dc5e2806b566ca8952eaf2d5bd65de6fa41d836 -- tests/performanceLength of output: 210212
The remaining reviewed controls are consistent with the stated harness scope. The fixture validator enforces right-cleared non-synthetic input, candidate-SHA equality, resource-evidence presence, cross-profile Employment isolation, and contention pair equivalence except for idempotency key. The workload supplies the bearer token only from the runtime environment. The result envelope does not explicitly contain the target endpoint. The You are interacting with an AI system. |
|
@coderabbitai review Please review exact head |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
target='beff0210c24f5d179f8a6717fbfeb5881f7c5365'
base='d9cc516d54b4642f59fe126c331a19945fdf75f1'
echo '=== EXACT-HEAD VERIFICATION ==='
printf 'checked_out='
git rev-parse HEAD
git cat-file -t "$target"
git merge-base --is-ancestor "$base" "$target" && echo 'base_is_ancestor=yes'
git diff --check "$base" "$target"
echo '=== CHANGED FILES ==='
git diff --name-status "$base" "$target"
echo '=== PERFORMANCE FILES AT TARGET ==='
git ls-tree -r --name-only "$target" | rg '^tests/performance/|(^|/)(package\.json|README\.md)$|^docs/' | rg -i '(employment|separation|performance|buyer|fixture|workload|package\.json|readme)' || true
echo '=== JAVASCRIPT OUTLINES ==='
git diff --name-only "$base" "$target" | while IFS= read -r file; do
case "$file" in
*.js|*.mjs|*.cjs)
echo "--- $file"
ast-grep outline "$file" --items all 2>/dev/null || true
;;
esac
done
echo '=== HARNESS DIFF ==='
git diff --find-renames --unified=100 "$base" "$target" -- tests/performance docs package.json README.md
echo '=== CURRENT HARNESS SOURCES ==='
for file in \
tests/performance/employment_separation_buyer_path.js \
tests/performance/employment_separation_fixture_contract.mjs \
tests/performance/employment_separation_fixture_contract.test.mjs
do
if git cat-file -e "$target:$file" 2>/dev/null; then
echo "--- $file"
git show "$target:$file" | cat -n
fi
done
echo '=== PEOPLE REQUEST-BOUNDARY IMPLEMENTATION ==='
rg -n -C 10 --glob '*.py' \
'(Idempotency-Key|X-Actor-Reference|X-Purpose-Code|X-Tenant-Reference|Authorization|Bearer |/v1/employment-separations|separation_reason|evidence_version|confirmation_reference)' \
services/people-api packages 2>/dev/null | head -n 1800 || true
echo '=== K6 RUNTIME/PATTERN REFERENCES ==='
rg -n -C 6 --glob '*.js' --glob '*.mjs' --glob '*.md' --glob '*.json' --glob '*.yml' --glob '*.yaml' \
'(shared-iterations|maxDuration|handleSummary|execution|iterationInTest|Trend|Counter|thresholds|k6 run|grafana/k6|ORGMETRA_PERFORMANCE|candidate_sha|prepared_state|preparation_protocol|resource_evidence)' \
tests docs README.md package.json .github 2>/dev/null || true
echo '=== RESULT-EVIDENCE FIELD AND SECRET/ENDPOINT AUDIT ==='
rg -n -C 5 --glob '*.js' --glob '*.mjs' \
'(handleSummary|JSON\.stringify|result|envelope|endpoint|target|base_url|authorization|bearer|token|ORGMETRA_PERFORMANCE)' \
tests/performance 2>/dev/null || true
echo '=== FIXTURE/PROFILE CROSS-REFERENCE ==='
rg -n -C 5 --glob '*.js' --glob '*.mjs' \
'(first_commit|replay|rejection|contention|employment_id|employment_reference|profile_precondition|prepared_state|preparation_protocol)' \
tests/performance 2>/dev/null || trueLength of output: 203259 🏁 Script executed: #!/bin/bash
set -euo pipefail
target='beff0210c24f5d179f8a6717fbfeb5881f7c5365'
log='/tmp/coderabbit-shell-logs/shell-output-5yYGg9'
echo '=== EXACT HEAD AND DIFF STAT ==='
git rev-parse HEAD
git show -s --format='%H%n%P%n%s' "$target"
git diff --stat d9cc516d54b4642f59fe126c331a19945fdf75f1 "$target"
git diff --name-status 6dc5e2806b566ca8952eaf2d5bd65de6fa41d836 "$target"
echo '=== COMPLETE TARGET: WORKLOAD ==='
git show "$target:tests/performance/employment_separation_buyer_path.js" | nl -ba
echo '=== COMPLETE TARGET: FIXTURE CONTRACT ==='
git show "$target:tests/performance/employment_separation_fixture_contract.mjs" | nl -ba
echo '=== COMPLETE TARGET: CONTRACT TESTS ==='
git show "$target:tests/performance/employment_separation_fixture_contract.test.mjs" | nl -ba
echo '=== PREVIOUS COMMAND: KEY SECTIONS ==='
rg -n -C 3 '^=== EXACT-HEAD|^checked_out=|^base_is_ancestor|^=== CHANGED FILES|^=== HARNESS DIFF|^=== CURRENT HARNESS SOURCES' "$log" || true
echo '=== TARGET: ALL PERFORMANCE OUTPUT SINKS AND ENVIRONMENT USE ==='
git grep -n -E '(handleSummary|console\.|JSON\.stringify|__ENV|http\.(post|batch)|open\()' "$target" -- tests/performance || true
echo '=== TARGET: DOCUMENTED K6 INVOCATION ==='
git grep -n -i -E '(k6 run|ORGMETRA_PERFORMANCE_|employment-separation-performance-result)' "$target" -- README.md docs tests package.json .github 2>/dev/null || trueLength of output: 36295
The prepared-state provenance is structurally explicit. The fixture requires The result envelope does not explicitly emit k6 runtime execution was not available in this environment. The source uses standard k6 module imports, You are interacting with an AI system. |
|
@coderabbitai review Please review exact head |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
target='2ef2f39449bcaa0ce8a077f43649af4a70a8e0e3'
base='d9cc516d54b4642f59fe126c331a19945fdf75f1'
echo '=== EXACT HEAD ==='
printf 'checked_out='
git rev-parse HEAD
printf 'target_type='
git cat-file -t "$target"
git merge-base --is-ancestor "$base" "$target" && echo 'base_is_ancestor=yes'
git diff --check "$base" "$target"
git show -s --format='target=%H%nparents=%P%nsubject=%s' "$target"
echo '=== CHANGED FILES ==='
git diff --name-status "$base" "$target"
echo '=== PERFORMANCE SOURCE OUTLINES ==='
for file in \
tests/performance/employment_separation_buyer_path.js \
tests/performance/employment_separation_fixture_contract.mjs \
tests/performance/employment_separation_fixture_contract.test.mjs
do
if git cat-file -e "$target:$file" 2>/dev/null; then
echo "--- $file"
git show "$target:$file" > "/tmp/$(basename "$file")"
ast-grep outline "/tmp/$(basename "$file")" --items all 2>/dev/null || true
fi
done
echo '=== WORKLOAD ==='
git show "$target:tests/performance/employment_separation_buyer_path.js" | nl -ba
echo '=== FIXTURE CONTRACT ==='
git show "$target:tests/performance/employment_separation_fixture_contract.mjs" | nl -ba
echo '=== CONTRACT TESTS ==='
git show "$target:tests/performance/employment_separation_fixture_contract.test.mjs" | nl -ba
echo '=== HARNESS DIFF ==='
git diff --find-renames --unified=100 "$base" "$target" -- \
tests/performance docs README.md package.json
echo '=== RESPONSE BOUNDARY ==='
rg -n -C 12 --glob '*.py' \
'(/v1/employment-separations|separation_conflict|replayed|recorded_at|employment_id|Idempotency-Key|X-Actor-Reference|X-Purpose-Code|X-Tenant-Reference)' \
services packages tests | head -n 1800 || true
echo '=== K6, THRESHOLD, AND RESULT-EVIDENCE AUDIT ==='
git grep -n -E \
'(shared-iterations|maxDuration|thresholds|Trend|Counter|handleSummary|JSON\.stringify|__ENV|http\.(post|batch)|iterationInTest|baseUrl|bearer|token|endpoint|candidate_sha|prepared_state|preparation_protocol|resource_evidence)' \
"$target" -- tests/performance docs README.md package.json 2>/dev/null || true
echo '=== TARGET PERFORMANCE INVOCATION REFERENCES ==='
git grep -n -i -E \
'(k6 run|ORGMETRA_PERFORMANCE_PROFILE|first_commit|replay|rejection|contention|employment-separation-performance-result)' \
"$target" -- README.md docs tests package.json .github 2>/dev/null || trueLength of output: 202926 🏁 Script executed: #!/bin/bash
set -euo pipefail
target='2ef2f39449bcaa0ce8a077f43649af4a70a8e0e3'
echo '=== EXACT HEAD SUMMARY ==='
git show -s --format='target=%H%nparents=%P%nsubject=%s' "$target"
git diff --name-status 'd9cc516d54b4642f59fe126c331a19945fdf75f1' "$target"
echo '=== WORKLOAD 1-240 ==='
git show "$target:tests/performance/employment_separation_buyer_path.js" | nl -ba | sed -n '1,240p'
echo '=== RUN CONTRACT ==='
git show "$target:tests/performance/employment_separation_run_contract.mjs" | nl -ba
echo '=== RESPONSE CONTRACT ==='
git show "$target:tests/performance/employment_separation_response_contract.mjs" | nl -ba
echo '=== FIXTURE CONTRACT 1-280 ==='
git show "$target:tests/performance/employment_separation_fixture_contract.mjs" | nl -ba | sed -n '1,280p'
echo '=== RESPONSE AND RUN CONTRACT TESTS ==='
for file in \
tests/performance/employment_separation_response_contract.test.mjs \
tests/performance/employment_separation_run_contract.test.mjs
do
echo "--- $file"
git show "$target:$file" | nl -ba
done
echo '=== PUBLISHED SEPARATION ERROR ENVELOPE ==='
sed -n '300,385p' services/people-api/src/orgmetra_people_api/separation_http.py | nl -ba -v300
echo '=== K6 PACKAGE / VERSION DECLARATIONS ==='
fd -HI -t f -a 'package.json' -a 'Dockerfile*' -a 'docker-compose*.yml' -a 'docker-compose*.yaml' -a '*.tool-versions' -a 'mise.toml' -a '.github/workflows' | while IFS= read -r file; do
echo "--- $file"
rg -n -i -C 3 '(k6|grafana/k6|xk6)' "$file" || true
doneLength of output: 33949
The reviewed response contract matches the published boundary. First-commit and replay require The selected-profile design prevents replay, rejection, and contention traffic from entering the first-commit duration trend. The p95 threshold exists only for The fixture contract requires right-cleared, non-synthetic data, exact candidate-SHA binding, explicit preparation and prepared-state references, resource evidence, minimum profile cardinality, and Employment isolation across profiles. The result envelope does not emit the endpoint or bearer token. This is a Draft stacked on You are interacting with an AI system. |
|
@coderabbitai review Please re-review exact head |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
target='2dff0b072417332683a1d814b5fac1c80b07c9cc'
base='d9cc516d54b4642f59fe126c331a19945fdf75f1'
echo '=== EXACT HEAD ==='
git rev-parse HEAD
git cat-file -t "$target"
git merge-base --is-ancestor "$base" "$target" && echo 'base_is_ancestor=yes'
git show -s --format='target=%H%nparents=%P%nsubject=%s' "$target"
git diff --check "$base" "$target"
echo '=== CHANGED FILES ==='
git diff --name-status "$base" "$target"
echo '=== PERFORMANCE SOURCE OUTLINES ==='
for file in \
tests/performance/employment_separation_buyer_path.js \
tests/performance/employment_separation_fixture_contract.mjs \
tests/performance/employment_separation_run_contract.mjs \
tests/performance/employment_separation_response_contract.mjs \
tests/performance/employment_separation_fixture_contract.test.mjs \
tests/performance/employment_separation_run_contract.test.mjs \
tests/performance/employment_separation_response_contract.test.mjs
do
if git cat-file -e "$target:$file" 2>/dev/null; then
echo "--- $file"
git show "$target:$file" > "/tmp/$(basename "$file")"
ast-grep outline "/tmp/$(basename "$file")" --items all 2>/dev/null || true
fi
done
echo '=== WORKLOAD ==='
git show "$target:tests/performance/employment_separation_buyer_path.js" | nl -ba
echo '=== RUN CONTRACT ==='
git show "$target:tests/performance/employment_separation_run_contract.mjs" | nl -ba
echo '=== RESPONSE CONTRACT ==='
git show "$target:tests/performance/employment_separation_response_contract.mjs" | nl -ba
echo '=== FIXTURE CONTRACT ==='
git show "$target:tests/performance/employment_separation_fixture_contract.mjs" | nl -ba
echo '=== CONTRACT TESTS ==='
for file in \
tests/performance/employment_separation_fixture_contract.test.mjs \
tests/performance/employment_separation_run_contract.test.mjs \
tests/performance/employment_separation_response_contract.test.mjs
do
echo "--- $file"
git show "$target:$file" | nl -ba
done
echo '=== DIFF FROM PREVIOUS REVIEW HEAD ==='
git diff --find-renames --unified=80 '2ef2f39449bcaa0ce8a077f43649af4a70a8e0e3' "$target" -- tests/performance docs README.md package.json
echo '=== PRODUCTION HTTP BOUNDARY ==='
rg -n -C 10 --glob '*.py' \
'(/v1/employment-separations|separation_conflict|replayed|recorded_at|employment_id|Idempotency-Key|X-Actor-Reference|X-Purpose-Code|X-Tenant-Reference)' \
services packages | head -n 1800
echo '=== OUTPUT / K6 / LEAK AUDIT ==='
git grep -n -E \
'(shared-iterations|maxDuration|summaryTrendStats|thresholds|Trend|Counter|handleSummary|JSON\.stringify|__ENV|http\.(post|batch)|iterationInTest|baseUrl|bearer|token|endpoint|candidate_sha|prepared_state|preparation_protocol|resource_evidence)' \
"$target" -- tests/performance docs README.md package.json .github 2>/dev/null || true
echo '=== K6 PINNING OR DOCUMENTATION ==='
git grep -n -i -E '(k6 run|grafana/k6|xk6|k6 version|ORGMETRA_PERFORMANCE_PROFILE)' \
"$target" -- README.md docs tests package.json .github 2>/dev/null || trueLength of output: 203490 🏁 Script executed: #!/bin/bash
set -euo pipefail
target='2dff0b072417332683a1d814b5fac1c80b07c9cc'
for file in \
tests/performance/employment_separation_buyer_path.js \
tests/performance/employment_separation_run_contract.mjs \
tests/performance/employment_separation_response_contract.mjs \
tests/performance/employment_separation_fixture_contract.mjs \
tests/performance/employment_separation_run_contract.test.mjs \
tests/performance/employment_separation_response_contract.test.mjs
do
echo "=== $file ==="
git show "$target:$file" | nl -ba
done
echo '=== EXACT DIFF SINCE 2ef ==='
git diff --unified=40 2ef2f39449bcaa0ce8a077f43649af4a70a8e0e3 "$target" -- tests/performance
echo '=== PRODUCTION SEPARATION HEADER PARSING AND HANDLER ==='
sed -n '140,385p' services/people-api/src/orgmetra_people_api/separation_http.py | nl -ba -v140
echo '=== K6 CONFIG/DEPENDENCY REFERENCES ==='
fd -HI -t f | rg '(^|/)(Dockerfile[^/]*|docker-compose[^/]*|package\.json|.*\.ya?ml|.*\.md)$' | while IFS= read -r file; do
rg -n -i -C2 '(grafana/k6|xk6|\bk6\b)' "$file" && echo "--- $file"
done || trueLength of output: 50096
The new profile isolation is correct. The The response contract matches the published People boundary. Success requires HTTP The contention check requires exactly one governed non-replay success and one governed conflict for each pair. The fixture requires pair commands to differ only by idempotency key. The fixture contract requires right-cleared, non-synthetic data, exact candidate-SHA binding, prepared-state references, resource evidence, required profile cardinality, and Employment isolation across profiles. The result envelope does not add the base URL or bearer token. This source review does not claim measured acceptance or released status. You are interacting with an AI system. |
|
@coderabbitai review P1 completion finding repaired at exact head |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
target='abc0fadc8641b5be34010885c87b9bd6d152e63c'
base='d9cc516d54b4642f59fe126c331a19945fdf75f1'
previous='2dff0b072417332683a1d814b5fac1c80b07c9cc'
echo '=== EXACT HEAD ==='
printf 'checked_out='
git rev-parse HEAD
printf 'target_type='
git cat-file -t "$target"
git merge-base --is-ancestor "$base" "$target" && echo 'base_is_ancestor=yes'
git show -s --format='target=%H%nparents=%P%nsubject=%s' "$target"
git diff --check "$base" "$target"
echo '=== CHANGES SINCE PREVIOUS REVIEW ==='
git diff --name-status "$previous" "$target"
git diff --find-renames --unified=100 "$previous" "$target" -- tests/performance docs README.md package.json
echo '=== PERFORMANCE SOURCE OUTLINES ==='
for file in \
tests/performance/employment_separation_buyer_path.js \
tests/performance/employment_separation_run_contract.mjs \
tests/performance/employment_separation_response_contract.mjs \
tests/performance/employment_separation_fixture_contract.mjs \
tests/performance/employment_separation_fixture_contract.test.mjs \
tests/performance/employment_separation_run_contract.test.mjs \
tests/performance/employment_separation_response_contract.test.mjs
do
if git cat-file -e "$target:$file" 2>/dev/null; then
echo "--- $file"
git show "$target:$file" > "/tmp/$(basename "$file")"
ast-grep outline "/tmp/$(basename "$file")" --items all 2>/dev/null || true
fi
done
echo '=== WORKLOAD ==='
git show "$target:tests/performance/employment_separation_buyer_path.js" | nl -ba
echo '=== RUN CONTRACT ==='
git show "$target:tests/performance/employment_separation_run_contract.mjs" | nl -ba
echo '=== RESPONSE CONTRACT ==='
git show "$target:tests/performance/employment_separation_response_contract.mjs" | nl -ba
echo '=== FIXTURE CONTRACT ==='
git show "$target:tests/performance/employment_separation_fixture_contract.mjs" | nl -ba
echo '=== CONTRACT TESTS ==='
for file in \
tests/performance/employment_separation_fixture_contract.test.mjs \
tests/performance/employment_separation_run_contract.test.mjs \
tests/performance/employment_separation_response_contract.test.mjs
do
if git cat-file -e "$target:$file" 2>/dev/null; then
echo "--- $file"
git show "$target:$file" | nl -ba
fi
done
echo '=== K6 / EVIDENCE / LEAK AUDIT ==='
git grep -n -E \
'(shared-iterations|maxDuration|iterations|summaryTrendStats|thresholds|Trend|Counter|handleSummary|JSON\.stringify|__ENV|http\.(post|batch)|iterationInTest|baseUrl|bearer|token|endpoint|candidate_sha|prepared_state|preparation_protocol|resource_evidence|sample_complete)' \
"$target" -- tests/performance docs README.md package.json .github 2>/dev/null || true
echo '=== PRODUCTION HTTP BOUNDARY ==='
rg -n -C 10 --glob '*.py' \
'(/v1/employment-separations|separation_conflict|replayed|recorded_at|employment_id|Idempotency-Key|X-Actor-Reference|X-Purpose-Code|X-Tenant-Reference)' \
services packages | head -n 1800Length of output: 203415 🏁 Script executed: #!/bin/bash
set -euo pipefail
target='abc0fadc8641b5be34010885c87b9bd6d152e63c'
echo '=== HEAD AND DELTA ==='
git show -s --format='target=%H%nparents=%P%nsubject=%s' "$target"
git diff --unified=60 2dff0b072417332683a1d814b5fac1c80b07c9cc "$target" -- \
tests/performance/employment_separation_buyer_path.js \
tests/performance/employment_separation_run_contract.mjs \
tests/performance/employment_separation_run_contract.test.mjs
echo '=== WORKLOAD ==='
git show "$target:tests/performance/employment_separation_buyer_path.js" | nl -ba
echo '=== RUN CONTRACT ==='
git show "$target:tests/performance/employment_separation_run_contract.mjs" | nl -ba
echo '=== RUN-CONTRACT TESTS ==='
git show "$target:tests/performance/employment_separation_run_contract.test.mjs" | nl -ba
echo '=== FIXTURE CONTRACT: VALIDATION AND RESULT ENVELOPE HELPERS ==='
git show "$target:tests/performance/employment_separation_fixture_contract.mjs" | nl -ba | sed -n '1,360p'
echo '=== RESPONSE CONTRACT ==='
git show "$target:tests/performance/employment_separation_response_contract.mjs" | nl -ba
echo '=== OUTPUT SINKS AND SENSITIVE ENVIRONMENT VALUES ==='
git grep -n -E '(handleSummary|JSON\.stringify|console\.|ORGMETRA_PERFORMANCE_|baseUrl|base_url|bearer|token|endpoint|url)' \
"$target" -- tests/performance
echo '=== PROFILE COUNTS, OPTIONS, AND THRESHOLDS ==='
git grep -n -E '(iterations|vus|maxDuration|executor|scenarios|thresholds|sample_complete|expected_iterations|completed_iterations|summaryTrendStats)' \
"$target" -- tests/performanceLength of output: 50500
I found no remaining false-GREEN path in the reviewed harness. The repair closes the previous P1 path. Each invocation configures only one profile. The built-in The result envelope also reports The first-commit p95 threshold remains limited to The response classification and fixture controls remain consistent with the prior review. The result envelope does not explicitly emit the endpoint or bearer token. This source review does not claim measured acceptance, protected status, released status, or runtime k6 compatibility. k6 execution with the required deployment, credentials, fixture state, and resource evidence was not available. If you found this review helpful, would you consider giving us a shout-out on X? Thank you for using CodeRabbit! You are interacting with an AI system. |
|
@coderabbitai review Please review exact head |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
target='87b4039c50448689edc70cc37a331022432febff'
previous='abc0fadc8641b5be34010885c87b9bd6d152e63c'
base='d9cc516d54b4642f59fe126c331a19945fdf75f1'
echo '=== EXACT HEAD ==='
printf 'checked_out='; git rev-parse HEAD
printf 'target_type='; git cat-file -t "$target"
git merge-base --is-ancestor "$base" "$target" && echo 'base_is_ancestor=yes'
git show -s --format='target=%H%nparents=%P%nsubject=%s' "$target"
git diff --check "$base" "$target"
echo '=== DELTA SINCE PRIOR REVIEW ==='
git diff --name-status "$previous" "$target"
git diff --find-renames --unified=100 "$previous" "$target" -- tests/performance docs README.md package.json
echo '=== PERFORMANCE FILE MAP AT TARGET ==='
git ls-tree -r --name-only "$target" | rg '^tests/performance/' | sort
echo '=== SOURCE OUTLINES ==='
git ls-tree -r --name-only "$target" | rg '^tests/performance/.*\.(js|mjs|cjs)$' | while IFS= read -r file; do
echo "--- $file"
git show "$target:$file" > "/tmp/$(basename "$file")"
ast-grep outline "/tmp/$(basename "$file")" --items all 2>/dev/null || true
done
echo '=== POST-RUN / ACCEPTANCE / ARTIFACT / RESIDUAL REFERENCES ==='
git grep -n -E -i \
'(post.run|acceptance|artifact|sha.?256|deployed|revision|residual|resource|pool|transaction|socket|background|sample_complete|expected_iterations|completed_iterations|p\(95\)|first_commit)' \
"$target" -- tests/performance docs README.md package.json 2>/dev/null || true
echo '=== OUTPUT AND ENVIRONMENT AUDIT ==='
git grep -n -E \
'(handleSummary|JSON\.stringify|console\.|__ENV|open\(|baseUrl|base_url|bearer|token|endpoint|url|sha256)' \
"$target" -- tests/performance 2>/dev/null || trueLength of output: 159030
The reviewed contract correctly rejects a mismatched observed service SHA, a mismatched result SHA-256, an incomplete sample, a first-commit p95 above 20 ms, missing resource and pool measurements, and each nonzero residual-state field. This is an acceptance-mechanics source review only. It does not claim latency acceptance, runtime execution, protected status, or release status. You are interacting with an AI system. |
|
@coderabbitai review Please review exact head |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
target='301053f0f504484dfa65ee36058933997df26143'
previous='87b4039c50448689edc70cc37a331022432febff'
base='d9cc516d54b4642f59fe126c331a19945fdf75f1'
echo '=== EXACT HEAD ==='
printf 'checked_out='; git rev-parse HEAD
printf 'target_type='; git cat-file -t "$target"
git merge-base --is-ancestor "$base" "$target" && echo 'base_is_ancestor=yes'
git show -s --format='target=%H%nparents=%P%nsubject=%s' "$target"
git diff --check "$base" "$target"
echo '=== DELTA SINCE PRIOR REVIEW ==='
git diff --name-status "$previous" "$target"
git diff --find-renames --unified=100 "$previous" "$target" -- tests/performance docs README.md package.json
echo '=== PERFORMANCE SOURCE MAP ==='
git ls-tree -r --name-only "$target" | rg '^tests/performance/' | sort
echo '=== SOURCE OUTLINES ==='
for file in \
tests/performance/employment_separation_buyer_path.js \
tests/performance/employment_separation_fixture_contract.mjs \
tests/performance/employment_separation_run_contract.mjs \
tests/performance/employment_separation_response_contract.mjs \
tests/performance/employment_separation_acceptance_contract.mjs \
tests/performance/employment_separation_acceptance_contract_cli.mjs \
tests/performance/employment_separation_acceptance_contract.test.mjs \
tests/performance/employment_separation_acceptance_contract_cardinality.test.mjs \
tests/performance/employment_separation_acceptance_contract_edges.test.mjs
do
if git cat-file -e "$target:$file" 2>/dev/null; then
echo "--- $file"
git show "$target:$file" > "/tmp/$(basename "$file")"
ast-grep outline "/tmp/$(basename "$file")" --items all 2>/dev/null || true
fi
done
echo '=== ACCEPTANCE CONTRACT AND TESTS ==='
for file in \
tests/performance/employment_separation_acceptance_contract.mjs \
tests/performance/employment_separation_acceptance_contract_cli.mjs \
tests/performance/employment_separation_acceptance_contract.test.mjs \
tests/performance/employment_separation_acceptance_contract_cardinality.test.mjs \
tests/performance/employment_separation_acceptance_contract_edges.test.mjs
do
if git cat-file -e "$target:$file" 2>/dev/null; then
echo "--- $file"
git show "$target:$file" | nl -ba
fi
done
echo '=== WORKLOAD AND UPSTREAM CONTRACTS ==='
for file in \
tests/performance/employment_separation_buyer_path.js \
tests/performance/employment_separation_fixture_contract.mjs \
tests/performance/employment_separation_run_contract.mjs \
tests/performance/employment_separation_response_contract.mjs
do
echo "--- $file"
git show "$target:$file" | nl -ba
done
echo '=== ALL ACCEPTANCE CALL SITES AND OUTPUT SINKS ==='
git grep -n -E \
'(validateEmploymentSeparationAcceptance|acceptance_contract|acceptance|sha256|observed_deployed|deployed.*sha|residual|pool|host_cpu|host_rss|handleSummary|JSON\.stringify|console\.|__ENV|baseUrl|bearer|token|endpoint)' \
"$target" -- tests/performance docs README.md package.json 2>/dev/null || true
echo '=== PRODUCTION SEPARATION HTTP BOUNDARY ==='
rg -n -C 8 --glob '*.py' \
'(/v1/employment-separations|separation_conflict|replayed|recorded_at|employment_id|Idempotency-Key|X-Actor-Reference|X-Purpose-Code|X-Tenant-Reference)' \
services packages | head -n 1400Length of output: 203737 🏁 Script executed: #!/bin/bash
set -euo pipefail
target='301053f0f504484dfa65ee36058933997df26143'
log='/tmp/coderabbit-shell-logs/shell-output-86BN0G'
echo '=== EXACT CONTRACT FROM PREVIOUS LOG ==='
awk '/^--- tests\/performance\/employment_separation_acceptance_contract\.mjs$/{p=1;next} p && /^--- tests\/performance\//{exit} p{print}' "$log"
echo '=== EXACT CLI FROM PREVIOUS LOG ==='
awk '/^--- tests\/performance\/employment_separation_acceptance_check\.mjs$/{p=1;next} p && /^--- tests\/performance\//{exit} p{print}' "$log"
echo '=== CARDINALITY TEST FROM PREVIOUS LOG ==='
awk '/^--- tests\/performance\/employment_separation_acceptance_cardinality\.test\.mjs$/{p=1;next} p && /^--- tests\/performance\//{exit} p{print}' "$log"
echo '=== EDGE TEST: PROFILE/FLOOR AND PROVENANCE CASES ==='
awk '/^--- tests\/performance\/employment_separation_acceptance_edge\.test\.mjs$/{p=1;next} p && /^--- tests\/performance\//{exit} p{print}' "$log" | sed -n '1,260p'
echo '=== WORKLOAD RESULT SHAPE ==='
git show "$target:tests/performance/employment_separation_buyer_path.js" | nl -ba | sed -n '1,260p'
echo '=== CURRENT ACCEPTANCE FILE NAMES ==='
git ls-tree -r --name-only "$target" -- tests/performance | rg 'acceptance'
echo '=== VALIDATOR IMPORTS AND RUNTIME-EVIDENCE FIELD REFERENCES ==='
git grep -n -E \
'(observed_service_sha|environment|deployment|observer|completed_at|candidate_sha|selected_profile|minimum_non_contending_records|minimum_contention_pairs|db_connections_max|residual_)' \
"$target" -- tests/performanceLength of output: 35917 🏁 Script executed: #!/bin/bash
set -euo pipefail
target='301053f0f504484dfa65ee36058933997df26143'
echo '=== ACCEPTANCE CONTRACT ==='
git show "$target:tests/performance/employment_separation_acceptance_contract.mjs" | nl -ba
echo '=== ACCEPTANCE CLI ==='
git show "$target:tests/performance/employment_separation_acceptance_check.mjs" | nl -ba
echo '=== CARDINALITY REGRESSIONS ==='
git show "$target:tests/performance/employment_separation_acceptance_cardinality.test.mjs" | nl -ba
echo '=== ACCEPTANCE CORE TESTS ==='
git show "$target:tests/performance/employment_separation_acceptance_contract.test.mjs" | nl -ba
echo '=== ACCEPTANCE EDGE TESTS ==='
git show "$target:tests/performance/employment_separation_acceptance_edge.test.mjs" | nl -ba
echo '=== RESULT AND RUNTIME SCHEMA/PROVENANCE DOCUMENTATION ==='
git grep -n -C 5 -E \
'(runtime_evidence|observed_service_sha|observer_reference|performance_result_sha256|residual_http_tasks|acceptance_check)' \
"$target" -- README.md docs tests/performance package.json 2>/dev/null || true
echo '=== RESULT FIELDS NOT CONSUMED BY THE ACCEPTANCE VALIDATOR ==='
python3 - <<'PY'
import subprocess, re
target='301053f0f504484dfa65ee36058933997df26143'
workload=subprocess.check_output(['git','show',f'{target}:tests/performance/employment_separation_buyer_path.js'], text=True)
contract=subprocess.check_output(['git','show',f'{target}:tests/performance/employment_separation_acceptance_contract.mjs'], text=True)
# Report payload literal keys and their textual occurrence in validation source.
keys=re.findall(r'^\s{4}([a-z][a-z0-9_]*):', workload, re.M)
for key in keys:
print(f'{key}: contract_occurrences={len(re.findall(r"\\b"+re.escape(key)+r"\\b", contract))}')
PYLength of output: 70715
The cardinality repair closes the prior P1 path. The acceptance contract now independently requires at least 1,000 iterations for The contract binds the supplied result bytes by SHA-256. It requires This source review does not claim buyer-latency acceptance, runtime execution, protected status, or release status. You are interacting with an AI system. |
|
@coderabbitai review Please re-review exact head |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
target='964de4e20ec67319b46a095fb82f6cf80e86f9f3'
previous='301053f0f504484dfa65ee36058933997df26143'
base='d9cc516d54b4642f59fe126c331a19945fdf75f1'
echo '=== EXACT HEAD ==='
printf 'checked_out='; git rev-parse HEAD
printf 'target_type='; git cat-file -t "$target"
git merge-base --is-ancestor "$base" "$target" && echo 'base_is_ancestor=yes'
git show -s --format='target=%H%nparents=%P%nsubject=%s' "$target"
git diff --check "$base" "$target"
echo '=== DELTA SINCE PRIOR REVIEW ==='
git diff --name-status "$previous" "$target"
git diff --find-renames --unified=100 "$previous" "$target" -- tests/performance docs README.md package.json
echo '=== PERFORMANCE FILE MAP ==='
git ls-tree -r --name-only "$target" -- tests/performance | sort
echo '=== SOURCE OUTLINES ==='
for file in \
tests/performance/employment_separation_acceptance_contract.mjs \
tests/performance/employment_separation_acceptance_check.mjs \
tests/performance/employment_separation_fixture_contract.mjs \
tests/performance/employment_separation_buyer_path.js \
tests/performance/employment_separation_acceptance_contract.test.mjs \
tests/performance/employment_separation_acceptance_cardinality.test.mjs \
tests/performance/employment_separation_acceptance_edge.test.mjs
do
if git cat-file -e "$target:$file" 2>/dev/null; then
echo "--- $file"
git show "$target:$file" > "/tmp/$(basename "$file")"
ast-grep outline "/tmp/$(basename "$file")" --items all 2>/dev/null || true
fi
done
echo '=== ACCEPTANCE CONTRACT, CLI, AND TESTS ==='
for file in \
tests/performance/employment_separation_acceptance_contract.mjs \
tests/performance/employment_separation_acceptance_check.mjs \
tests/performance/employment_separation_acceptance_contract.test.mjs \
tests/performance/employment_separation_acceptance_cardinality.test.mjs \
tests/performance/employment_separation_acceptance_edge.test.mjs
do
if git cat-file -e "$target:$file" 2>/dev/null; then
echo "--- $file"
git show "$target:$file" | nl -ba
fi
done
echo '=== WORKLOAD AND FIXTURE CONTRACT ==='
for file in \
tests/performance/employment_separation_buyer_path.js \
tests/performance/employment_separation_fixture_contract.mjs \
tests/performance/employment_separation_run_contract.mjs \
tests/performance/employment_separation_response_contract.mjs
do
if git cat-file -e "$target:$file" 2>/dev/null; then
echo "--- $file"
git show "$target:$file" | nl -ba
fi
done
echo '=== ACCEPTANCE / PROVENANCE / BINDING REFERENCES ==='
git grep -n -E \
'(validateEmploymentSeparationAcceptance|validateResult|dataset_id|clearance_reference|preparation_protocol_reference|prepared_state_evidence_reference|profile_preconditions|resource_evidence_reference|performance_result_sha256|observed_service_sha|candidate_sha|JSON\.stringify|readFile|sha256|residual_)' \
"$target" -- tests/performance docs README.md package.json 2>/dev/null || true
echo '=== ACCEPTANCE TEST COMMAND REFERENCES ==='
git grep -n -E '(node --test|acceptance_.*test|coverage|acceptance_check)' \
"$target" -- package.json README.md docs tests 2>/dev/null || trueLength of output: 166621
The current repair closes the previous missing-provenance path. The acceptance contract now requires The result-byte SHA-256 binding remains exact for the supplied result text. The observed deployed SHA must match the candidate SHA. The runtime resource reference must match the result resource reference. I did not run the acceptance test scope. This sandbox permits static inspection only and does not permit repository-code execution. This review does not claim measured buyer latency, runtime acceptance, protected status, or release status. You are interacting with an AI system. |
|
@coderabbitai review Please review exact head |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
target='e6e2511d09f56facf494eb8ee2969b3de61eac40'
previous='964de4e20ec67319b46a095fb82f6cf80e86f9f3'
base='d9cc516d54b4642f59fe126c331a19945fdf75f1'
echo '=== EXACT HEAD ==='
printf 'checked_out='; git rev-parse HEAD
printf 'target_type='; git cat-file -t "$target"
git merge-base --is-ancestor "$base" "$target" && echo 'base_is_ancestor=yes'
git show -s --format='target=%H%nparents=%P%nsubject=%s' "$target"
git diff --check "$base" "$target"
echo '=== DELTA SINCE PRIOR REVIEW ==='
git diff --name-status "$previous" "$target"
git diff --find-renames --unified=100 "$previous" "$target" -- tests/performance docs README.md package.json
echo '=== PERFORMANCE FILE MAP ==='
git ls-tree -r --name-only "$target" -- tests/performance | sort
echo '=== OUTLINES ==='
for file in \
tests/performance/employment_separation_buyer_path.js \
tests/performance/employment_separation_run_contract.mjs \
tests/performance/employment_separation_acceptance_contract.mjs \
tests/performance/employment_separation_acceptance_check.mjs \
tests/performance/employment_separation_fixture_contract.mjs \
tests/performance/employment_separation_response_contract.mjs \
tests/performance/employment_separation_run_contract.test.mjs \
tests/performance/employment_separation_acceptance_contract.test.mjs \
tests/performance/employment_separation_acceptance_latency_cardinality.test.mjs \
tests/performance/employment_separation_fixture_contract.test.mjs
do
if git cat-file -e "$target:$file" 2>/dev/null; then
echo "--- $file"
git show "$target:$file" > "/tmp/$(basename "$file")"
ast-grep outline "/tmp/$(basename "$file")" --items all 2>/dev/null || true
fi
done
echo '=== WORKLOAD ==='
git show "$target:tests/performance/employment_separation_buyer_path.js" | nl -ba
echo '=== RUN CONTRACT ==='
git show "$target:tests/performance/employment_separation_run_contract.mjs" | nl -ba
echo '=== ACCEPTANCE CONTRACT ==='
git show "$target:tests/performance/employment_separation_acceptance_contract.mjs" | nl -ba
echo '=== FIXTURE CONTRACT ==='
git show "$target:tests/performance/employment_separation_fixture_contract.mjs" | nl -ba
echo '=== RESPONSE CONTRACT ==='
git show "$target:tests/performance/employment_separation_response_contract.mjs" | nl -ba
echo '=== FOCUSED TESTS ==='
git ls-tree -r --name-only "$target" -- tests/performance | rg '(run_contract|acceptance.*(cardinality|latency|contract|edge)|fixture_contract|response_contract).*test\.mjs$' | while IFS= read -r file; do
echo "--- $file"
git show "$target:$file" | nl -ba
done
echo '=== METRIC / THRESHOLD / OUTPUT AUDIT ==='
git grep -n -E \
'(employment_separation_latency_samples|duration_ms|new (Counter|Trend)|\.add\(|thresholds|sample_complete|expected_iterations|completed_iterations|iterations\.values\.count|handleSummary|JSON\.stringify|__ENV|baseUrl|bearer|token|endpoint|fixture.*sha|sha256)' \
"$target" -- tests/performance docs README.md package.json 2>/dev/null || true
echo '=== ACCEPTANCE PROVENANCE / RUNTIME EVIDENCE FIELD AUDIT ==='
git grep -n -E \
'(dataset_id|clearance_reference|preparation_protocol_reference|prepared_state_evidence_reference|profile_preconditions|resource_evidence_reference|observed_service_sha|performance_result_sha256|fixture_sha|right_cleared|synthetic|host_cpu|host_rss|pool|residual_)' \
"$target" -- tests/performance docs README.md package.json 2>/dev/null || true
echo '=== K6 PINNING OR DOCUMENTED VERSION ==='
git grep -n -i -E '(grafana/k6|xk6|k6 version|k6 run)' \
"$target" -- README.md docs tests package.json .github 2>/dev/null || trueLength of output: 223913 🤖 web_search executed:
Length of output: 11255 🤖 web_search executed:
Length of output: 8339
The new latency Counter closes the direct runtime gap. Every ordinary Fixture provenance checks remain present. The fixture validator requires This static review does not claim measured p95 acceptance, k6 runtime execution, protected status, or release status. You are interacting with an AI system. |
|
@coderabbitai review Please review exact current head |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
target='5807ce42aa88805c66287bd81d9e241f149d6ac8'
previous='e6e2511d09f56facf494eb8ee2969b3de61eac40'
base='d9cc516d54b4642f59fe126c331a19945fdf75f1'
echo '=== EXACT HEAD ==='
printf 'checked_out='; git rev-parse HEAD
printf 'target_type='; git cat-file -t "$target"
git merge-base --is-ancestor "$base" "$target" && echo 'base_is_ancestor=yes'
git show -s --format='target=%H%nparents=%P%nsubject=%s' "$target"
git diff --check "$base" "$target"
echo '=== DELTA SINCE PRIOR REVIEW ==='
git diff --name-status "$previous" "$target"
git diff --find-renames --unified=100 "$previous" "$target" -- tests/performance docs README.md package.json
echo '=== PERFORMANCE FILE MAP ==='
git ls-tree -r --name-only "$target" -- tests/performance | sort
echo '=== SOURCE OUTLINES ==='
for file in \
tests/performance/employment_separation_buyer_path.js \
tests/performance/employment_separation_run_contract.mjs \
tests/performance/employment_separation_acceptance_contract.mjs \
tests/performance/employment_separation_acceptance_check.mjs \
tests/performance/employment_separation_fixture_contract.mjs \
tests/performance/employment_separation_response_contract.mjs \
tests/performance/employment_separation_run_contract.test.mjs \
tests/performance/employment_separation_acceptance_contract.test.mjs \
tests/performance/employment_separation_acceptance_latency_cardinality.test.mjs \
tests/performance/employment_separation_fixture_contract.test.mjs
do
if git cat-file -e "$target:$file" 2>/dev/null; then
echo "--- $file"
git show "$target:$file" > "/tmp/$(basename "$file")"
ast-grep outline "/tmp/$(basename "$file")" --items all 2>/dev/null || true
fi
done
echo '=== WORKLOAD ==='
git show "$target:tests/performance/employment_separation_buyer_path.js" | nl -ba
echo '=== RUN CONTRACT ==='
git show "$target:tests/performance/employment_separation_run_contract.mjs" | nl -ba
echo '=== ACCEPTANCE CONTRACT ==='
git show "$target:tests/performance/employment_separation_acceptance_contract.mjs" | nl -ba
echo '=== FIXTURE CONTRACT ==='
git show "$target:tests/performance/employment_separation_fixture_contract.mjs" | nl -ba
echo '=== LATENCY CARDINALITY TESTS ==='
git show "$target:tests/performance/employment_separation_acceptance_latency_cardinality.test.mjs" | nl -ba
echo '=== RUN CONTRACT TESTS ==='
git show "$target:tests/performance/employment_separation_run_contract.test.mjs" | nl -ba
echo '=== METRIC, EVIDENCE, AND OUTPUT AUDIT ==='
git grep -n -E \
'(summaryTrendStats|count|new (Counter|Trend)|employment_separation_latency_samples|duration_ms|thresholds|iterations\.values\.count|handleSummary|JSON\.stringify|fixture.*sha|sha256|dataset_id|clearance_reference|preparation_protocol_reference|prepared_state_evidence_reference|profile_preconditions|observed_service_sha|performance_result_sha256|resource_evidence_reference|host_cpu|host_rss|residual_)' \
"$target" -- tests/performance docs README.md package.json 2>/dev/null || trueLength of output: 97202 🤖 web_search executed:
Length of output: 8536 🏁 Script executed: #!/bin/bash
set -euo pipefail
target='5807ce42aa88805c66287bd81d9e241f149d6ac8'
echo '=== ACCEPTANCE CLI ==='
git show "$target:tests/performance/employment_separation_acceptance_check.mjs" | nl -ba
echo '=== ACTUAL LATENCY SAMPLE REGRESSIONS ==='
git show "$target:tests/performance/employment_separation_acceptance_latency_samples.test.mjs" | nl -ba
echo '=== ALL ACCEPTANCE REGRESSIONS ==='
for file in \
tests/performance/employment_separation_acceptance_cardinality.test.mjs \
tests/performance/employment_separation_acceptance_contract.test.mjs \
tests/performance/employment_separation_acceptance_edge.test.mjs \
tests/performance/employment_separation_acceptance_latency_samples.test.mjs \
tests/performance/employment_separation_acceptance_provenance.test.mjs
do
echo "--- $file"
git show "$target:$file" | nl -ba | sed -n '1,280p'
done
echo '=== FIXTURE-IDENTITY / RIGHT-CLEARANCE / SYNTHETIC FIELD REFERENCES ==='
git grep -n -E \
'(fixture_sha|fixture.*digest|sha256.*fixture|right_cleared|synthetic|dataset_id|clearance_reference)' \
"$target" -- tests/performance docs README.md package.json 2>/dev/null || true
echo '=== K6 VERSION DECLARATION ==='
git grep -n -i -E '(grafana/k6|xk6|k6 version|image:.*k6)' \
"$target" -- .github docs README.md package.json Dockerfile docker-compose.yml 2>/dev/null || true
echo '=== RESULT OUTPUT SINKS ==='
git grep -n -E '(handleSummary|stdout|JSON\.stringify|console\.|baseUrl|bearerToken|ORGMETRA_PERFORMANCE_BEARER_TOKEN|ROUTE)' \
"$target" -- tests/performanceLength of output: 56664 🤖 web_search executed:
Length of output: 7533
The stronger Trend-cardinality repair closes the prior path. The workload adds one Trend sample and Counter sample for each ordinary request. It adds two Trend samples and Counter samples for each contention pair. The acceptance contract requires:
The contract applies
The runtime evidence still binds the exact result bytes by SHA-256. It requires the independently observed service SHA to match the candidate SHA. It also requires matching resource references, host and pool observations, and zero values for all declared residual-state counters. This static review does not claim measured p95 acceptance, k6 runtime execution, protected status, or release status. You are interacting with an AI system. |
|
@coderabbitai review Please review exact current head |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
target='3a78672949032f324fe3bbeae0f427ec73920bd7'
previous='79c5229717459ea6090d22652500484d9c5a0246'
show() {
local file="$1"
local range="$2"
echo "--- $file:$range"
git show "$target:$file" | nl -ba | sed -n "$range"
}
echo '=== EXACT TARGET IDENTITY ==='
echo "checked_out=$(git rev-parse HEAD)"
git cat-file -t "$target"
git show -s --format='target=%H%nparents=%P%nsubject=%s' "$target"
git diff --check "$previous" "$target" && echo 'diff_check=clean'
echo '=== `#393` DELTA ==='
git diff --name-status "$previous" "$target" -- tests/performance
git diff --unified=160 "$previous" "$target" -- tests/performance
echo '=== WORKLOAD OUTLINE ==='
git show "$target:tests/performance/employment_separation_buyer_path.js" \
> /tmp/employment_separation_buyer_path.js
ast-grep outline /tmp/employment_separation_buyer_path.js --items all || true
echo '=== WORKLOAD ==='
show tests/performance/employment_separation_buyer_path.js '1,380p'
echo '=== REQUEST/REDIRECT/PARSE CALL-SITE AUDIT ==='
git grep -n -E -C 10 \
'(http\.(post|batch)\(|redirects|firstCommit|replay|rejection|contention|parseJson\(|hasGovernedSeparation|headers|tags|unexpectedResponse|duration|latency)' \
"$target" -- tests/performance \
':!tests/performance/*test_support.mjs' || true
echo '=== FOCUSED `#393` REGRESSIONS ==='
git ls-tree -r --name-only "$target" -- tests/performance | \
rg '(redirect|buyer_path|request.*contract|response_contract).*\.test\.(mjs|js)$' | sort | \
while IFS= read -r file; do
echo "--- $file"
git show "$target:$file" | nl -ba
done
echo '=== K6 PINNING AND RUNNER ==='
for file in \
tests/performance/run_employment_separation_benchmark.sh \
tests/performance/employment_separation_k6_runtime_contract.mjs \
tests/performance/employment_separation_k6_evidence_contract.mjs
do
if git cat-file -e "$target:$file" 2>/dev/null; then
show "$file" '1,280p'
fi
done
echo '=== REQUEST URL CONSTRUCTION / CANONICAL ROUTE REFERENCES ==='
git grep -n -E -C 7 \
'(/v1/employment-separations|ORGMETRA_PERFORMANCE_TARGET|target.*url|base.*url|new URL|http\.(post|batch)\()' \
"$target" -- tests/performance ':!tests/performance/*test.mjs' ':!tests/performance/*test_support.mjs' || trueLength of output: 202798 🤖 web_search executed:
Length of output: 3279
I found no false-GREEN or false-RED issue in the requested
The workload applies the helper to every governed request.
The new request-contract regression verifies the following conditions.
The existing response contracts prevent a direct non-canonical responder from passing merely by returning a
The runner still pins k6 I used the existing project guidance that local fixture, result, runtime, and digest validation is structural evidence only. This Draft does not provide a measured performance result, commercial acceptance, protected integration, or release status. Commercial acceptance remains fail closed pending I did not run repository tests, k6, Podman, or a hosted workflow. 🧠 Learnings usedYou are interacting with an AI system. |
|
@coderabbitai review Please review exact head |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
target='822e591b3b111e5900daecefdd20ea160e50abbe'
previous='3a78672949032f324fe3bbeae0f427ec73920bd7'
show() {
local file="$1"
local range="${2:-1,420p}"
echo "--- $file:$range"
git show "$target:$file" | nl -ba | sed -n "$range"
}
echo '=== EXACT TARGET IDENTITY ==='
echo "checked_out=$(git rev-parse HEAD)"
git cat-file -t "$target"
git show -s --format='target=%H%nparents=%P%nsubject=%s' "$target"
git diff --check "$previous" "$target" && echo 'diff_check=clean'
echo '=== `#394` DELTA ==='
git diff --name-status "$previous" "$target" -- tests/performance
git diff --unified=180 "$previous" "$target" -- tests/performance
echo '=== PERFORMANCE FILE MAP ==='
git ls-tree -r --name-only "$target" -- tests/performance | sort
echo '=== ORIGIN, REQUEST, WORKLOAD, AND RUNNER OUTLINES ==='
for file in \
tests/performance/employment_separation_origin_contract.mjs \
tests/performance/employment_separation_origin_contract.test.mjs \
tests/performance/employment_separation_buyer_path.js \
tests/performance/employment_separation_request_contract.mjs \
tests/performance/employment_separation_request_contract.test.mjs \
tests/performance/run_employment_separation_benchmark.sh \
tests/performance/employment_separation_k6_runtime_contract.mjs \
tests/performance/employment_separation_k6_evidence_contract.mjs
do
if git cat-file -e "$target:$file" 2>/dev/null; then
echo "--- $file"
git show "$target:$file" > "/tmp/$(basename "$file")"
case "$file" in
*.mjs|*.js) ast-grep outline "/tmp/$(basename "$file")" --items all 2>/dev/null || true ;;
esac
fi
done
echo '=== FOCUSED IMPLEMENTATIONS AND REGRESSIONS ==='
for file in \
tests/performance/employment_separation_origin_contract.mjs \
tests/performance/employment_separation_origin_contract.test.mjs \
tests/performance/employment_separation_buyer_path.js \
tests/performance/employment_separation_request_contract.mjs \
tests/performance/employment_separation_request_contract.test.mjs \
tests/performance/run_employment_separation_benchmark.sh \
tests/performance/employment_separation_k6_runtime_contract.mjs \
tests/performance/employment_separation_k6_evidence_contract.mjs
do
if git cat-file -e "$target:$file" 2>/dev/null; then
show "$file" '1,460p'
fi
done
echo '=== ORIGIN / PROXY / REDIRECT / URL-CONSTRUCTION CALL-SITE AUDIT ==='
git grep -n -E -C 8 \
'(ORGMETRA_PERFORMANCE_BASE_URL|normalize.*Origin|https:|redirects|noProxy|no_proxy|HTTP_PROXY|HTTPS_PROXY|http_proxy|https_proxy|proxy|/v1/employment-separations|http\.(post|batch)\(|new URL|ROUTE)' \
"$target" -- tests/performance ':!tests/performance/*test_support.mjs' || true
echo '=== RUNTIME ENVIRONMENT AND EXECUTION ENTRY-POINT AUDIT ==='
git grep -n -E -C 8 \
'(run_employment_separation_benchmark|ORGMETRA_PERFORMANCE_|K6_|HTTP_PROXY|HTTPS_PROXY|NO_PROXY|no_proxy|grafana/k6|k6 run|redirects)' \
"$target" -- . ':!node_modules' ':!dist' ':!build' 2>/dev/null || true
echo '=== DIRECT URL PARSING OUTSIDE ORIGIN CONTRACT ==='
git grep -n -E -C 5 \
'(new URL\(|URL\(|ORGMETRA_PERFORMANCE_BASE_URL)' \
"$target" -- tests/performance ':!tests/performance/*test.mjs' ':!tests/performance/*test_support.mjs' || trueLength of output: 203798 🤖 web_search executed:
Length of output: 11722 🏁 Script executed: #!/bin/bash
set -euo pipefail
target='822e591b3b111e5900daecefdd20ea160e50abbe'
show() {
local file="$1" range="$2"
echo "--- $file:$range"
git show "$target:$file" | nl -ba | sed -n "$range"
}
echo '=== EXACT COMMIT / DELTA PATHS ==='
echo "checked_out=$(git rev-parse HEAD)"
git show -s --format='%H%n%P%n%s' "$target"
git diff --name-status 3a78672949032f324fe3bbeae0f427ec73920bd7 "$target"
echo '=== REQUEST CONTRACT COMPLETE ==='
show tests/performance/employment_separation_request_contract.mjs '1,180p'
echo '=== REQUEST CONTRACT TEST COMPLETE ==='
show tests/performance/employment_separation_request_contract.test.mjs '1,220p'
echo '=== DIRECT-NETWORK CONTRACT COMPLETE ==='
show tests/performance/employment_separation_run_contract.mjs '1,200p'
echo '=== DIRECT-NETWORK TESTS ==='
show tests/performance/employment_separation_run_contract.test.mjs '80,150p'
echo '=== RUNNER EXECUTION / NETWORK / PUBLICATION ==='
show tests/performance/run_employment_separation_benchmark.sh '95,175p'
echo '=== TLS, PROXY, AND REDIRECT OPTIONS IN ALL PERFORMANCE SOURCES ==='
git grep -n -E -C 4 \
'(insecureSkipTLSVerify|insecure-skip-tls-verify|K6_INSECURE_SKIP_TLS_VERIFY|HTTP_PROXY|HTTPS_PROXY|ALL_PROXY|NO_PROXY|no_proxy|redirects|maxRedirects|K6_MAX_REDIRECTS)' \
"$target" -- tests/performance ':!tests/performance/*test_support.mjs' || true
echo '=== ORIGIN CONTRACT TEST INVENTORY ==='
git ls-tree -r --name-only "$target" -- tests/performance | rg '(request_contract|origin).*test\.(mjs|js)$' | sort
echo '=== EXPORTED REQUEST-CONTRACT IMPORTS AND URL REQUESTS ==='
git grep -n -E -C 4 \
'(requireGovernedSeparationHttpsOrigin|governedSeparationRequestParams|http\.(post|batch)\()' \
"$target" -- tests/performance ':!tests/performance/*test.mjs' ':!tests/performance/*test_support.mjs'Length of output: 40812
I found no false-GREEN or false-RED issue in the requested
All governed requests retain the existing path controls.
The direct-network control composes correctly with the origin control.
The focused regression covers valid HTTPS origins, optional port and trailing-slash normalization, plaintext HTTP, userinfo, path, query, fragment, whitespace, and invalid port rejection. I used the existing project guidance that local fixture, runtime, result, and digest validation is structural evidence only. Commercial acceptance remains fail closed pending I did not run repository tests, k6, Podman, or a hosted workflow. This source review does not claim measured performance, commercial acceptance, protected integration, or release status. 🧠 Learnings usedYou are interacting with an AI system. |
|
@coderabbitai review Please review exact current head |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
target='74f726d2e81ab7b15df4944387817059588045d1'
previous='b87001c4b8b0154bcb259a2fac5dc5d4dc13108b'
show() {
local file="$1"
local range="${2:-1,420p}"
echo "--- $file:$range"
git show "$target:$file" | nl -ba | sed -n "$range"
}
echo '=== EXACT TARGET IDENTITY ==='
echo "checked_out=$(git rev-parse HEAD)"
git cat-file -t "$target"
git show -s --format='target=%H%nparents=%P%nsubject=%s' "$target"
git diff --check "$previous" "$target" && echo 'diff_check=clean'
echo '=== `#394` CURRENT-HEAD DELTA ==='
git diff --name-status "$previous" "$target" -- tests/performance
git diff --unified=160 "$previous" "$target" -- tests/performance
echo '=== RELEVANT SOURCE OUTLINES ==='
for file in \
tests/performance/employment_separation_origin_contract.mjs \
tests/performance/employment_separation_origin_contract.test.mjs \
tests/performance/employment_separation_k6_tls_contract.mjs \
tests/performance/employment_separation_k6_tls_contract.test.mjs \
tests/performance/employment_separation_buyer_path.js \
tests/performance/employment_separation_request_contract.mjs \
tests/performance/employment_separation_run_contract.mjs \
tests/performance/run_employment_separation_benchmark.sh
do
if git cat-file -e "$target:$file" 2>/dev/null; then
git show "$target:$file" > "/tmp/$(basename "$file")"
echo "--- $file"
case "$file" in
*.mjs|*.js) ast-grep outline "/tmp/$(basename "$file")" --items all 2>/dev/null || true ;;
esac
fi
done
echo '=== FOCUSED IMPLEMENTATIONS AND REGRESSIONS ==='
for file in \
tests/performance/employment_separation_origin_contract.mjs \
tests/performance/employment_separation_origin_contract.test.mjs \
tests/performance/employment_separation_k6_tls_contract.mjs \
tests/performance/employment_separation_k6_tls_contract.test.mjs \
tests/performance/employment_separation_buyer_path.js \
tests/performance/employment_separation_request_contract.mjs \
tests/performance/employment_separation_run_contract.mjs \
tests/performance/run_employment_separation_benchmark.sh
do
if git cat-file -e "$target:$file" 2>/dev/null; then
show "$file" '1,460p'
fi
done
echo '=== TLS, ORIGIN, AND HTTP-CALL AUDIT ==='
git grep -n -E -C 10 \
'(insecureSkipTLSVerify|insecure-skip-tls-verify|exec\.test\.options|require.*Tls|require.*Origin|ORGMETRA_PERFORMANCE_BASE_URL|https:|http\.(post|batch)\(|firstCommit|replay|rejection|contention|redirects|HTTP_PROXY|HTTPS_PROXY|ALL_PROXY)' \
"$target" -- tests/performance \
':!tests/performance/*test.mjs' ':!tests/performance/*test_support.mjs' || true
echo '=== TEST ASSERTION AUDIT ==='
git grep -n -E -C 5 \
'(insecureSkipTLSVerify|undefined|null|false|true|ordinary|contention|http\.post|http\.batch|require.*Origin|https)' \
"$target" -- tests/performance \
'*tls*test*.mjs' '*origin*test*.mjs' '*buyer*test*.mjs' 2>/dev/null || true
echo '=== ALL PERFORMANCE EXECUTION REFERENCES ==='
git grep -n -E -C 5 \
'(run_employment_separation_benchmark|employment_separation_buyer_path\.js|insecureSkipTLSVerify|K6_INSECURE|ORGMETRA_PERFORMANCE_BASE_URL)' \
"$target" -- . ':!node_modules' ':!dist' ':!build' 2>/dev/null || trueLength of output: 203747 🤖 web_search executed:
Length of output: 12646 🏁 Script executed: #!/bin/bash
set -euo pipefail
target='74f726d2e81ab7b15df4944387817059588045d1'
previous='b87001c4b8b0154bcb259a2fac5dc5d4dc13108b'
show() {
local file="$1"
echo "--- $file"
git show "$target:$file" | nl -ba
}
echo '=== IDENTITY AND FOCUSED DELTA ==='
git show -s --format='target=%H%nparents=%P%nsubject=%s' "$target"
git diff --check "$previous" "$target" && echo 'diff_check=clean'
git diff --unified=100 "$previous" "$target" -- \
tests/performance/employment_separation_run_contract.mjs \
tests/performance/employment_separation_run_contract.test.mjs \
tests/performance/employment_separation_buyer_path.js
echo '=== REQUEST ORIGIN CONTRACT ==='
show tests/performance/employment_separation_request_contract.mjs
echo '=== REQUEST ORIGIN TEST ==='
show tests/performance/employment_separation_request_contract.test.mjs
echo '=== TLS RUN CONTRACT ==='
git show "$target:tests/performance/employment_separation_run_contract.mjs" | nl -ba | sed -n '60,90p'
echo '=== TLS RUN-CONTRACT TEST ==='
git show "$target:tests/performance/employment_separation_run_contract.test.mjs" | nl -ba | sed -n '90,125p'
echo '=== WORKLOAD INITIALIZATION AND PROFILE FUNCTIONS ==='
git show "$target:tests/performance/employment_separation_buyer_path.js" | nl -ba | sed -n '1,175p'
echo '=== TLS-GUARD CALL CONTEXTS ==='
git grep -n -E -C 16 'requireCommercialTls\(|http\.(post|batch)\(' \
"$target" -- tests/performance/employment_separation_buyer_path.js
echo '=== TLS-RELATED TEST FILES ==='
git ls-tree -r --name-only "$target" -- tests/performance | rg '(tls|transport|buyer_path).*test\.(mjs|js)$' | sort | while IFS= read -r file; do
echo "--- $file"
git show "$target:$file" | nl -ba | grep -E -C 8 '(insecureSkipTLSVerify|requireCommercialTls|http\.post|http\.batch|ordinary|contention)' || true
doneLength of output: 38677
I found no false-GREEN or false-RED issue in the requested
The certificate-verification boundary also fails closed.
The workload applies the resolved-option guard before all governed requests.
The existing direct-network and no-redirect controls remain active.
I inspected source only. I did not run repository tests, k6, Podman, or a hosted workflow. This review does not claim measured performance, commercial acceptance, protected integration, or release status. You are interacting with an AI system. |
|
@coderabbitai review Please review exact head |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
target='151a2269ef6fb21cf5984e6ced9f98bb286cf42a'
previous='2b3e9502333d4295863674f7d3d4b30cdd3b8917'
show() {
local file="$1"
local range="${2:-1,420p}"
echo "--- $file:$range"
git show "$target:$file" | nl -ba | sed -n "$range"
}
echo '=== EXACT TARGET IDENTITY ==='
echo "checked_out=$(git rev-parse HEAD)"
git cat-file -t "$target"
git show -s --format='target=%H%nparents=%P%nsubject=%s' "$target"
git diff --check "$previous" "$target" && echo 'diff_check=clean'
echo '=== `#395` DELTA ==='
git diff --name-status "$previous" "$target" -- tests/performance
git diff --find-renames --unified=160 "$previous" "$target" -- tests/performance
echo '=== PERFORMANCE FILE MAP ==='
git ls-tree -r --name-only "$target" -- tests/performance | sort
echo '=== TARGET SOURCE OUTLINES ==='
for file in \
tests/performance/employment_separation_acceptance_check.mjs \
tests/performance/employment_separation_commercial_authority_contract.mjs \
tests/performance/employment_separation_commercial_authority_contract.test.mjs \
tests/performance/employment_separation_deployment_evidence_contract.mjs \
tests/performance/employment_separation_deployment_evidence_contract.test.mjs \
tests/performance/employment_separation_evidence_attestation_contract.mjs \
tests/performance/employment_separation_evidence_attestation_contract.test.mjs \
tests/performance/employment_separation_acceptance_contract.mjs \
tests/performance/employment_separation_result_artifact.mjs \
tests/performance/employment_separation_runtime_evidence_artifact.mjs
do
if git cat-file -e "$target:$file" 2>/dev/null; then
echo "--- $file"
git show "$target:$file" > "/tmp/$(basename "$file")"
ast-grep outline "/tmp/$(basename "$file")" --items all 2>/dev/null || true
fi
done
echo '=== COMPOSED GATE, OWNER GATES, AND CLI ==='
for file in \
tests/performance/employment_separation_acceptance_check.mjs \
tests/performance/employment_separation_commercial_authority_contract.mjs \
tests/performance/employment_separation_deployment_evidence_contract.mjs \
tests/performance/employment_separation_evidence_attestation_contract.mjs
do
if git cat-file -e "$target:$file" 2>/dev/null; then
show "$file" '1,500p'
fi
done
echo '=== FOCUSED TESTS ==='
git ls-tree -r --name-only "$target" -- tests/performance | \
rg '(commercial.*authority|deployment.*evidence|evidence.*attestation|acceptance.*(check|contract)).*\.test\.m?js$' | sort | \
while IFS= read -r file; do
echo "--- $file"
git show "$target:$file" | nl -ba
done
echo '=== GATE/CALLER-CONTROLLED-ARTIFACT/CANDIDATE-IDENTITY AUDIT ==='
git grep -n -E -C 10 \
'(requireCommercialPerformanceAuthorities|require.*Authority|`#2162`|2162|`#395`|395|observed_service_sha|candidate_sha|deployment|attestation|readFile|readFileSync|open\(|createReadStream|process\.argv|ORGMETRA_PERFORMANCE|accept|accepted|commercial|receipt|result)' \
"$target" -- tests/performance ':!tests/performance/*test_support.mjs' || true
echo '=== ENTRY POINTS AND POSITIVE-CLAIM AUDIT ==='
git grep -n -E -C 6 \
'(employment_separation_acceptance_check|acceptance.*check|commercial.*accept|performance.*accept|deployment.*accept|accepted[[:space:]]*:|receipt|structurally_valid|passed)' \
"$target" -- . ':!node_modules' ':!dist' ':!build' 2>/dev/null || trueLength of output: 203899 🏁 Script executed: #!/bin/bash
set -euo pipefail
target='151a2269ef6fb21cf5984e6ced9f98bb286cf42a'
echo '=== IDENTITY ==='
echo "checked_out=$(git rev-parse HEAD)"
git show -s --format='target=%H%nparents=%P%nsubject=%s' "$target"
echo '=== RELEVANT FILES ==='
git ls-tree -r --name-only "$target" -- tests/performance | \
rg '(commercial|authenticated.*evidence|deployment.*evidence|acceptance_check|acceptance_cli).*\.m?js$' | sort
echo '=== COMPOSED GATE ==='
git show "$target:tests/performance/employment_separation_commercial_authority_contract.mjs" | nl -ba
echo '=== EVIDENCE ATTESTATION GATE ==='
git show "$target:tests/performance/employment_separation_authenticated_evidence_gate.mjs" | nl -ba
echo '=== DEPLOYMENT IDENTITY GATE ==='
git show "$target:tests/performance/employment_separation_deployment_evidence_gate.mjs" | nl -ba
echo '=== ACCEPTANCE CLI ==='
git show "$target:tests/performance/employment_separation_acceptance_check.mjs" | nl -ba
echo '=== COMPOSED GATE TEST ==='
git show "$target:tests/performance/employment_separation_commercial_authority_contract.test.mjs" | nl -ba
echo '=== CLI DIGEST TEST ==='
git show "$target:tests/performance/employment_separation_acceptance_cli_digest.test.mjs" | nl -ba
echo '=== ALL IMPORTS AND INVOCATIONS ==='
git grep -n -E -C 4 \
'(requireCommercialPerformanceAuthorities|requireAuthenticatedPerformanceEvidence|requireAuthenticatedDeploymentEvidence)' \
"$target" -- tests/performance
echo '=== ACCEPTANCE CLI FILE READ ORDER ==='
git grep -n -E -C 5 \
'(process\.argv|readFile\(|validateEmploymentSeparationAcceptance|validatePinnedK6AcceptanceEvidence|console\.log|JSON\.stringify)' \
"$target" -- tests/performance/employment_separation_acceptance_check.mjs
echo '=== RELATED POSITIVE-RESULT FIELDS ==='
git grep -n -E -C 3 \
'(structurally_valid|commercially_valid|commercial_accept|accepted|deployment.*verified|observed_service_sha)' \
"$target" -- tests/performance/employment_separation_acceptance_check.mjs \
tests/performance/employment_separation_acceptance_contract.mjs \
tests/performance/employment_separation_deployment_evidence_gate.mjs \
tests/performance/employment_separation_authenticated_evidence_gate.mjs \
tests/performance/employment_separation_commercial_authority_contract.mjs || trueLength of output: 3442 🏁 Script executed: #!/bin/bash
set -euo pipefail
target='151a2269ef6fb21cf5984e6ced9f98bb286cf42a'
for file in \
tests/performance/employment_separation_commercial_owner_gate.mjs \
tests/performance/employment_separation_authenticated_evidence_gate.mjs \
tests/performance/employment_separation_deployment_evidence_gate.mjs \
tests/performance/employment_separation_acceptance_check.mjs \
tests/performance/employment_separation_commercial_owner_gate.test.mjs \
tests/performance/employment_separation_acceptance_cli_digest.test.mjs
do
echo "--- $file"
git show "$target:$file" | nl -ba
done
echo '=== ALL GATE IMPORTS AND INVOCATIONS ==='
git grep -n -E -C 4 \
'(requireCommercialPerformanceAuthorities|requireAuthenticatedPerformanceEvidence|requireAuthenticatedDeploymentEvidence)' \
"$target" -- tests/performance
echo '=== ALL ACCEPTANCE ENTRYPOINTS ==='
git grep -n -E -C 5 \
'(readFile\(|process\.argv|validateEmploymentSeparationAcceptance\(|validatePinnedK6AcceptanceEvidence\(|requireCommercialPerformanceAuthorities\()' \
"$target" -- tests/performance ':!tests/performance/*test.mjs'
echo '=== TARGET DELTA ==='
git diff --unified=100 2b3e9502333d4295863674f7d3d4b30cdd3b8917 "$target" -- tests/performanceLength of output: 32330
I found no false-GREEN or gate-weakening issue in the requested
I used the existing project guidance that local result, runtime, fixture, and digest validation is structural evidence only. Commercial acceptance remains fail closed until the organization-owned I inspected source only. I did not run repository tests, k6, Podman, or hosted workflows. This review does not claim measured performance, commercial acceptance, protected integration, or release status. 🧠 Learnings usedYou are interacting with an AI system. |
1 participant
Scope
This Draft PR owns executable Employment-separation buyer-path performance measurement and structural evidence contracts for #316. It stays stacked on active People owner #64; no force-push or destructive rebase is used to manufacture evidence.
Current parent authority
Canonical People #64 is exact
0b4409e50a1fd646c1f960164012df5984cbde0c, based on protecteddevelop@eb9757f8649aaad026a9865508d9aad50c1a7a4f.This performance branch is exact
151a2269ef6fb21cf5984e6ced9f98bb286cf42a. Fresh compare against current #64 has merge base exactly0b4409e..., 0 behind, 300 commits ahead, and 48 child-owned files, all undertests/performance/....The parent remains the canonical People source owner. #317 contains performance/evidence contracts only.
Evidence-integrity lineage
#363–#383 retain calendar/chronology, strict JSON, bounded-evidence, fixture/runtime, response-envelope and identity contracts. #384 binds governed outcome Rate cardinality to one verdict per scheduled iteration while contention retains two latency samples per pair. #386 keeps pinned k6
2.2.0defaulthandleSummary()aligned with requiredp(50)/p(95)/p(99)/max/countevidence. #387 binds governed responses to JSON media type; #388 rejects ambiguity caused by k6's collapsed repeated Content-Type representation. #389 bounds live response JSON to 16 KiB UTF-8 before strict parsing; #390 narrows only HTTP successrecorded_atto canonical Pythondatetime.isoformat()precision; #391 binds conflictsupport_referenceto the current Peopletoken_urlsafe(24)representation; #392 binds commercial response evidence to the owner'sCache-Control: no-storeand explicitVary: Authorizationpolicy. #393 closes redirect-following ambiguity with request-scopedredirects: 0for every profile. #394 requires an authenticated HTTPS origin and verifies the resolved k6 runtime has not disabled TLS certificate verification.#395 closes a separate deployment-identity false-GREEN that #2162 cannot solve by itself. The predecessor acceptance contract required caller-supplied
runtime.observed_service_shato equalcandidate_sha, but the benchmark runner only proved that the benchmark checkout matched the target SHA. It did not independently prove which deployed service behindORGMETRA_PERFORMANCE_BASE_URLactually served the timed requests. Sealing or attesting a self-assertedobserved_service_shamakes that statement immutable but does not authenticate the measured deployment.Current repair lineage:
21f8528abbe3b7edee68b50c500aa5bf1d77cb3a: test-first CLI contract requiring both unresolved commercial owner gaps (.github#2162evidence attestation and Orgmetra perf(people): authenticate exact deployed candidate before Employment-separation acceptance #395 deployed-candidate identity); RED because the predecessor entry point only surfaced #2162.a5bf8abf51751a436e2cdc6cf694a798884413d5: adds the deployment-evidence fail-closed owner gate for perf(people): authenticate exact deployed candidate before Employment-separation acceptance #395.a913c0d231cc1d9ed596a7749822b18c65c7fbd1: prevents the first unresolved authority from masking the second.3e8f44ad5a32cf607fc6a95e6cbfd27cf2235edc: test-first composed-owner contract; RED because its parent had no composed gate module.2b3e9502333d4295863674f7d3d4b30cdd3b8917: addsrequireCommercialPerformanceAuthorities()and preserves both fail-closed boundaries.151a2269...: acceptance CLI consumes the composed owner gate before any caller-controlled artifact paths are opened.Focused Node execution of the composed owner contract is 1/1 GREEN locally. This is structural contract evidence only; it is not hosted k6, deployment, performance or release evidence.
Acceptance boundary
The workload retains right-cleared non-synthetic fixture provenance, one governed profile per invocation, pinned k6 runtime/load contracts, exact outcome/latency cardinality, authenticated-HTTPS + certificate-verified exact-route/no-redirect/no-proxy request policy, p50/p95/p99/max evidence shape, exact-candidate benchmark materialization, no-clobber publication and explicit resource/cleanup evidence.
p(95) <= 20 msapplies only to ordinaryfirst_commit; no measurement is claimed here.Two different authority boundaries remain intentionally separate:
.github#2162must authenticate the exact inert performance evidence bytes/provenance.A positive receipt is forbidden until both released/versioned authorities are consumed. Mutable Draft central workflow work and caller-authored deployment/SHA strings are not released truth.
State: open · Draft. Current
151a2269...has no claimed hosted exact-head k6 run, production-equivalent authenticated deployment, measured p50/p95/p99/max, protected status or release status. #316 and #363–#395 remain open until protected/integration acceptance conditions are satisfied.