research(mir): preregister structure feature noninferiority evidence - #1228
seonghobae wants to merge 217 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@opencode-agent review exact head |
|
Queued @opencode-agent for PR #1228 at head |
|
@opencode-agent review exact head |
|
Queued @opencode-agent for PR #1228 at head |
|
Queued @opencode-agent for PR #1228 at head |
|
Queued @opencode-agent for PR #1228 at head |
|
Fresh exact-head verification receipt for This is not a scientific GREEN verdict and does not satisfy the real-audio acceptance contract. It only establishes that current-head platform builds completed while later aggregate/CI admission did not receive a runner. The cross-repository queue/admission receipt was routed to canonical owner ContextualWisdomLab/.github#712 (comment |
|
Queued @opencode-agent for PR #1228 at head |
|
Queued @opencode-agent for PR #1228 at head |
|
Queued @opencode-agent for PR #1228 at head |
|
Queued @opencode-agent for PR #1228 at head |
|
Queued @opencode-agent for PR #1228 at head |
|
Queued @opencode-agent for PR #1228 at head |
Signal-MIR scientific evidence owner
#1223 withdrew the
chroma_cqt→chroma_stftproduction switch because synthetic/mock timing did not establish structure accuracy on rights-cleared decoded audio. This Draft owns preregistered real-audio structure noninferiority evidence before any production default change. Resource Admission remains #866; Project Persistence remains #970; distribution/rights stay with their canonical owners.Exact identity / stack
develop@314ddeae7b775a4957594b599358c8255617eb2e.8fe6b6d99c009527ef0bcba419e6f6debdb23c23, Open / Draft / mergeable.bolt-performance-chart-export-13223013812255847379(repair(ci): format consolidated supply-chain policy test #1176).research/structure-noninferiority-1225.7eb2b9d1f08254d7ce7300a6f9a5b72ea06b3977.chroma_feature="cqt"; this PR does not switch production to STFT.The stack adopts #1176 as real ancestry/content rather than copying a second formatter implementation. Commit
715dc1a6250095352cb5a9b250ddd4271a4656aftooktest_supply_chain_policy.pyfrom canonical #1176 while preserving the scientific lane. Current7eb2b9d...is an ordinary one-file descendant.Frozen scientific semantics retained
Functional-label ACC remains pinned to
ismir-mirex/mirex-evaluation@b9fa0b0b32e2145af31f35830f78fc9d09a4301b:music_structure_analysis.eval_script.calculate_accuracywith the 200 ms frame-grid contract. Segmentation metrics remain bound to content-addressedmir_eval==0.8.2, including detection at 0.5/3.0 s (beta=1.0, trim=True), deviation (trim=True) and pairwise grouping (frame_size=0.1, beta=1.0).macro-track-v1/paired-track-bootstrap-v1retain equal-track aggregation, harmonic F reconstruction, macro deviation/ACC/latency means, maximum peak RSS, paired resampling with replacement,numpy.random.Generator(PCG64), and NumPy linear 0.025/0.975 percentile bounds.isolated-single-shot-v1retains macOS/Windows per-track performance evidence with zero same-process warm-ups, 20 fresh-process observations per lane/track, alternating CQT→STFT / STFT→CQT order,time.perf_counter_ns(), linear p50/p95, and process-lifetime peak RSS.Synthetic fixtures remain regression evidence only. Rights-cleared real decoded audio is required for production scientific acceptance.
Hosted Ruff RED → minimal causal repair
The merge-tested exact predecessor
715dc1a6250095352cb5a9b250ddd4271a4656afnow has terminal repository evidence:build-baseline 35787785367: SUCCESSSecurity Scan 35787785260: SUCCESSSAST Semgrep 35787785107: SUCCESSsbom 35787785063: SUCCESSci 35787785166: FAILURECodeQL PR 35787785203: FAILURE in the separately tracked central publication/reconciliation lifecycleThe repository CI failure is local and exact.
npm-lock-validationand macOSrust-checkpassed. Ubuntuci / build-and-testreachedruff:check, where Ruff 0.15.5 reported oneI001inservices/analysis-engine/tests/test_structure_functional_label_contract_policy.py. The previous attempted repair had inserted a blank line betweenimport pytestandimport test_structure_noninferiority_policy as noninferiority_policy; hosted Ruff still classified the block as unsorted/unformatted. The neighboring canonical policy test already groupspytestand sibling test-module imports in the same import section.Minimal causal repair
7eb2b9d1f08254d7ce7300a6f9a5b72ea06b3977removes exactly that one blank line. Fresh compare from715dc1a...is one commit, one file,+0/-1. No assertion, metric, threshold, corpus, runtime, dependency, production structure feature, ignore/noqa or scientific claim changes.Predecessor terminal evidence is RCA/semantic evidence only and does not transfer to
7eb2b9d.... This new exact head must reacquire repository/security/SAST/SBOM/CodeQL and review evidence; absent/queued is not GREEN.Review state / scientific claim boundary
No qualifying independent non-author current-head
APPROVEDis claimed. This branch still does not establish approved numeric production margins/latency thresholds, adequacy or representativeness of a concrete rights-cleared corpus, adequacy of bootstrap count/seed, a reviewed concrete host-profile payload, scientific noninferiority/latency superiority on real audio, MIREX leaderboard equivalence, or a production feature switch.Before candidate results are inspected, reviewers must freeze concrete corpus membership/representativeness, quality noninferiority margins, maximum candidate latency ratio, exact bootstrap count/seed, actual macOS/Windows
structure-performance-host-v1payload/content address, and the population/runtime claim. Only then may the complete rights-cleared corpus run through the canonical experiment runner.Normal integration order is #1176 authentic central CodeQL/review settlement → protected integration → ordinary/non-force reconciliation of this lane to protected
develop→ fresh exact-head/base scientific/repository/security evidence → qualifying independent review. No self-approval, force-push, destructive rebase, gate weakening, synthetic status, blind rerun, no-op freshness commit or predecessor-evidence transfer.UI Delivery Gate: FAIL — this scientific lane does not establish buyer-visible Active Player/UI interaction, accessibility, responsive or 8-locale acceptance.
Commercial Release Gate: FAIL — the exact hosted Ruff finding now has a one-line causal repair, but
7eb2b9d...has not yet reacquired fresh terminal gates, #1176 is not protected truth, independent approval is absent, and rights-cleared real-audio corpus execution plus frozen scientific acceptance thresholds remain missing.