Skip to content

preserve(score): zero-delta ScoreViewer tooltip provenance pending #731 - #1233

Draft
seonghobae wants to merge 9 commits into
developfrom
feat/ux-score-viewer-tooltips-4355712853197815450
Draft

seonghobae wants to merge 9 commits into
developfrom
feat/ux-score-viewer-tooltips-4355712853197815450

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

Preservation / succession status

이 PR은 독립 ScoreViewer accessibility source owner가 아닙니다.

Generated continuation disposition

Earlier preservation head 1db8197ba1f8104760a60430eab991f635b32686 retained shared Tooltip use plus focusable aria-disabled pagination with activation guards. Generated descendant 4d1ad7d64a88013df3a6291143700a7d5191ebfb then removed that duplicate source: it returned zoom/page controls to plain Button rendering, changed page boundaries back to native disabled, and weakened the local tests accordingly.

Fresh PR comparison now reports no file delta at all against protected develop. Because canonical #731 has already adopted and strengthened the valid reusable-tooltip/focusable-boundary semantics, restoring the weaker duplicate source here would create another Score accessibility writer rather than preserve unique product truth.

#731 retains shared Tooltip / TooltipTrigger / TooltipContent, focusable aria-disabled, guarded activation, reason-specific EN/KO copy, and persistent aria-describedby boundary reasons that remain available when the visual tooltip is dismissed. The valid semantic delta therefore remains on the canonical owner, not this zero-delta branch.

PR-0 rule

Zero file delta does not justify premature Close while #731 is still an unmerged Draft and still requires reconciliation with #1145's overlapping Score/PDF naming tree. Keep this PR open as provenance until a verified #731/#1145 successor preserves the valid accessibility contract, obtains fresh exact-head gates plus qualifying independent non-author approval, and reaches protected ancestry.

No source-neutral wake commit, duplicate Tooltip implementation, self-approval, force-push, destructive rebase, gate weakening, synthetic status, blind rerun, or predecessor-evidence transfer is used.

UI Delivery Gate: FAIL. The canonical source contract exists on #731, but packaged Electron/browser pointer/touch/keyboard, 400% zoom/reflow, forced-colors, Narrator/VoiceOver and KO/EN/JA/ZH/VI/ES/DE/FR acceptance remain unproven.

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: c83f8807-bb85-4a75-8d83-5bd4aed5ae67

📥 Commits

Reviewing files that changed from the base of the PR and between 314ddea and b794906.

📒 Files selected for processing (2)
  • apps/desktop/src/features/score/ScoreViewer.test.tsx
  • apps/desktop/src/features/score/ScoreViewer.tsx

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

ScoreViewer의 확대/축소 및 페이지 이동 컨트롤이 Tooltip 기반 트리거를 사용하도록 변경되었습니다. 페이지 경계에서는 aria-disabled를 설정하고 클릭을 차단합니다. 관련 테스트는 접근성 상태와 페이지 유지 동작을 검증합니다.

Changes

ScoreViewer 컨트롤

Layer / File(s) Summary
Tooltip 컨트롤 및 페이지 이동 제어
apps/desktop/src/features/score/ScoreViewer.tsx
확대/축소 및 이전/다음 페이지 컨트롤을 Tooltip 기반 트리거로 변경했습니다. 페이지 경계에서 aria-disabled를 설정하고 클릭 이벤트를 차단합니다.
컨트롤 상태 테스트
apps/desktop/src/features/score/ScoreViewer.test.tsx
페이지 경계의 aria-disabled 상태를 확인합니다. 비활성 이전/다음 버튼을 클릭해도 현재 페이지가 변경되지 않는지 확인합니다.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to b7949

The updated controls retain accessible names and page-boundary interaction behavior without a supported accessibility regression. The change is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 ScoreViewer의 툴팁 변경을 명확히 언급하므로 변경 사항과 관련됩니다. 다만 접근성 개선과 aria-disabled 처리는 포함하지 않으며, zero-deltaprovenance pending 표현은 변경 내용을 정확히 설명하지 않습니다.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as draft September 18, 2026 16:10
@seonghobae seonghobae added enhancement New feature or request priority: medium Normal-priority or P2 work labels Sep 19, 2026 — with ChatGPT Codex Connector
@seonghobae seonghobae changed the title 🎨 Palette: 악보 뷰어 아이콘 버튼 툴팁 및 접근성 개선 preserve(score): zero-delta ScoreViewer tooltip provenance pending #731 Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority: medium Normal-priority or P2 work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant