Skip to content

preserve(ui): duplicate App icon tooltips pending #1193 - #1256

Draft
seonghobae wants to merge 12 commits into
developfrom
palette-ux-tooltips-10619679114092578129
Draft

seonghobae wants to merge 12 commits into
developfrom
palette-ux-tooltips-10619679114092578129

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

Preservation / single-writer status

This PR is Open / Draft / mergeable preservation evidence. It must not become a second App.tsx Tooltip owner.

The production Tooltip behavior and useful no-native-title test intent are already represented more strongly in #1193. This branch remains preservation evidence only.

Repeated foreign-owner repair

This lineage has repeatedly received generated continuations whose only effective delta was #1176-owned services/analysis-engine/tests/test_supply_chain_policy.py Ruff formatting rather than App product semantics. Those deltas are repair findings, not App ownership.

Current 4f8d209f476a9d815537f7db0db7cbfdeed65c05 is the ordinary/non-force preservation repair retained from the latest verified recurrence. Intervening history remains ancestry; this lane does not take formatter ownership. Fresh live inspection in this run shows the branch still at that exact head with the expected two App-owned changed files and no newer semantic continuation.

Every source movement invalidates predecessor checks/reviews. Fresh exact-head evidence only counts; absent/queued/pending is not GREEN.

Succession / PR-0

#1193 owns Settings/Help, Import/Export, YouTube-clear and unavailable Save Tooltip semantics plus shared Tooltip resilience. This branch must not merge independently. Keep it open until #1193 or a verified successor preserves the valid semantic/test evidence, obtains its own exact-head gates and qualifying independent non-author approval, and reaches protected ancestry.

No self-approval, force-push, destructive rebase, copied formatter source, gate weakening, source-neutral wake commit, blind rerun, synthetic status or predecessor-evidence transfer.

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: fa898e52-d061-4acc-8a0a-42d4881d12d0

📥 Commits

Reviewing files that changed from the base of the PR and between 314ddea and 5aa27b3.

📒 Files selected for processing (2)
  • apps/desktop/src/App.test.tsx
  • apps/desktop/src/App.tsx

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Settings, Help, YouTube URL 지우기 버튼의 안내 텍스트를 네이티브 title 속성에서 Tooltip 컴포넌트로 이동했습니다. 기존 접근성 속성, 스타일, 동작은 유지했습니다. 관련 테스트에 title 속성 부재 검증을 추가했습니다.

Changes

툴팁 기반 컨트롤

Layer / File(s) Summary
컨트롤 툴팁 전환 및 검증
apps/desktop/src/App.tsx, apps/desktop/src/App.test.tsx
Settings, Help, YouTube URL 지우기 버튼이 Tooltip, TooltipTrigger, TooltipContent를 사용합니다. aria-label, aria-disabled, 클릭 처리, 스타일은 유지합니다. 테스트는 각 버튼에 title 속성이 없음을 검증합니다.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 5aa27

The three icon controls now use styled tooltips instead of native title text while retaining their labels and behavior. No actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 App 아이콘 버튼의 툴팁 변경을 언급합니다. PR의 주요 변경인 기본 HTML title 속성을 커스텀 Tooltip 컴포넌트로 교체하는 내용과 관련됩니다. 다만 변경 목적과 대상 버튼이 완전히 명확하지는 않습니다.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as draft September 22, 2026 15:07
@seonghobae seonghobae changed the title 🎨 Palette: 아이콘 전용 버튼에 접근성 높은 Tooltip 적용 preserve(ui): duplicate App icon tooltips pending #1193 Sep 22, 2026
seonghobae and others added 2 commits September 23, 2026 20:55
Keep the fresh generated continuation in ancestry while removing the unrelated #1176 formatter drift from this App Tooltip preservation lane. Canonical Tooltip product ownership remains #1193.

Signed-off-by: Seongho Bae <me@seonghobae.me>

Copy link
Copy Markdown
Collaborator Author

Current authority update: fresh descendant 5236796b1d034f9e0d5c9f08508169825548e8c7 changed only #1176-owned services/analysis-engine/tests/test_supply_chain_policy.py (+1/-3) after the prior App Tooltip preservation repair; it added no App semantic/test delta despite its generated commit message. Ordinary descendant 3b9d3b6981f0766e9297385d979d02dd245f43f1 uses 5236796... as parent and restores validated tree e5db09e5a176c45bf6132f686c54d7856b23dde1. Branch advanced with force=false; intervening history remains ancestry. #1193 remains canonical App Tooltip owner and #1176 remains sole formatter owner. This PR stays Open/Draft preservation evidence.

Copy link
Copy Markdown
Collaborator Author

Current-head authority refresh: branch ref is now 3b9d3b6981f0766e9297385d979d02dd245f43f1, two ordinary commits ahead of the body-recorded 19966f4d56adcd1318740566aca9098434087c0c. Fresh compare reports files=[]; App Tooltip semantics and ownership are unchanged, so semantic repair progress from this movement is 0. Keep Open / Draft pending canonical #1193 succession; no wake commit or predecessor-evidence promotion.

Copy link
Copy Markdown
Collaborator Author

Current authority update: live descendant f6a857e241745985aba9a714f6a4ecbf28dd2760 was three commits ahead of body-listed 19966f4d56adcd1318740566aca9098434087c0c, but fresh compare showed exactly one file delta: #1176-owned services/analysis-engine/tests/test_supply_chain_policy.py (+1/-3). No App Tooltip semantic/test source changed.

Ordinary non-force descendant 4f8d209f476a9d815537f7db0db7cbfdeed65c05 uses f6a857e... as parent and restores the validated 19966f4... tree. This lane still does not take formatter ownership and remains preservation-only pending canonical #1193 protected succession. Source movement invalidates predecessor checks/reviews; no predecessor evidence is promoted.

Copy link
Copy Markdown
Collaborator Author

Exact repair-head evidence has now materialized for 4f8d209f476a9d815537f7db0db7cbfdeed65c05: build-baseline 35967582711 is in progress; SAST Semgrep 35967582655 is pending; repository ci 35967582643, sbom 35967582682, CodeQL PR 35967582604, and Security Scan 35967582675 are queued. These are fresh current-head generations, but none is terminal yet, so the repair head remains non-GREEN and Draft.

seonghobae and others added 2 commits September 24, 2026 18:24
- Settings, Help, Clear URL 아이콘 버튼의 native `title` 속성을 커스텀 `<Tooltip>` 컴포넌트로 교체하여 접근성 및 UI 일관성을 향상했습니다.
- 관련 테스트 코드(`App.test.tsx`)에서 `title` 속성 검증 로직을 제거했습니다.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant