Repository navigation
584 Stop forcing radio and checkbox clicks in the E2E tests - #638
Merged
Merged
Conversation
A forced click skips the wait for the element to settle, so straight after a navigation it can miss and fail with "Clicking the checkbox did not change its state". A unit test now fails if one is added back. Refs #584
The content staging upload became the enhanced control, which puts the bundle id on its button, so the import problems test could not set the file. Refs #584
|
Review app for PR 638 was deleted |
E2E tests passed358 passed, 0 failed, 2 skipped in 19 min 30 s Commit |
davidgouge
approved these changes
Oct 19, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #584
A forced click skips Playwright's wait for the element to settle, so straight after a navigation it
can miss and fail the test with "Clicking the checkbox did not change its state". The first case was
fixed in #595; this removes the rest.
checkboxes take an ordinary click.
moved the bundle id onto the enhanced control's button, which broke this test on main.
Tested: E2E 356 (three full runs, all passed), Unit 7267 and Integration 1069 passed.