Repository navigation
Document the handoff from agentic feedback to human review #4063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -181,6 +181,27 @@ Make sure that your code is clean and readable, that your commits are small and | |
| atomic, with a proper commit message. We tend to use | ||
| [gitmoji](https://gitmoji.carloscuesta.me/), but this is not mandatory. | ||
|
|
||
| ### Handoff to human review | ||
|
|
||
| Before applying the `ready-for-human-review` label, verify that at least one | ||
| agentic or bot review has completed against the current PR head and that no | ||
| agentic reviews remain queued or running. No feedback does not prove that a | ||
| review occurred, and a review of an older revision does not qualify. If an | ||
| expected review has not appeared, eligibility remains unconfirmed. | ||
|
Comment on lines
+186
to
+190
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When one bot finishes quickly but another asynchronous review has not yet appeared as queued, these contributor-facing conditions allow the label to be applied immediately because one current-head review exists and no pending review is observable. Require contributors to wait the same five minutes after opening, pushing, or marking the PR ready (restarting after a head change); otherwise they can signal human handoff during the race that the agent-side grace period is designed to prevent. AGENTS.md reference: AGENTS.md:L288-L291 Useful? React with 👍 / 👎. |
||
|
|
||
| Address all agentic review feedback or explain with evidence why a suggestion | ||
| does not apply. Reply to each feedback item and resolve its associated review | ||
| thread, including outdated threads. | ||
| Check the latest PR revision, feedback, and thread status before applying the label; | ||
| local fixes, draft replies, or a clean bot summary alone are not sufficient. | ||
|
|
||
| Apply the existing label once these conditions are met so reviewers know it is | ||
| their turn. If you do not have permission to label the PR, ask a maintainer to | ||
| apply it. Do not resolve un-addressed feedback solely to qualify for the label. | ||
|
|
||
| The label indicates that agentic feedback has been addressed. It does not replace | ||
| human approval or required CI and merge checks. | ||
|
|
||
| ## Coding Conventions | ||
|
|
||
| Our repository uses Kotlin, as it is now the recommended language for Android. | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.