Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 42 additions & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Start here

Read the [contributor guide](CONTRIBUTING.md) for setup and contribution procedures.
Read and follow all guidance in [CONTRIBUTING.md](CONTRIBUTING.md).
Comment thread
typotter marked this conversation as resolved.
Resolved
Use the [documentation map](docs/README.md) to select current SDK guidance and
Foundation validation commands. Follow the module rules and validation tasks below.

Expand Down Expand Up @@ -274,6 +274,47 @@ To inspect the events the SDK emits from the sample app, use the `android-sdk-ev
- When preparing a release changelog: tags reflect customer impact, not change size. Internal-only changes are `[MAINTENANCE]`, not `[IMPROVEMENT]`. Follow the existing entry format: `* [TAG] Description. See [#N](link)`.
- When reviewing a release preparation PR (version bump and `CHANGELOG.md` update for a new release), review only the changes the PR itself makes. The release includes changes from PRs that were already reviewed and merged, so don't flag breaking changes or binary incompatibilities that come from them (e.g. a public API diff against the previous release): those were approved in their own PRs.

## Handoff to human review

Follow the [contributor handoff guidance](CONTRIBUTING.md#handoff-to-human-review)
and the additional agent requirements below when checking whether to prompt the
user to add `ready-for-human-review`. Check at these checkpoints:

- After opening a PR, pushing changes to it, or marking it ready for review.
- After replying to or resolving the remaining agentic feedback.
- When an agentic review finishes and you inspect its result.
- When the user asks about PR status or readiness for human review.

After opening a PR, pushing changes, or marking a draft ready, agents must allow
at least five minutes for asynchronous reviews to start before assessing
eligibility. Measure from the latest of these actions and restart the grace period
if the head changes. The grace period alone does not establish eligibility.

Prompt for the label only when all of these conditions are met:

- At least one agentic or bot review has completed against the current PR head. No feedback is not evidence that a review occurred; a review of an older revision does not qualify.
- No observed agentic reviews remain queued or running. If an expected review has not appeared, eligibility remains unconfirmed.
- All agentic feedback has been addressed or explicitly dispositioned with evidence, each feedback item has a posted reply, and all associated review threads are resolved, including outdated threads.

Refresh the current PR head, review activity, feedback, and thread status. Check
all pages of results; if retrieval fails or is incomplete, eligibility remains
unconfirmed. Local fixes, draft replies, or a clean bot summary alone are not
sufficient. Do not resolve unaddressed feedback solely to qualify for the label.

If eligible and the label is absent, ask: "All agentic feedback has been addressed.
Shall I add `ready-for-human-review`?" Apply the label only after user confirmation,
then recheck the current head and eligibility immediately before labelling. If the
label is already present, do not prompt or add it again.
Comment thread
typotter marked this conversation as resolved.
Resolved
Comment thread
typotter marked this conversation as resolved.
Resolved

If eligibility is unconfirmed, report what remains pending. If the task ends
before the grace period or reviews complete, report the deferred check; do not
claim readiness or imply that monitoring will continue without a separately
arranged follow-up.

This instruction does not independently authorise posting replies, resolving
threads, pushing, or merging; follow the applicable approval requirements for
those actions. Carry this rule into delegated PR work and PR automations.

# Dogfooding Branch

`dogfooding` is managed only through the scripts in `ci/scripts/dogfooding/`; read `ci/scripts/dogfooding/README.md` before helping with it. Never push to `dogfooding`, open a PR from a feature branch into it, or merge into it with squash or rebase: use `feature.sh`, `sync.sh` and `reset.sh`, which open the PRs. The only change made by hand is reverting a feature's dogfood merges, as described in the README's "Remove a single feature". Show the command and ask before running the scripts, since they push branches and open PRs.
21 changes: 21 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,27 @@ Make sure that your code is clean and readable, that your commits are small and
atomic, with a proper commit message. We tend to use
[gitmoji](https://gitmoji.carloscuesta.me/), but this is not mandatory.

### Handoff to human review

Before applying the `ready-for-human-review` label, verify that at least one
agentic or bot review has completed against the current PR head and that no
agentic reviews remain queued or running. No feedback does not prove that a
review occurred, and a review of an older revision does not qualify. If an
expected review has not appeared, eligibility remains unconfirmed.
Comment on lines +186 to +190

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add the review grace period to contributor steps

When one bot finishes quickly but another asynchronous review has not yet appeared as queued, these contributor-facing conditions allow the label to be applied immediately because one current-head review exists and no pending review is observable. Require contributors to wait the same five minutes after opening, pushing, or marking the PR ready (restarting after a head change); otherwise they can signal human handoff during the race that the agent-side grace period is designed to prevent.

AGENTS.md reference: AGENTS.md:L288-L291

Useful? React with 👍 / 👎.


Address all agentic review feedback or explain with evidence why a suggestion
does not apply. Reply to each feedback item and resolve its associated review
thread, including outdated threads.
Check the latest PR revision, feedback, and thread status before applying the label;
local fixes, draft replies, or a clean bot summary alone are not sufficient.

Apply the existing label once these conditions are met so reviewers know it is
their turn. If you do not have permission to label the PR, ask a maintainer to
apply it. Do not resolve un-addressed feedback solely to qualify for the label.

The label indicates that agentic feedback has been addressed. It does not replace
human approval or required CI and merge checks.

## Coding Conventions

Our repository uses Kotlin, as it is now the recommended language for Android.
Expand Down
Loading