Keep released dd-openfeature SDKs working with the agent by PerfectSlayer · Pull Request #12976 · DataDog/dd-trace-java

PerfectSlayer · 2026-10-21T11:54:27Z

What Does This Do

Keeps applications using a released dd-openfeature SDK working with this agent:

New dd-openfeature-1.56 instrumentation: released providers (1.56 to 1.68) link to the agent bootstrap API the bridge replaced; they now skip their legacy evaluator and return the caller defaults (PROVIDER_NOT_READY) with a warning to upgrade, instead of failing. It applies even with Feature Flags disabled, and is checked by muzzle against every released version.

Motivation

The previous PR removes the agent-coupled provider API (APMLP-1512). Merge right after it: in between, released SDKs fail with this agent.

Additional Notes

Files

File	Notes
`LegacyProviderInstrumentation`, `LegacyProviderAdvice`	Skip `initialize()` and return defaults from the evaluation methods of legacy providers (matched on `loadEvaluatorClass()`)
`ignored_class_name.trie`	Allows instrumenting `datadog.trace.api.openfeature.Provider`
`:dd-smoke-tests:openfeature-legacy`	Smoke test: an application built with the released `dd-openfeature` 1.67.1 gets the caller defaults and the upgrade warning, with Feature Flags enabled or disabled

Stack

The full change is in #12709. It was split into this stack to ease the review.

Jira ticket: APMLP-1512

🤖 Generated with Claude Code

datadog-prod-us1-5 · 2026-10-21T12:12:04Z

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 59.29% (-0.02%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 1e13ef9 | Docs | Give us feedback!}

dd-octo-sts · 2026-10-21T12:19:29Z

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite	Status
Startup	🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Scenario	Candidate	master	Δ (95% CI of mean)
startup:insecure-bank:iast:Agent	13.89 s	13.94 s	[-1.0%; +0.4%] (no difference)
startup:insecure-bank:tracing:Agent	12.91 s	12.90 s	[-0.6%; +0.7%] (no difference)
startup:petclinic:appsec:Agent	17.11 s	16.91 s	[+0.3%; +2.0%] (maybe worse)
startup:petclinic:iast:Agent	16.90 s	17.06 s	[-1.8%; -0.1%] (maybe better)
startup:petclinic:profiling:Agent	16.69 s	16.71 s	[-1.3%; +1.0%] (no difference)
startup:petclinic:sca:Agent	17.05 s	16.92 s	[-0.2%; +1.7%] (no difference)
startup:petclinic:tracing:Agent	16.07 s	16.19 s	[-1.7%; +0.1%] (no difference)

Commit: 1e13ef91 · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

chatgpt-codex-connector · 2026-10-22T08:55:34Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-22T08:59:13.332710Z	`4f242cb`	Draft marked ready
🔒 Security Review	🔄 Running since 2026-10-22T08:55:32.644855Z	`4f242cb`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

datadog-prod-us1-5

More details

Static review found no actionable compatibility gaps in legacy provider matching, initialization bypass, or default-value evaluation. Runtime behavior remains unverified.

Was this helpful? React 👍 or 👎

_{Open Bits AI session}

_{🤖 Bits Code Review · Commit 4f242cb}

datadog-prod-us1-5

More details

Static review supports that the legacy-provider fallback avoids loading the removed bootstrap evaluator and returns caller defaults for all five evaluation types, including when Feature Flags is disabled.

Was this helpful? React 👍 or 👎

_{Open Bits AI session}

_{🤖 Bits Code Review · Commit 0b85f6e}

sarahchen6

LGTM!

Released providers, from 1.56 to 1.68, link to the agent bootstrap API the bridge replaced: make them return the caller defaults instead of failing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Replace the legacy provider instrumentation tests, which loaded a released provider in a dedicated class loader, with a smoke test running an application built with the released dd-openfeature 1.67.1, with and without Feature Flags enabled. Drop the IDEA module configuration and use the static VERSION_11 import in the legacy provider instrumentation build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Mark the instrumentation module and advice classes as unused, as they are only referenced through AutoService and advice class names, and import the Advice annotations statically. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

PerfectSlayer added type: feature Enhancements and improvements tag: no release notes Changes to exclude from release notes tag: ai generated Largely based on code generated by an AI or LLM comp: openfeature OpenFeature labels Oct 21, 2026

PerfectSlayer added this pull request to stack #12979 October 21, 2026 11:59

PerfectSlayer removed this pull request from stack #12979 October 21, 2026 12:00

PerfectSlayer added this pull request to stack #12980 October 21, 2026 12:04

PerfectSlayer force-pushed the bbujon/ffe-compat branch 2 times, most recently from 17c0f4e to 9b8b55c Compare October 21, 2026 14:19

PerfectSlayer force-pushed the bbujon/ffe-compat branch 3 times, most recently from 413ffd3 to 4f242cb Compare October 22, 2026 08:40

PerfectSlayer marked this pull request as ready for review October 22, 2026 08:55

PerfectSlayer requested review from a team as code owners October 22, 2026 08:55

PerfectSlayer requested review from jordan-wong and mhdatie and removed request for a team October 22, 2026 08:55

datadog-prod-us1-5 Bot reviewed Oct 22, 2026

View reviewed changes

PerfectSlayer requested review from a team as code owners October 22, 2026 11:00

PerfectSlayer requested review from erikayasuda and removed request for a team October 22, 2026 11:00

PerfectSlayer force-pushed the bbujon/ffe-compat branch from 4f242cb to b2884a9 Compare October 22, 2026 11:01

PerfectSlayer force-pushed the bbujon/ffe-compat branch from b2884a9 to 9e36453 Compare October 22, 2026 11:12

PerfectSlayer requested review from a team and dougqh and removed request for a team and mhdatie October 22, 2026 13:11

datadog-prod-us1-5 Bot reviewed Oct 22, 2026

View reviewed changes

sarahchen6 force-pushed the bbujon/ffe-compat branch from 0b85f6e to 6c105cc Compare October 22, 2026 22:19

sarahchen6 approved these changes Oct 22, 2026

View reviewed changes

PerfectSlayer and others added 5 commits October 23, 2026 11:09

feat(ffe): Keep released dd-openfeature SDKs working with the agent

d04a186

Released providers, from 1.56 to 1.68, link to the agent bootstrap API the bridge replaced: make them return the caller defaults instead of failing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

style(ffe): Follow the instrumentation conventions

a7c3b87

Mark the instrumentation module and advice classes as unused, as they are only referenced through AutoService and advice class names, and import the Advice annotations statically. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(ffe): Own the released provider smoke tests

7cacc8a

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

fix(ffe): Keep legacy OpenFeature fallback safe

1e13ef9

PerfectSlayer force-pushed the bbujon/ffe-compat branch from 6c105cc to 1e13ef9 Compare October 23, 2026 09:15

Navigation Menu

Repository navigation

Keep released dd-openfeature SDKs working with the agent - #12976

Keep released dd-openfeature SDKs working with the agent#12976
PerfectSlayer wants to merge 5 commits into
bbujon/ffe-agent-connectorfrom
bbujon/ffe-compat

PerfectSlayer commented Oct 21, 2026 •

edited

Loading

Uh oh!

datadog-prod-us1-5 Bot commented Oct 21, 2026 •

edited by datadog-prod-us1-6 Bot

Loading

Uh oh!

dd-octo-sts Bot commented Oct 21, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot commented Oct 22, 2026 •

edited

Loading

Uh oh!

datadog-prod-us1-5 Bot left a comment

Uh oh!

datadog-prod-us1-5 Bot left a comment

Uh oh!

sarahchen6 left a comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

PerfectSlayer commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Stack

Uh oh!

datadog-prod-us1-5 Bot commented Oct 21, 2026 • edited by datadog-prod-us1-6 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dd-octo-sts Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟢 Java Benchmark SLOs — All performance SLOs passed

Uh oh!

chatgpt-codex-connector Bot commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

datadog-prod-us1-5 Bot left a comment

Choose a reason for hiding this comment

Uh oh!

datadog-prod-us1-5 Bot left a comment

Choose a reason for hiding this comment

Uh oh!

sarahchen6 left a comment

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

PerfectSlayer commented Oct 21, 2026 •

edited

Loading

datadog-prod-us1-5 Bot commented Oct 21, 2026 •

edited by datadog-prod-us1-6 Bot

Loading

dd-octo-sts Bot commented Oct 21, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 22, 2026 •

edited

Loading