Repository navigation
Resolve the Feature Flags settings like the SDK - #12977
PerfectSlayer wants to merge 3 commits into
Conversation
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
a0b4cb0 to
13f62ff
Compare
13f62ff to
918c24c
Compare
918c24c to
4489a78
Compare
4489a78 to
2605ead
Compare
2605ead to
cf0d03a
Compare
cf0d03a to
6c85344
Compare
e22560c to
bbdf441
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The settings retain their existing keys and parsing behavior, and repository callers are consistently updated for the enum return type.
🤖 Bits Code Review · Commit bbdf441
Move the Feature Flags settings to dd-trace-api, remove the feature-flagging-config module, and expose the configuration source as an enum parsed like the SDK does. Check the agent and the SDK resolve the settings alike. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
9039dab to
1b3a770
Compare
What Does This Do
Resolves the Feature Flags settings in the agent like the
dd-openfeatureSDK does:dd-trace-apiand removes thefeature-flagging-configmodule.ConfigurationResolutionParityTest, checking the agent and the SDK resolve enablement and source alike, including padded values.Motivation
The agent and the SDK must agree on the configuration source (APMLP-1512). Done after the compatibility PR: released SDKs read the old settings class from the agent until they are guarded.
Additional Notes
Refactoring only for the agent settings; no change to the supported values.
Stack
The full change is in #12709. It was split into this stack to ease the review.
Jira ticket: APMLP-1512
🤖 Generated with Claude Code