Skip to content

feat(compat): add Azure inventory payload core - #175

Open
nina9753 wants to merge 9 commits into
mainfrom
nina.rei/SVLS-9604/compat-inventory-azure
Open

nina9753 wants to merge 9 commits into
mainfrom
nina.rei/SVLS-9604/compat-inventory-azure

Conversation

@nina9753

@nina9753 nina9753 commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • add the reusable serverless compatibility inventory crate and payload builder
  • collect canonical Azure Functions identity, slot, runtime, and subscription metadata
  • keep scheduling and transport out of this foundational slice

Stack

  1. feat(compat): add Azure inventory payload core #175 — Azure identity and core payload (this PR)
  2. feat(compat): add GCP inventory collection #176 — GCP inventory collection, based on this PR
  3. feat(compat): add serverless-compat inventory reporter (SVLS-9604) #161 — reporter, transport, and compat integration

#176 targets this PR branch. #161 will be rebuilt on #176 and retained as the top, end-to-end-testable PR so its existing URL, comments, and review history remain intact.

Testing

  • cargo test --package datadog-serverless-compat-inventory --locked --offline
  • cargo clippy --package datadog-serverless-compat-inventory --all-targets --locked --offline -- -D warnings
  • rustfmt --edition 2024 --check on all new Rust sources
  • git diff --check

Copilot AI balanced review requested due to automatic review settings September 29, 2026 13:45
@nina9753
nina9753 requested review from a team as code owners September 29, 2026 13:45
@nina9753
nina9753 requested review from apiarian-datadog and shreyamalpani and removed request for a team September 29, 2026 13:45
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-29T13:48:55.941936Z cd00914 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Unsafe test environment mutation, missing override coverage, and the unrelated TLS downgrade should be addressed.

Review effort: Balanced
Findings: 1 Medium severity · 1 Low severity

Open (2)
What changed in this PR

Adds the foundational Azure Functions inventory payload crate for Serverless Compat.

Changes:

  • Collects canonical Azure identity, slot, runtime, region, and subscription metadata.
  • Builds serialized Fleet Automation inventory payloads.
  • Adds focused Azure and payload tests.
File Description
src/​platform/​mod.rs Dispatches platform metadata collection.
src/​platform/​azure.rs Collects Azure Functions metadata and identity.
src/​payload.rs Constructs serialized inventory payloads.
src/​lib.rs Exposes the inventory report API.
Cargo.toml Defines the new crate and dependencies.
Cargo.lock Registers the crate and changes rustls.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread crates/datadog-serverless-compat-inventory/src/platform/azure.rs Outdated
Comment thread crates/datadog-serverless-compat-inventory/src/payload.rs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cd00914fa7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/datadog-serverless-compat-inventory/src/payload.rs Outdated

@apiarian-datadog apiarian-datadog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good to me, tho i'd defer to folks more familiar with serverless compat for an ultimate review.

Comment thread crates/datadog-serverless-compat-inventory/src/platform/azure.rs Outdated
Comment thread crates/datadog-serverless-compat-inventory/src/payload.rs Outdated
Comment thread crates/datadog-serverless-compat-inventory/src/platform/azure.rs Outdated
Comment thread crates/datadog-serverless-compat-inventory/src/platform/azure.rs Outdated
Comment thread crates/datadog-serverless-compat-inventory/src/platform/azure.rs Outdated
Comment thread .github/workflows/build-datadog-serverless-compat.yml Outdated
Comment thread crates/datadog-serverless-compat-inventory/src/platform/azure.rs Outdated
Comment thread crates/datadog-serverless-compat-inventory/Cargo.toml Outdated
Comment thread crates/datadog-serverless-compat-inventory/Cargo.toml Outdated
@nina9753
nina9753 added this pull request to stack #177 October 5, 2026 20:05
@nina9753
nina9753 requested a review from duncanpharvey October 5, 2026 20:52

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants