Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
apiarian-datadog
left a comment
There was a problem hiding this comment.
seems mostly reasonable, tho i'd defer to serverless-compat engineers for a final review.
419d66a to
577a685
Compare
There was a problem hiding this comment.
Note
Copilot was unable to run its full agentic suite in this review.
Copilot review overview
Review effort: Lite
Findings: 2
Open (4)
platform/gcp.rscallsresponse.chunk().await, which inreqwestis gated behind thestream… · New The new tests use#[tokio::test](without specifying a flavor), which defaults to the… · New ImportingQueryEnvfrom anazure_app_servicesmodule in a GCP collector is confusing and… · New A newreqwest::Clientis built on every metadata lookup. Since the region/project lookups can… · New
What changed in this PR
Adds GCP Cloud Functions platform detection so the serverless compat inventory reporter can emit platform metadata for EnvironmentType::CloudFunction.
Changes:
- Route
EnvironmentType::CloudFunctionto a new GCP collector. - Introduce
platform/gcp.rsto derive function identity from env vars and (optionally) the GCP metadata server. - Add new dependencies for HTTP metadata access and async tests.
| File | Description |
|---|---|
| crates/datadog-serverless-compat-inventory/src/platform/mod.rs | Wires CloudFunction environment type to the new GCP collector. |
| crates/datadog-serverless-compat-inventory/src/platform/gcp.rs | Implements GCP Cloud Functions identity + metadata server lookup with unit tests. |
| crates/datadog-serverless-compat-inventory/Cargo.toml | Adds reqwest, tokio, tracing, and httpmock needed by the new collector/tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
50c2380 to
ea6b41d
Compare
ea6b41d to
ca31815
Compare
ca31815 to
534e066
Compare



Summary
Stack
This PR is based on #175. After this slice is approved, #161 will be rebuilt on this branch and remain the top, end-to-end-testable PR so its existing discussion and review history are preserved.
Testing