[kmannislands]

Stacked on #3 (chore-merge-v0.14.1). Merge #3 first, or merge this into #3's branch.

Structure

This PR is red first, then green:

1. Red: two commits that only add tests. Each test fails on chore: update buildkit to v0.14.1 #3's merge commit (890baae) and passes on both parents (earthly-main 644b083 and upstream 91a3fc4).
2. Green: one fix commit per finding. Each fix turns its test green.

Findings

#	Finding	Test	How to run
1	send.go sender.updateProgress: the conflict resolution kept both the fork's s.mu lock and progressCurrent += size and upstream's progressCurrentMu and increment. Progress is double-counted, and s.mu is held during the callback, which upstream 216a08f was written to avoid.	TestSendProgressTotal	go test -race -run TestSendProgressTotal .
2	receive.go: the fork's verboseProgressCb(p.Stat.Path, StatusStat, …) call runs before filepath.FromSlash and before the unrepresentable-path rejection. The send side reports StatusStat with the native path and StatusSent with the wire (ToSlash) path. So on Windows the paths each side reports don't match.	TestVerboseProgressPathsConsistent	Red only on Windows (FromSlash/ToSlash do nothing on Unix). Compile it with GOOS=windows go test -c .; it runs on the windows-latest CI job.
3	.github/workflows/ci.yml: the merge dropped the fork's push trigger (earthly-main, gh_test_ci), and pull_request only targets master/main. So CI doesn't run for PRs into earthly-main, including #3 and this PR.	(CI config)	Check that CI runs on this PR

Known issue, not fixed here

TestCopySimple fails on macOS, and it fails on upstream too. It passes on Linux.

Commit map

Commit	Kind	Finding	Test turns green
88b32bf	red	#1 double-counted send progress	TestSendProgressTotal fails
2cf3609	red	#2 verbose progress paths (Windows)	TestVerboseProgressPathsConsistent fails on Windows only
f2e55f5	fix	#3 CI: restore push (earthly-main, gh_test_ci) and run pull_request for any base branch, so stacked PRs get CI	n/a
59f0fd7	fix	#1 take upstream's updateProgress: one increment under progressCurrentMu, and s.mu is no longer held during the callback	TestSendProgressTotal
cc66d52	fix	#2 both sides report native paths: the receiver's StatusStat moves after FromSlash and the unrepresentable-path check, and the sender's StatusSent uses filepath.FromSlash(h.path)	TestVerboseProgressPathsConsistent
e66a226	ci	pin actions to full-length commit SHAs (also in #6)	n/a
e2fbb01	ci	bump docker/bake-action to v5 for buildx >= 0.20 (also in #6)	n/a

Verification (at cc66d52)

• macOS, go test -race -count=1 ./...: everything passes except the known TestCopySimple failure.
• Linux, docker run --rm -v "$PWD":/src -w /src golang:1.21 go test -race -count=1 ./...: everything passes.
• Windows: GOOS=windows go vet ./... and GOOS=windows go test -c . both succeed. The test has not been run on Windows yet.

Windows results (update)

These come from throwaway workflow_dispatch probes that ran #6's workflow (shell: bash, so failures aren't hidden) with go test -v, on windows-latest with Go 1.20 and 1.21. The probe branches have been deleted.

Code	Run	TestSendProgressTotal	TestVerboseProgressPathsConsistent	TestHardlinkFilter
red 2cf3609	38001592592 (1.20, 1.21)	FAIL	FAIL: []string{"a", "dir", "dir\\b", …} does not contain "dir/b"	FAIL
fixes e66a226	38000552489 (1.20, 1.21)	--- PASS	--- PASS	FAIL
upstream 91a3fc4	38000549628	n/a	n/a	FAIL

• So finding feat: merge tonistiigi upstream (586307ad452fadb42e28be16d2b995b2eb6755e9) #2 is red on Windows at 2cf3609 and green at cc66d52/e66a226, as claimed. At e66a226 TestHardlinkFilter is the only failing test.
• TestHardlinkFilter fails on upstream 91a3fc4 the same way (an empty linkname, then foo2: The system cannot find the file specified.), so this PR didn't cause it. ci: make the workflow run again (pinning, Docker Hub auth, FreeBSD runner) #6 cherry-picks upstream's Windows skip for it (0c1f49d, upstream a0b4937). No code change is needed here.
• This PR's own ci.yml still runs the Windows Test step in PowerShell, which hides failures. Its "green" Windows jobs (e.g. run 37989776036) do log --- FAIL: TestHardlinkFilter. That is fixed in ci: make the workflow run again (pinning, Docker Hub auth, FreeBSD runner) #6 (ef0123f, shell: bash), and this PR gets that fix once ci: make the workflow run again (pinning, Docker Hub auth, FreeBSD runner) #6 lands in chore: update buildkit to v0.14.1 #3. The fix wasn't duplicated here, so test+fix: red tests and fixes for upstream merge (stacked on #3) #4's history and its pinned code head stay as they are.

CI did not run on this PR

GitHub disabled the ci workflow for inactivity (state: disabled_inactivity), so f2e55f5's trigger change has no effect until a maintainer turns it back on (gh workflow enable ci --repo EarthBuild/fsutil). Two things to watch once it is on:

• The repo has sha_pinning_required: true, and this workflow references actions by tag (actions/checkout@v4, etc.). That may fail at "Set up job".
• test-freebsd-amd64 uses macos-13, and GitHub has retired that runner image.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • File paths shown in verbose transfer progress now use the platform’s native path format, keeping sender and receiver status messages consistent.
  • Transfer progress totals now advance only when a progress callback is configured, and completion is reported once for transfers that include empty, small, or multi-part files.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: b6ac248b-ea89-43e2-8263-fc0d4139e942

---

📥 Commits

Reviewing files that changed from the base of the PR and between 890baae and e2fbb01.

---

📒 Files selected for processing (5)

• .github/workflows/ci.yml
• receive.go
• send.go
• send_progress_test.go
• verbose_progress_test.go

---

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

---

📝 Walkthrough

Walkthrough

The CI workflow now uses updated triggers and pinned action references. Sender and receiver progress callbacks report native-format paths. Sender progress totals increment only when a progress callback is configured, with new tests for paths and packet totals.

Changes

CI workflow

Layer / File(s)	Summary
Workflow triggers and pinned actions .github/workflows/ci.yml	Push triggers now target earthly-main and gh_test_ci; pull requests have no branch filter. Action references use commit SHAs.

Transfer progress reporting

Layer / File(s)	Summary
Native paths in progress callbacks receive.go, send.go, verbose_progress_test.go	The receiver converts STAT paths before reporting them, and the sender converts sent-file paths to native format. Tests compare callback paths across transfer statuses.
Progress totals with callbacks send.go, send_progress_test.go	The sender increments progress totals only when a callback is configured. The test compares the final total with counted STAT and DATA packet sizes and checks that the final callback occurs once.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

---

Merge Risk: ⚪ Minimal · up to e2fbb

No actionable regression is established in this PR. It is mergeable after normal checks.

Pre-merge checks | 4 | 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 4 files. (1 skipped: 1…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check		Issue #3 requires the fsutil change set that supports moby/buildkit v0.14.1 and the stacked merge order. The PR is based on the reported #3 merge commit 890baae, and the PR description requires #3 to …
Out of Scope Changes check		The source fixes address regressions attributed to the #3 upstream merge: send progress accounting, native verbose-progress paths, and CI triggers for stacked branches. The added tests verify those fi…
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title accurately identifies the added regression tests and fixes related to the upstream merge. It also notes the stacked relationship to issue #3. The CI updates are secondary and do not need to …

---

Full details: Docstring Coverage

Explanation

Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 4 files. (1 skipped: 1 unsupported.)

---

---

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 2

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

---

🛠️ Fix failing CI checks 💡

• Commit to this branch
• Create a new PR

---

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

---

_{Comment @coderabbitai help to get the list of available commands.}

[kmannislands]

Needs #6 first to see real CI impact. We should probably merge that and rebase the stack