Repository navigation
Conversation
Upgrade date-fns 2->4, uuid 9->11, semver 7.3->7.7, debounce 1->2, nanoevents 6->9, and bump matching @types/* packages. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Upgrade electron to ^35, electron-builder to ^25, @electron/rebuild to ^3.7 - Upgrade electron-devtools-installer to ^4 and remove APOLLO_DEVELOPER_TOOLS (no longer exported in v4) - Requires manual app testing to verify USB native module and window behavior Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Replace bundled Yarn 3.1.0 release with 4.18.1 - Fix packageManager field, which incorrectly declared yarn@1.22.22 - Migrate yarn.lock to the v10 format (no version changes besides terser's optional acorn peer now being resolved) - Keep install scripts and the per-project cache enabled; adopt Yarn 4 defaults for git repo approval and the npm minimal age gate Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings in main and the Yarn 4 upgrade (#160). Conflicts in .gitignore and package.json resolved by keeping both sides; yarn.lock regenerated with Yarn 4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- electron ^35 -> ^45.3.3 (35 is end-of-life; 43-45 are supported) - electron-builder ^26.8.1 -> ^26.18.0 - @electron/rebuild ^4.0.3 -> ^4.2.1 - Pin date-fns to ~4.1.0: 4.4.0's type declarations import "./x.ts" paths that TypeScript 4.9 cannot resolve Electron 44+ requires macOS 13 (Ventura) or later. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Replace the single date-fns `format(ms, "mm:ss")` call with a small formatElapsed helper. This removes the ~4.1.0 pin (newer date-fns typings need a newer TypeScript) and fixes the elapsed time showing wrong minutes in timezones with half-hour offsets, as `format` interpreted the duration as a local time of day. Minutes also no longer wrap after an hour. - Inline the minimize/close IPC from electron-window-controls. It declared electron@^12 as a regular dependency, so every install pulled in a second Electron. Handlers are now registered once at startup rather than on every window creation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The project uses Yarn; this npm lockfile was committed by accident in #134 and has drifted from yarn.lock. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## deps/electron-upgrade #161 +/- ##
=========================================================
+ Coverage 34.41% 36.35% +1.94%
=========================================================
Files 102 117 +15
Lines 3173 4296 +1123
Branches 776 1037 +261
=========================================================
+ Hits 1092 1562 +470
- Misses 1933 2527 +594
- Partials 148 207 +59 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
EdgeTX Buddy has been automatically deployed to Cloudflare. |
pfeerick
force-pushed
the
deps/electron-upgrade
branch
from
November 18, 2026 08:34
d5ea932 to
4791952
Compare
Member
Author
5 of 6 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #136 (targets
deps/electron-upgrade). Brings that branch up to date withmain, moves it from Electron 35 (end-of-life) to 45, and drops two dependencies that no longer pull their weight.Commits
chore/yarn-4: brings inmainand the Yarn 4 upgrade (build: upgrade Yarn 3.1 to 4.18 #160). Conflicts in.gitignore/package.jsonresolved by keeping both sides;yarn.lockregenerated once on Yarn 4.build(deps): upgrade Electron 35 to 45electron^35 → ^45.3.3,electron-builder→ ^26.18.0,@electron/rebuild→ ^4.2.1refactor(deps): drop date-fns and electron-window-controlsformat(ms, "mm:ss")call. Re-resolving pulled in 4.4.0, whose typings import./x.tspaths that TypeScript 4.9 can't read. Replaced with a smallformatElapsedhelper (with tests). This also fixes the elapsed build time showing wrong minutes in half-hour-offset timezones (e.g. India), sinceformattreated the duration as a local time of day, and minutes no longer wrap after an hour.src/main/windowControls.ts). The package declaredelectron@^12as a regular dependency, so every install pulled in a second Electron. Handlers are now registered once at startup instead of on every window creation (which stacked listeners on macOS when the window was re-created).Breaking-changes review (Electron 36–45)
Checked against the APIs Buddy uses. Nothing required code changes:
requireselectron(noBuffer/events/timers), so the Electron 45 sandboxed-preload shim removal doesn't apply.high-dpi-support,force-device-scale-factor) are already lowercase (Electron 36 lowercases them).defaultPath.Testing
Locally on Windows, Node 22:
yarn install --immutable,fmt:check,test:types,lint:all(0 errors),compile:productionpassformatElapsedtests passusbnative module loads in the main processelectronMinimize()minimizes andelectronClose()quits, so Playwright 1.29 can still launch Electron 45Still needs manual testing: DFU flashing / SD card writes with a real radio on each OS (especially the arm64 macOS DMG), plus the packaged builds from CI.
🤖 Generated with Claude Code