Skip to content

Refuse conflicting knowledge relation identities - #791

Closed
flip-engineer wants to merge 1 commit into
codex/postrelease-751-761-20261015from
codex/knowledge-relation-785-20261016
Closed

flip-engineer wants to merge 1 commit into
codex/postrelease-751-761-20261015from
codex/knowledge-relation-785-20261016

Conversation

@flip-engineer

@flip-engineer flip-engineer commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Preserve an existing knowledge relation when an ID is reused with a different author, source, relationship or target. Identical retries succeed. Conflicting writes refuse with relation-id-conflict, and relation authors must be registered sessions. Linked records check stored and input collisions before applying the finding, kind, notice, answer and relation writes in one transaction. Link identities and coordinates use SQLite TEXT normalization.

Remote paired qualification used target 476c1fb96e61782b2cf69419c8a8124b4e3d5053 and candidate f77cc16d155e8cedaf84e1cad12b32efd9de4556, with the same 36 fixtures per arm:

  • Candidate: 36 passed. Target: 17 passed and 19 failed the relation or finding table assertions.
  • Both canonical checks, C generation and Clang builds completed naturally. Every fixture child and both private database owners retained their original waits; both owners completed normal shutdown.
  • Final verification rechecked the source closures and all 231 files in the pinned compiler distribution. Root independently verified the original receipt and stream bindings.

The focused entry executes the production command parser, relation IO and linked transaction handling. It returns before Delivery.deliver. The committed knowledge.py suite, full Main, public delivery and installed acceptance remain pending.

Retained results: .scratch/crash-recovery-20261016/knowledge-785-phase-headroom-v3-qualification/original-results.json, SHA256 28142ab8543479d7584a18e2edc5dd691d2238854c1837f48dbb64a739d089f5.

Addresses #785. This draft is stacked on #772. Merge and normal release qualification remain pending.

@flip-engineer

Copy link
Copy Markdown
Collaborator Author

Superseded by #863 at 94b6de0. Source bodies, added tests, store blob, and added-line coverage were checked; the aggregate PR records the evidence and pending runtime acceptance. This branch is preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant