Skip to content

Apply knowledge scope, evidence provenance and relation identity checks - #863

Closed
flip-engineer wants to merge 9 commits into
mainfrom
codex/knowledge-789-791-current-main-20261018
Closed

flip-engineer wants to merge 9 commits into
mainfrom
codex/knowledge-789-791-current-main-20261018

Conversation

@flip-engineer

@flip-engineer flip-engineer commented Oct 18, 2026 •

Copy link
Copy Markdown
Collaborator

Knowledge queries apply the requested scope to graph paths and summaries. Evidence references retain their provenance, and relation creation refuses an existing identity with different endpoints or relation type. Linked-record validation runs before writes.

This consolidates #789, #790 and #791 onto current main. The focused entry calls production AgentActions, Knowledge and Store. Its behavior fixture covers query scope, evidence references, relation conflicts, stored output and setup failures.

Validation: candidate 94b6de0 includes main 2cf17ad. Git tree comparison confirms that integration preserved every PR-owned blob. The corrected fixture still requires a fresh compiler check and bounded runtime pass on the self-hosted homelab runner. No current-head runtime result, merge, or deployment is claimed. #853 tracks host access; #865 tracks focused qualification.

Refs #783, #784, #785, #811.

@flip-engineer

Copy link
Copy Markdown
Collaborator Author

Root review found that the Python behavior driver passed commands before the database, while the Bend2 entry expects DB followed by COMMAND. The driver now prefixes its private database consistently and preserves the seed DB invocation. This corrects the test driver; runtime validation remains pending. Head 4ff485e.

@flip-engineer

Copy link
Copy Markdown
Collaborator Author

A second source review found that fixture setup discarded typed Store.apply failures. The test entry now propagates those failures and records an explicitly empty endpoint for its private endpointless recipient. The behavior test also checks the stored record JSON returned by the production notice path. These changes require a fresh focused source check and runtime run; earlier fixture source checks do not qualify this new head c115960.

@flip-engineer

Copy link
Copy Markdown
Collaborator Author

Source coverage for #789, #790, and #791 is verified at this PR head 94b6de0eb3b73c3f8407e1eace9903c752b9d769. All 24 added or changed knowledge definitions have identical complete source bodies. All 20 added Python test methods have identical syntax trees. Every added nonempty line is present in the corresponding aggregate file. The relation store file matches #791 blob c9505da40cc6e949651be00c40036f24c16fcc6d exactly; the evidence documentation matches #790 blob ddae835feab628a64e2e53117e4bd007fdf507c2 exactly.

The three original PRs are being closed as superseded, with their branches preserved. This consolidates source review. Runtime acceptance remains pending on the self-hosted homelab; this PR stays unmerged until its required validation completes.

@flip-engineer

Copy link
Copy Markdown
Collaborator Author

Superseded: main c405d8a already contains this revision.

Verified against c405d8a:

  • bend2/src/coordinator/knowledge.bend contains evidence_reference, graph_value and relation-id-conflict; control.bend routes graph_value; store.bend treats relation-id-conflict as a refusal. These source blobs are identical to PR head 94b6de0.
  • bend2/test/knowledge-behavior.bend and knowledge-behavior.py carry the knowledge-behavior markers (scope validation and typed graph, evidence/citation resolution, relation identity conflict, traversal modes, fixture setup failures and stored output). Their main versions are a superset of the PR versions.
  • docs/bend2/knowledge-context-2026-09-29.md is identical to the PR head.

Preserved lineage: 94b6de0, 93221d6, 6deeb70, f77cc16, 71d428f0, 4f6ed7e4.

Closed as superseded; no merge performed and the #772 README is not propagated.

@flip-engineer

Copy link
Copy Markdown
Collaborator Author

Root independently verified the superseded closure against main c405d8a. The three production source blobs and knowledge design document are byte-identical to PR head94b6de0e. The focused Bend fixture adds owner/shutdown handling; the Python behavior fixture decodes the stored JSON string before the same assertion; the general driver adds a timeout. No unique production change remains in this PR. The commit histories diverge, so this conclusion is based on source comparison. Branch and commits remain preserved. Proof: retained-root-builds-20261019/root-pr-consolidation-1925/pr863-main-coverage.json.

@flip-engineer
flip-engineer deleted the codex/knowledge-789-791-current-main-20261018 branch October 19, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant