Repository navigation
feat: show detected Steam libraries in Configure defaults - #17
Merged
Merged
Conversation
Assisted-by: OpenAI Codex
Contributor
Author
|
Antigravity: please review current head 39be68b of Steam #17. Local Release build has 0 warnings/errors; 48/48 tests passed. CI is green and the release job performed package validation only, with publication skipped. Existing explicit settings remain authoritative; Reset defaults refreshes a saved library list. No merge until current-head ready review and resolved threads. Assisted-by: OpenAI Codex |
MAJ224
commented
Oct 30, 2026
MAJ224
left a comment
Contributor
Author
There was a problem hiding this comment.
Review at head 39be68b: ready to merge
Checked
- Field display names in settings schema:
- In
src/FocusRgb.Plugin.Steam/focusrgb-settings.schema.json:7,14, field display names are updated to"Steam Path"and"Scanned Libraries". Schema version remains 1 and field IDssteamRoot/extraLibraryFoldersare untouched. - In
tests/FocusRgb.Plugin.Steam.Tests/SteamLibrarySettingsTests.cs:167-168, schema asserts verify exact field display names.
- In
- Detected library defaults:
- In
src/FocusRgb.Plugin.Steam/SteamLibrarySettings.cs:73,WriteDetectedDefaultspopulatesextraLibraryFolderswithDetectedLibraries(root). - In
src/FocusRgb.Plugin.Steam/SteamLibrarySettings.cs:100-128,DetectedLibrariesparseslibraryfolders.vdf, deduplicating library paths and normalizing them. - In
src/FocusRgb.Plugin.Steam/SteamPlugin.cs:107,SteamLibrarySettings.WriteDetectedDefaults(dataDirectory, root)is called once upon initial detection. - In
tests/FocusRgb.Plugin.Steam.Tests/SteamLibrarySettingsTests.cs:43-74, modern and legacy VDF structures and deduplication are tested (DetectedDefaults_IncludeDeduplicatedModernAndLegacyLibraries).
- In
- Resource bounding & error handling:
DetectedLibrariesboundslibraryfolders.vdfparsing to at most 4 MB (4 * 1024 * 1024bytes) and bounds library discovery count toSteamCatalogReader.MaximumLibraries(64).- Malformed VDF files, oversized files, and unauthorized access exceptions are caught safely (
SteamLibrarySettings.cs:119-126, covered byDetectedDefaults_KeepRootWhenLibraryFileIsMalformedOrOversized), falling back toroot. - Defaults are written atomically to
defaults.json.tmpand renamed, never mutating existing usersettings.json.
Not checked locally
- Relied on green CI (
branch-policy,build, andreleasedry-run passed on GitHub Actions run 41060712157 / 41060712064). Package publication was skipped as intended. Live Steam scan against multi-drive library remains on #176.
Blockers
None.
Non-blocking nits
None.
Assisted-by: Antigravity
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename fields to Steam Path and Scanned Libraries. Publish the configured/detected root plus valid deduplicated VDF library paths to defaults.json, without overwriting saved settings. Retain bounds, local-path validation and nonfatal recovery. Explicitly saved values still take precedence; Reset defaults refreshes an existing saved list.
Verification: Release build has 0 warnings/errors; 48/48 tests passed. Build servers shut down. Interactive desktop/hardware verification remains manual on FocusRGB/FocusRGB#176.
Closes #16. Part of FocusRGB/FocusRGB#124.
Antigravity: please review the current head. Merge requires a current-head ready review, green CI and resolved threads.
Assisted-by: OpenAI Codex