Repository navigation
chore: prepare Steam plugin v0.1.2 - #18
Merged
Merged
Conversation
Assisted-by: OpenAI Codex
Contributor
Author
|
Antigravity: please review current head Project and manifest versions both move from 0.1.1 to 0.1.2. Release build: 0 warnings/errors; 48/48 tests passed. CI is pending. No merge until current-head ready review, green CI and resolved threads; no tags, releases or publishing performed. Assisted-by: OpenAI Codex |
MAJ224
commented
Oct 30, 2026
MAJ224
left a comment
Contributor
Author
There was a problem hiding this comment.
Review at head 0ae60be: ready to merge
Checked
- Version bump synchronization:
- In
src/FocusRgb.Plugin.Steam/FocusRgb.Plugin.Steam.csproj:4, assembly version is updated from0.1.1to0.1.2(<Version>0.1.2</Version>). - In
src/FocusRgb.Plugin.Steam/focusrgb-plugin.json:4, manifest version is updated from0.1.1to0.1.2("version": "0.1.2"). - Both files stay strictly in lockstep, satisfying the contract assertions in
tests/FocusRgb.Plugin.Steam.Tests/PluginManifestTests.cs:17-18(Assert.Equal(typeof(SteamPlugin).Assembly.GetName().Version!.ToString(3), manifest.RootElement.GetProperty("version").GetString())).
- In
- Contract & permission immutability:
- Plugin metadata in
focusrgb-plugin.json:3,5,9retains schemaVersion 1, contractVersion "1.2", and resource restriction["filesystem.read"]without permission expansion or drift. - No unrelated or accidental changes are present in the diff.
- Plugin metadata in
Not checked locally
- Relied on green CI (
branch-policy,build, andreleasedry-run passed on GitHub Actions run 41068426837 / 41068426910). Release packaging validation passed with publication skipped as expected. Tagging and release publication remain manual steps onmain.
Blockers
None.
Non-blocking nits
None.
Assisted-by: Antigravity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare Steam plugin 0.1.2 with the merged Steam Path and Scanned Libraries defaults. Bump the project and manifest versions together; SDK dependency and protocol contract stay at 1.2.
Verification: Release build has 0 warnings/errors; 48/48 tests passed, including manifest/assembly version alignment. Build servers shut down. No runtime or hardware checks performed.
Antigravity: please review the current head. Merge into develop only after current-head ready review, green CI and resolved threads. A separate develop-to-main release PR and manual tag/publication are still required before releasing 0.1.2.
Assisted-by: OpenAI Codex