Repository navigation
ci: extend informational Vitest coverage to query retry logic (#651) - #665
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Fooftilly
temporarily deployed
to
project-automation
October 14, 2026 14:30 — with
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
24 of 64 tasks
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Incremental B1 expansion under #651, building on merged Vitest coverage pilot #664.
Extend the existing
.github/workflows/vitest-coverage-pilot.ymljob to also measurefrontend-app/src/query/retry.tswith its existingretry.test.ts, alongsidesrc/lifecycle/tab-leave.tsandtab-leave.test.ts.retry.tscontrols whether safe-GET API requests retry after network errors, 502/503/504 responses, aborts, and exhausted attempts, plus backoff timing. It is a small correctness-sensitive module whose branch coverage is meaningful.Deliberately narrow scope
@vitest/coverage-v8@5.0.2and existingnpm ci --ignore-scripts.The existing job ID/name remains stable even though it now reports on two modules, to avoid changing check identities; the GitHub Actions summary explicitly names both scopes.
First verified baseline
Vitest coverage run 38581099227 succeeded on head
406d073with 15/15 tests passed.src/lifecycle/tab-leave.tssrc/query/retry.tsThis is strictly a two-module measurement, not global frontend coverage. See other CI and review results before merging.
Acceptance checks
src/lifecycle/tab-leave.tsandsrc/query/retry.ts. Inspect the job-summary per-module line/branch totals, not only overall success.tab-leave.ts: 77/94 lines (81.9%) and 53/84 branches (63.1%); preserve or investigate any difference. Record observedretry.tsbaseline from CI before merge.Base:
master@befacaad75bf6bb00fc72da6a5f4b818cf3b1b19.Related: #651 (B1), #662, #664. No merge without maintainer approval.