Skip to content

ci: expand Vitest coverage to owner-resource lifecycle (#651) - #666

Merged
Fooftilly merged 1 commit into
masterfrom
ci/651-vitest-owner-resource-coverage
Oct 14, 2026
Merged

Fooftilly merged 1 commit into
masterfrom
ci/651-vitest-owner-resource-coverage

Conversation

@Fooftilly

@Fooftilly Fooftilly commented Oct 14, 2026 •

Copy link
Copy Markdown
Owner

Summary

Incremental B1 expansion under #651 following the merged #665. Extend the same existing Vitest coverage pilot to include the owner-scoped resource lifecycle module frontend-app/src/lifecycle/owner-resource.ts and its existing owner-resource.test.ts, while retaining tab-leave.ts and query/retry.ts.

This is a high-value correctness slice: owner tokens, generation/epoch validity, warm suspend/resume and cold release prevent stale UI resources (including PDF and notes editors) from being reused or left attached.

Scope and safeguards

  • Only .github/workflows/vitest-coverage-pilot.yml changes. No application code, dependencies, build artifacts or other CI jobs.
  • Run the three existing Vitest test files once with locked Vitest/V8 coverage, report only the three explicitly selected TypeScript source modules.
  • Keep per-module line and branch covered/total and percentages plus a clearly labeled three-module aggregate in the Actions job summary. Fail closed if a module or metric is missing, an unexpected source is included, or totals don't reconcile.
  • Remain informational: no coverage thresholds, coverage data uploads, artifact retention, new permissions or new required check names.
  • Expand the existing PR path filter for owner-resource source and tests; retain all prior triggers.

Verified focused coverage run

GitHub Actions run 38583146240 passed on head 38fe707. All 32 tests in the three targeted test files passed.

Source Lines Branches
src/lifecycle/tab-leave.ts 77/94 (81.9%) 53/84 (63.1%)
src/lifecycle/owner-resource.ts 71/71 (100.0%) 53/61 (86.9%)
src/query/retry.ts 7/7 (100.0%) 6/6 (100.0%)
Three-module aggregate only 155/172 (90.1%) 112/151 (74.2%)

These figures are only for the three targeted modules; remaining CI and review outcomes must be checked separately.

Validation

  • Confirm that the coverage selection glob src/{lifecycle/tab-leave,lifecycle/owner-resource,query/retry}.ts matches exactly the three intended modules.
  • Verify Vitest tests pass and the previous two-module baseline stays stable: tab-leave.ts 77/94 lines and 53/84 branches, retry.ts 7/7 lines and 6/6 branches. Record owner-resource.ts numbers from CI rather than assuming them.
  • Recheck actionlint, zizmor, static analysis, PRKS Test Gate, CodeQL, E2E planner, and reviewer findings before merge.

Base: master@6045040f68cba92020dc5fa25cdb89c9cdef743d (#665 merge). Refs #651, #665, #664.

Do not auto-merge; maintainer approval remains required.

@sourcery-ai

This comment has been minimized.

@coderabbitai

This comment has been minimized.

@chatgpt-codex-connector

This comment has been minimized.

@Fooftilly Fooftilly moved this to Review in PRKS Roadmap Oct 14, 2026
@Fooftilly
Fooftilly merged commit 345193b into master Oct 14, 2026
27 checks passed
@Fooftilly
Fooftilly deleted the ci/651-vitest-owner-resource-coverage branch October 14, 2026 14:59
@github-project-automation github-project-automation Bot moved this from Review to Done in PRKS Roadmap Oct 14, 2026

This branch was previously deployed

1 inactive deployment
project-automation — 38fe707c Deployed Oct 14, 2026 by Fooftilly via sync #469
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant