Repository navigation
Conversation
writeSync already hands the bytes to the kernel, so FileOutput has no buffer and inherits Output.flush. fsync is not that flush, and the kernel returns EINVAL when the descriptor is a pipe or a terminal.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now we use
writeSync, which already does the kernel call. The fsync is a noop for FS and throwsEINVALfor pipes.The proper way to implement this would be to have in-memory buffers, with manual flush, plus automatic flush when the buffer is full, or the file closes or all the other things that should flush the buffer. But I didn't wanna go there. This change is minimal and causes no regressions.