Skip to content

Do not fsync stdout and stderr in Sys.flush #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
back2dos wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not fsync stdout and stderr in Sys.flush #273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Sys.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,9 @@ private class FileOutput extends haxe.io.Output {
Fs.writeSync(fd, s);
}

override public function flush() {
Fs.fsyncSync(fd);
}
// No flush override: writeSync already hands the bytes to the kernel, so
// nothing is buffered. fsync is not flush, and it returns EINVAL on a
// pipe or a terminal.

override public function close() {
Fs.closeSync(fd);
Expand Down
Loading