Repository navigation
Conversation
agustinmista
left a comment
agustinmista
left a comment
There was a problem hiding this comment.
Looking good! Just some small nits.
fd59e15 to
7f29c17
Compare
agustinmista
left a comment
agustinmista
left a comment
There was a problem hiding this comment.
This looks great! Thanks for expanding the previous test suite 🧪
It looks like cabal-format is complaining in CI, though.
…ith an explicit number of indexes
7000c81 to
e4bb2dd
Compare
I think you should be doing this in this PR to prove that claim and so we end up with the same number of bitfield implementations. |
|
|
||
| -- | A compact bitmap representation using serialisation-ready ByteStrings. | ||
| -- | ||
| -- Adapted from @Cardano.Leios.BitMapPV@ in the @leios-wfa-ls-demo@ package. |
There was a problem hiding this comment.
This was a proof of concept. You should instead base your implementation on the production grade version introduced in cardano-crypto-leios
|
|
||
| -- | A bitmap over a number of indexes known to its users: @⌈n/8⌉@ bytes, | ||
| -- MSB-first, bit @i@ set iff index @i@ is set. | ||
| newtype Bitmap = Bitmap {bitmapBytes :: ByteString} |
There was a problem hiding this comment.
This is not a strict container if at its core is a lazy bytestring. Should be a strict bytestring or a ByteArray
This branch has not been deployed
3 participants
Adds
Data.Bitmaptocardano-strict-containers(moved fromOuroboros.Consensus.Util.Bitmap).Now uses MSB-encoding so that it can be easily re-used by Leios
BitFieldrequirements.Used by #701 .
Checklist
CHANGELOG.mdfor the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)