Repository navigation
Conversation
agustinmista
left a comment
There was a problem hiding this comment.
Hey! Nice job!
I have a couple of comments, mostly around serialization and documentation.
In addition:
There was a problem hiding this comment.
Please look into cardano-crypto-leios package to see if there an opportunity for deduplication of logic, there is also a custom implementation of bitmaps
There was a problem hiding this comment.
Please have a look at #700 . The bitmap there should be usable by Leios as well.
2186787 to
c417a9b
Compare
c417a9b to
1e0fc3c
Compare
agustinmista
left a comment
There was a problem hiding this comment.
Great work!
Some questions:
-
Should we change the base of this PR to sit on top of #700? It should be possible to create a PR stack from there and merge all in one go if needed.
-
Do you anticipate any issue when replacing the types in consensus with these?
| perasVotersBitmapFromSeats, | ||
| perasVotersBitmapSeats, | ||
| perasVotersBitmapSize, | ||
| PerasCertVoters (UnsafePerasCertVoters, perasCertVotersBitmap, perasCertNonPersistentVRFOutputs), |
There was a problem hiding this comment.
Q: is this intentionally different from (..)?
bb942d3 to
84cd3f3
Compare
That would make definitely make sense (I am not too familar with the GitHub PR stack feature yet and it did not come to mind).
None at all: I already have a prototype for the changes. |
…ith an explicit number of indexes
…stances to PerasCertSize
84cd3f3 to
15580ce
Compare
Description
Replace stub Peras base types base real types (taken from ouroboros-consensus). cc @agustinmista
This moves the Peras certificate and vote types out of ouroboros-consensus and into
cardano-crypto-peras, so that the ledger can keep certificates typed in the Dijkstra block body instead of as opaque bytes.CBOR instances removed from initial draft (these will go in
cardano-ledger-binaryas per the Leios example).The voters bitmap is built on
Data.Bitmapfrom (unmerged) #700, so this PR includes #700's commits for now.Checklist
CHANGELOG.mdfor the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)