Repository navigation
fix(life): web and macOS caption date picker parity - #5228
Merged
Merged
Conversation
Align year-page captions and sidebar month picker with shared bounds helpers, and surface Life page-jump chips without overlapping birth-date controls. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Contributor
|
Boot bundle: 576.8 KB gzip (-0.0 KB vs main) |
This was referenced Nov 12, 2026
cursor Bot
pushed a commit
that referenced
this pull request
Nov 12, 2026
Reserve Mod chip space invisibly to avoid title layout shift, remove dead mac year-page web helpers, add LifeView layout assertion, and replace artifact-only e2e with narrow light/dark year-grid checks. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Splits Life date-picker parity out of #5179: shared 12-year caption pages on web, matching macOS
DatePickerCaption/SidebarMonthPicker, and Life sidebar layout so page-jump chips stay truthful beside the birth-date control (no ReflectionPreferences / edge-focus scope).Verify
bun run verify→ VERDICT: INCOMPLETE locally (Playwright Chromium missing); web + type-check + lint green on branch.