Repository navigation
fix(macos): shift+arrow nudge for focused grid events - #5236
Open
tyler-dane wants to merge 8 commits into
Open
tyler-dane wants to merge 8 commits into
tyler-dane wants to merge 8 commits into
Conversation
Port CompassKit edge nudge APIs, persist focused nudges before undo, and route hardware shift-arrows ahead of draft keys without altering main router paste, welcome, or life navigation behavior. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/focused-event-shift-arrow-0084
branch
from
November 12, 2026 08:28
dca29d1 to
2d9b81f
Compare
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Route grid edit drafts through DraftNudge.nudgeScheduleEdgeByKeyboard when focusStore has a start/end edge, matching web shift+arrow edge behavior. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Focused saved-event Shift+arrow from fresh
main, minimal router hook, #5194 paste preserved.Latest:
nudgeDraftusesnudgeScheduleEdgeByKeyboardwhen a grid edit draft hasfocusStore.edge(fixestestDraftStartEdgeNudgeUsesFocusedEdgeandtestDraftEndEdgeNudgeOnAllDayDraft).Depends on #5239 for swift-packages to fail on XCTest failures; until then job success may not reflect suite failures.
Verify
FocusedEventShiftNudgeTests(12 cases)FocusedEventShiftArrowKeyboardTestsmacOS CI: 43186705883 @
769b1ea7a— macos-build green, 7 keyboard tests passed.Not queued.