Repository navigation
fix(ci): fail swift-packages job on XCTest failures - #5239
Merged
Merged
Conversation
Parse swift test output for XCTest and Swift Testing failure summaries even when the CLI exits 0. Stabilize CompassData all-day and initial week anchor tests under SPM by pinning Denver through ViewStore or prefs. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Share log detection with selftest using a run 43186705883 fixture, add CompassDeviceTimeZone for device-zone tests, seed Denver primary in AllDay tests, and split initial week anchor device vs pin coverage. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Register EventFormField.recurrence in the form ScrollView so Mod+digit jumps scroll the toggle into view instead of leaving it not hittable. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
swift-packageswhen XCTest/Swift Testing output reports failures even ifswift testexits 0.CompassDeviceTimeZoneseam; mergedmain(test: calendar timezone hint regressions (#5232 / #5235) #5238 helpers).EventFormField.recurrencescroll id so Mod+4 focus scrolls the repeat toggle into view.UI failure postmortem (
90c4ffb2c)EventFormRecurrenceTests.testRecurrenceEndDateCanBeEnabledAndRemovedline 54Not hittableoncompass-event-form-recurrence-toggleafter ⌘4 (log + xcresult artifactcompass-macos-xcresult-shard-3on run 43206884346)EventFormViewcallsscrollTo(EventFormField.recurrence)but no view had.id(EventFormField.recurrence); focus jump did not scroll, toggle stayed under the clip5ff47fe9a; main merge delta had no form UI)CI (head
4a8c2b140)swift-packages:selftest-swift-packages-exit: ok,Executed 318 tests, with 3 tests skipped and 0 failures