Repository navigation
test: exercise multisig governance set_admin against real contracts - #1966
Open
Mikardo001 wants to merge 2 commits into
Open
Mikardo001 wants to merge 2 commits into
Mikardo001 wants to merge 2 commits into
Conversation
Author
|
@LabsCrypt I've resolved the merge conflicts with All other changes from Merge commit: Could you take another look when you have a moment? Thanks! |
Mikardo001
force-pushed
the
fix/issue-1156-testing-multisiggovernance-cross-contract-set
branch
from
October 6, 2026 11:03
4eb1b0c to
f7062b9
Compare
…g-multisiggovernance-cross-contract-set Resolves the merge conflicts with main.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR closes the gap where
MultisigGovernance's admin-transfer path (finalize_admin_transfer -> set_admin) was only ever exercised against a localMockTarget. It wires the reallending_poolandremittance_nftcontracts in as path dev-dependencies and adds integration + negative tests so a realset_admincall is actually driven end-to-end.Related Issue
Changes
🧪 Governance cross-contract test wiring
[MODIFY]
contracts/multisig_governance/Cargo.tomllending_poolandremittance_nftas path dev-dependencies, matching howloan_managerwires its tests.[MODIFY]
contracts/multisig_governance/src/test.rsset_adminfails clearly.[MODIFY]
backend/src/__tests__/adminDisputePagination.test.ts[MODIFY]
backend/src/__tests__/adminGovernanceController.test.tsVerification Results
lending_pool/remittance_nftadded as path dev-dependencies ofmultisig_governance(matchingloan_manager's wiring)set_adminfails clearlycargo test,cargo fmt, clippy green; CI passesCloses #1156