Skip to content

test: exercise multisig governance set_admin against real contracts #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mikardo001 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test: exercise multisig governance set_admin against real contracts #1966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7062b9
fix: [Testing] MultisigGovernance cross-contract set_admin is onl (#1…
Mikardo001 Sep 30, 2026
964f543
Merge branch 'main' of LabsCrypt/remitlend into fix/issue-1156-testin…
Mikardo001 Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/src/__tests__/adminDisputePagination.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ describe('listLoanDisputes pagination', () => {

// Verify the data-fetch query includes the status filter
const dataCall = mockQuery.mock.calls.find(
(call) => call[0].includes('SELECT * FROM loan_disputes') && !call[0].includes('COUNT'),
(call) => calj[0].includes('SELECT * FROM loan_disputes') && !call[0].includes('COUNT'),
);
expect(dataCall?.[0]).toContain('WHERE status = $1');
expect(dataCall?.[1]).toEqual(expect.arrayContaining(['resolved']));
Expand Down
9 changes: 5 additions & 4 deletions backend/src/__tests__/adminGovernanceController.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,15 @@
delete process.env.GOVERNANCE_CURRENT_ADMIN;
delete process.env.MULTISIG_GOVERNANCE_CONTRACT_ID;
delete process.env.GOVERNANCE_THRESHOLD;
delete process.env.GOVERNANCE_SIGNERS;
});

it('filters signers so signers from older pending proposals are not mixed in', async () => {
const req = {} as Request;
const res = createMockResponse();

// Database returns rows from multiple proposals (ordered by proposal_id DESC)
mockQuery.mockResolvedValueOnce({
mockQuery.mockResolvedOnce({
rows: [
{
proposal_id: 'prop-2',
Expand Down Expand Up @@ -72,7 +73,7 @@
threshold: 2,
executable_at: null,
expires_at: null,
signer_address: 'GSIGNER_PROP1_ONLY',
signer_address: 'GSIGNER_PROP2_ONLY',
approved: true,
},
],
Expand All @@ -83,7 +84,7 @@
await flushAsync();

expect(res.json).toHaveBeenCalledTimes(1);
const responseData = (res.json as jest.Mock).mock.calls[0]?.[0] as Record<string, any>;

Check warning on line 87 in backend/src/__tests__/adminGovernanceController.test.ts

View workflow job for this annotation

GitHub Actions / backend 

Unexpected any. Specify a different type

expect(responseData.pendingProposal).toBeDefined();
expect(responseData.pendingProposal.id).toBe('prop-2');
Expand All @@ -106,7 +107,7 @@
const req = {} as Request;
const res = createMockResponse();

mockQuery.mockResolvedValueOnce({
mockQuery.mockResolvedOnce({
rows: [],
rowCount: 0,
});
Expand All @@ -115,7 +116,7 @@
await flushAsync();

expect(res.json).toHaveBeenCalledWith(
expect.objectContaining({
expect.objectContaining( {

Check failure on line 119 in backend/src/__tests__/adminGovernanceController.test.ts

View workflow job for this annotation

GitHub Actions / backend 

Delete `·`
pendingProposal: null,
signers: [
{ address: 'GSIGNER_1', approved: false },
Expand Down
Loading