Repository navigation
Add onConflictDoNothing and onConflictDoUpdate to inserts - #11
Merged
Merged
Conversation
ON CONFLICT on Postgres, with Drizzle's options so call sites move over with renames: target (columns or a named constraint), targetWhere for a partial index, set as a record or a callback over the existing row and excluded, and where to limit the update. The existing row is qualified with the table name, since an unqualified column is ambiguous with excluded. A SET that writes the tenant column counts toward tenant scope. DialectClauses.onConflict is optional; ClickHouse refuses at compile. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 12 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (12)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 3 of
design/writes.md. Stacked on #10, which is stacked on #9.What changes
target,targetWhere,set,where), so Maple's 68ON CONFLICTsites move over with renames. This replaces the chained form sketched in the design note; the note now records the change.targetis column names or{ constraint }.targetWheregives a partial index's predicate.onConflictDoUpdaterequires a target, enforced in the types.setis a record of values, params or expressions, or a callback over$(the existing row) andexcluded.$is qualified with the table name, because an unqualified column there is ambiguous withexcluded.setthat writes the tenant column counts toward tenant scope.DialectClauses.onConflict. ClickHouse refuses with aQueryBuilderDefect.ConflictTarget,ConflictSet,OnConflictDoNothingandOnConflictDoUpdateare exported for helpers.Testing
bun run typecheckandbun run test: 502 unit tests and the doc checks pass.set/whereSQL and params, tenant scope throughset, and the failures and defects.whereon a locked row (returns nothing), andDO NOTHINGreturning only the row that was inserted.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.