Repository navigation
Expand nested untracked files in Git inspection and changed-only context - #105
Closed
MatthiasLew wants to merge 1 commit into
Closed
MatthiasLew wants to merge 1 commit into
MatthiasLew wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #107 at the maintainer's request. Closed without merging; track reproduction, proposed remediation and acceptance criteria in that issue.
When a project adds an untracked source directory, Git's default status collapses it to a directory entry such as
src/. Git inspection then reports that directory as a changed file, and changed-only context can omit every new source file. This was observed while building ai-threat-lab.Request
--untracked-files=allin the existing porcelain-v2 status call. Git still applies ignore rules and NUL-delimited path handling, while downstream secret scanning, symbol analysis, and context selection receive individual paths. No additional subprocess is required.Two regression tests failed before the fix and pass after it: nested untracked files (including a path with a space and an ignored directory), and changed-only context selecting a newly created nested Python module. The existing single-status-call test now expects the explicit flag.
Validation: focused Git/context suites passed (30 tests); full repository suite passed (733 passed, 6 skipped); coverage gate passed at 90%; repository Ruff and git diff --check passed; sdist/wheel build passed. Full dev gate stops at a pre-existing set of eight mypy errors in scripts/unified_benchmark.py on main, addressed independently in PR #106. This PR remains draft until that blocker is resolved and the complete required CI matrix passes.