Repository navigation
Fix strict typing of unified benchmark reports - #106
Closed
MatthiasLew wants to merge 1 commit into
Closed
MatthiasLew wants to merge 1 commit into
MatthiasLew wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #108 at the maintainer's request. Closed without merging; track reproduction, proposed remediation and acceptance criteria in that issue.
The required
python scripts/dev.py --checkgate stops at mypy with eight errors in scripts/unified_benchmark.py on current main. The benchmark result was typed as dict[str, object], so consumers could not index metadata or iterate benchmark rows, and two ignores were both unused and ineffective.Add TypedDict contracts for benchmark entries, metadata and the report, annotate the construction and return value, and express the existing sized-index expectation through a type cast. Remove the ineffective ignores. This change preserves the runtime report and table format.
Validation: the required
python -m mypy src tests scriptsnow reports no issues in all 197 source files; repository-wide Ruff and git diff --check pass. This fixes the pre-existing validation blocker discovered while checking the independent nested-untracked-file fix in PR #105. No benchmark workload was run against user data.