Skip to content

learn(preflight, teamserver-alignment): a flow's return-type change and its callers go in one script; Studio Pro merges origin/<branch> - #529

Closed
saingge wants to merge 1 commit into
MendixMau:masterfrom
saingge:learn/signature-change-and-sp-merge
Closed

saingge wants to merge 1 commit into
MendixMau:masterfrom
saingge:learn/signature-change-and-sp-merge

Conversation

@saingge

@saingge saingge commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Branch: learn/signature-change-and-sp-merge, one commit (b11392e) on origin/master 393d253.

PR body (Direct lane)

What changed and why (one paragraph):
Two field facts from a Mendix 10.24.18 app on mxcli v0.27.0. (1) New STOP row 33 in learned-mdl-preflight.md (385 characters; rows 25-32 are 131-385): change a flow's return type and update its callers in one script, because the first script alone leaves mx check with CE0112 "The 'Variable name' property is required" at a caller stored the way Studio Pro stores a call, while check and exec stay silent. (2) Three lines in teamserver-alignment.md section 2: Studio Pro 10.24.18's "Merge feature branch" merges origin/<branch>, so a fix that exists only locally is not in the merge; push the branch and its note first.

Row Answer
Process none. Row 33 tells the reader to do two edits in one script instead of two scripts.
Dependencies skills/learned-mdl-preflight.md, skills/teamserver-alignment.md, CHANGELOG.md. Row 33 points to learned-workflow-patterns.md section 16, which exists on master. The STOP table is numbered: if another open PR also adds row 33, one of them renumbers. The rename-attribute trap is deliberately not here; it belongs to the model-scope guard PR.
Context cost bin/render-routing.sh --check, base 393d253 to head: baseline 75,510 to 75,611 words (+101; budget 80,000). Stage 5 total 70,080 to 70,181; at stage 5 mdl 31,113 to 31,170, gate 22,769 to 22,813, review 31,410 unchanged; lead, ba, architect, test unchanged. Stage 6 total 45,976 to 46,020 (mdl 10,275 unchanged, gate 21,759 to 21,803, review 25,834 unchanged).
Behaviour NOT RUN: +101 words of baseline-routed text. We will run the section 4a A/B on request.
Runtime n/a: text only.

Field evidence: a Mendix 10.24.18 enterprise app on mxcli v0.27.0 (macOS). Both facts were re-checked on 2026-10-21; details below.

  • No client data anywhere in the diff
  • Size cap: 3 files, 6 insertions
  • Test tier: T0 (inspection) plus tests/wave2/test-mdl-scan.sh, which parses the STOP table
  • Instrument / new skill: n/a, text only
  • CHANGELOG.md line appended, credited saingge
  • New bug entries: n/a

Verification

  • bash tests/wave2/test-mdl-scan.sh: "mdl-scan: 52 passed, 0 failed". bin/render-routing.sh --check passes (numbers above). bin/check-pr-discipline.sh: clean.
  • bin/check-no-client-data.sh: no client data in 1148 tracked files. LEAKGUARD_BASE=origin/master: new capitalised word TheFlow only (a placeholder flow name). git diff --stat origin/master...HEAD | tail -1: 3 files changed, 6 insertions(+).
  • Signature change (kept out of the row, per review). Retest on a synthetic module in a copy of a 10.24.18 app: a nanoflow calls a microflow that returns nothing; the nanoflow was patched into the form Studio Pro stores (UseReturnVariable true, empty ResultVariableName); 692 of 1,662 call activities in the original app have that form. Baseline mx check (Docker): 0 errors. After script A alone (create or modify microflow ... returns Boolean): CE0112. After A then the caller script B: 0 errors. CE0112 did not appear with a caller written by mxcli (UseReturnVariable false), nor when A was drop-and-create. Only a return-type change (nothing to Boolean) was run, so the row's trigger says return type; a parameter change was not run and is not claimed. Not checked: the caller form in the original field case.
  • Studio Pro merge. Studio Pro 10.24.18's own git.log.*.txt (macOS) shows, in order: fetch; log -1 origin/<branch>; notes --ref refs/notes/mx_metadata show <sha>; merge --no-commit -v -q --no-ff origin/<branch>. Seen against a plain git remote only; the text says so.

…nd its callers go in one script; Studio Pro merges origin/<branch>

STOP row 33 (mxcli v0.27.0, Mendix 10.24.18: none-to-Boolean return type; mx check CE0112 at a Studio Pro-authored caller after the first script alone) and a three-line note on what "Merge feature branch" merges.
@MendixMau

Copy link
Copy Markdown
Owner

Behaviour A/B (maintainer accepted the reduced run): tests/behaviour A/B, M=393d253 vs T=b11392e, 3×page + 3×mf per arm (12 reps; no probes; check=NA, no mxcli), 0/0 partial reads. Equal on sections, report, planted, scan, folder, h1, empty, txtcrumb, mfpre, cinloop, rinloop, pos, vfb; uixref T 2/3 vs M 1/3; crumbs T 2,2,2 vs M 2,3,3 (pack differs only in row 33; read as noise at n=3). Row 33 is cited in T's STOP-table checks (2 of 3 mf runs flagged it); no standard task plants its trigger.


Generated by Claude Code

@MendixMau

Copy link
Copy Markdown
Owner

Thanks @saingge! Independent review: MERGE, with the behaviour A/B above. We moved your commit unchanged, with your authorship, into #555, so CI runs without fork approval and we can handle CHANGELOG conflicts. This PR closes when #555 merges; the merge commit carries a Co-authored-by line for you.


Generated by Claude Code

MendixMau added a commit that referenced this pull request Oct 23, 2026
…nd its callers go in one script (#555, from #529)

STOP row 33 in learned-mdl-preflight.md (mxcli v0.27.0, Mendix 10.24.18: changing a microflow's return type from none to Boolean in one script and its callers in the next leaves mx check CE0112 at a Studio Pro-authored caller in between) and a three-line note in teamserver-alignment.md on what Studio Pro's "Merge feature branch" merges. Contributed by @saingge in #529.

Review: MERGE — genuine field facts. Baseline +100 words (73946/80000 after merge). Behaviour A/B (reduced, accepted by the maintainer): M=393d253 vs T=b11392e, 3×page + 3×mf per arm; equal on all metrics except uixref (T better) and crumbs (T 2,2,2 vs M 2,3,3, read as noise at n=3); row 33 cited in T's STOP checks. Security review: safe.

Co-authored-by: saingge <262679532+saingge@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013jQvaonym9V1wKKfAEPmRr
@MendixMau MendixMau closed this Oct 23, 2026
@saingge
saingge deleted the learn/signature-change-and-sp-merge branch October 29, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants