Repository navigation
fix(graph-sweep, lint): name pluggable-widget properties as a reference the catalog can miss (replaces #530) - #556
Merged
Conversation
…ce the catalog can miss graph-sweep's orphan caveat named only layout snippet calls, so a live flow read as "strong evidence of deadness". The orphan list now notes that a flow used only as a pluggable widget's datasource or action property may have no edge, and prints the one search that finds the page that holds it (it needs a REFRESH CATALOG FULL SOURCE catalog, which the note says). The same wording is fixed in review-report.js, and the QUAL004 row in lint-that-actually-runs.md goes from "likely misses" to what was observed, with the issue link. Observed on a Mendix 10.24 app with mxcli v0.27.0 (catalog from REFRESH CATALOG FULL): 5 flows used only as a Gallery's or a third-party widget's microflow datasource had 0 refs rows, "show references to" said "no references found", "describe page" printed each, and QUAL004 flagged each. A Gallery with a microflow datasource and no microflow onClick had its ref (15 of 15); with both, only the onClick ref (2 of 2). The two Data grid 2 microflow datasources in the app had theirs. Test: test-catalog-edge-guard.sh case 1 asserts the note; run against master's graph-sweep.sh at 393d253 it fails on both layouts (22 of 24), with the change it passes 24 of 24. The printed search was run on a copy of the app with a FULL SOURCE catalog and listed the page holding the flow; on a plain FULL catalog it finds nothing and mxcli says so.
Closed
5 of 7 tasks
…eep both sides) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013jQvaonym9V1wKKfAEPmRr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #530 by @saingge. Their commit cb2ab46 is carried unchanged, with their authorship. It moved into our repo so CI runs without fork approval and CHANGELOG conflicts can be resolved here. See #530 for the full description and evidence.
Review: MERGE (independent review: echo-only note plus a doc row, no mxcli call). Security review: safe.
Generated by Claude Code