Repository navigation
new(model-scope): find and put back units a write changed only in XPath whitespace (replaces #535) - #559
Merged
Conversation
…th whitespace mxcli v0.27.0's `alter entity ... rename attribute` rewrote 135 units in 20 modules of a Mendix 10.24.18 app that never referenced the attribute. The only change in each was the line breaks between bracketed XPath conditions; `mxcli diff-local` showed nothing (mendixlabs/mxcli#1596). project-bin/model-scope.py: `report` sorts changed units into real and noise, `restore` checks the noise out of HEAD and updates its ContentsHash rows through mxpatch.py, `check --staged` exits 1 on staged noise (MODEL_SCOPE_OK=1 overrides once). Not wired into exec.sh or the hook yet; that is the next PR. Fixture tests/wave2/test-model-scope.sh, including a golden before/after capture of a real v0.27.0 rename on a public model (fixtures/model-scope/golden-v0.27.0/, CAPTURE.md).
Independent review: the docstring said exec.sh runs it after every write; it is not wired in (the CHANGELOG line says so). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013jQvaonym9V1wKKfAEPmRr
4 of 7 tasks
…eep both sides) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013jQvaonym9V1wKKfAEPmRr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #535 by @saingge. Their commit 487c390 is carried unchanged, with their authorship. It moved into our repo so CI runs without fork approval and CHANGELOG conflicts can be resolved here. See #535 for the full description and evidence.
On top: 9f3561e is a one-line docstring fix from the security review. The docstring said
exec.shrunsrestoreafter every write, but nothing calls it yet.Review: MERGE (independent review: field-proven, captured golden input, nothing calls it yet). Security review: safe. Merge note: #551 also adds a name to
MXTK_PROJECT_BINininstall-manifest.sh, so whichever merges second keeps both.Generated by Claude Code